clk: st: clk-flexgen: Add of_node_put() in st_of_flexgen_setup()
PATCH 1/1 clk: st: clk-flexgen: Add of_node_put() in st_of_flexgen_setup()
In function st_of_flexgen_setup, variable pnode takes the return value of of_get_parent, which gets a node but does not put it. If pnode is not put before the function returns, it may cause a memory leak. Hence put pnode after its last occurrence.
Issue found with Coccinelle.
Signed-off-by Nishka Dasgupta <[email protected]>
--- drivers/clk/st/clk-flexgen.c | 1 + 1 file changed, 1 insertion(+)
drivers/clk/st/clk-flexgen.c +1 -0
@@ -326,6 +326,7 @@ static void __init st_of_flexgen_setup(struct device_node *np)return ; reg =of_iomap (pnode,0 ); +of_node_put (pnode);if (!reg)return ;
Signature · 1 line
2.19.1
Quoting Nishka Dasgupta (2019-08-04 09:31:51)
Quoted 8 lines
In function
st_of_flexgen_setup, variable pnode takes the return value ofof_get_parent, which gets a node but does not put it. If pnode is not put before the function returns, it may cause a memory leak. Hence put pnode after its last occurrence.
Issue found with Coccinelle.Signed-off-by Nishka Dasgupta <[email protected]>---
Applied to clk-next