clk: versatile: Add of_node_put() in cm_osc_setup()
Subsystems (2)
PATCH 1/1 clk: versatile: Add of_node_put() in cm_osc_setup()
In function cm_osc_setup, variable parent takes the value returned by of_get_parent, which gets a node but does not put it. If parent is not put before it goes out of scope, it may cause a memory leak. Hence put parent before the function terminates.
Issue found with Coccinelle.
--- drivers/clk/versatile/clk-versatile.c | 1 + 1 file changed, 1 insertion(+)
drivers/clk/versatile/clk-versatile.c +1 -0
@@ -70,6 +70,7 @@ static void __init cm_osc_setup(struct device_node *np,return ; } cm_base =of_iomap (parent,0 ); +of_node_put (parent);if (!cm_base) {pr_err ("could not remap core module base\n" );return ;
Signature · 1 line
2.19.1
Quoted 7 lines · Nishka Dasgupta
In function
cm_osc_setup, variable parent takes the value returned byof_get_parent, which gets a node but does not put it. If parent is not put before it goes out of scope, it may cause a memory leak. Hence put parent before the function terminates.
Issue found with Coccinelle.Signed-off-by Nishka Dasgupta <[email protected]>
Yours,
Linus Walleij
Quoting Nishka Dasgupta (2019-08-04 09:34:44)
Quoted 8 lines
In function
cm_osc_setup, variable parent takes the value returned byof_get_parent, which gets a node but does not put it. If parent is not put before it goes out of scope, it may cause a memory leak. Hence put parent before the function terminates.
Issue found with Coccinelle.Signed-off-by Nishka Dasgupta <[email protected]>---
Applied to clk-next