x86/spec-ctrl: Remove EAGER_FPU when PV/HVM is disabled.
PATCH 1/1 x86/spec-ctrl: Remove EAGER_FPU when PV/HVM is disabled.
In commit ac3f9a72141a48d40fabfff561d5a7dc0e1b810d:
For one, "no-xen" should not imply "no-eager-fpu", as "eager FPU" mode is to guard guests, not Xen itself, which is also expressed so by print_details().
So when spec-ctrl=pv=off,hvm=off; EAGER_FPU shouldn't be display in lines:
Current[Wrong]:
(XEN) Support for HVM VMs: EAGER_FPU MD_CLEAR
(XEN) Support for PV VMs: EAGER_FPU MD_CLEAR
expectation:
(XEN) Support for HVM VMs: MD_CLEAR
(XEN) Support for PV VMs: MD_CLEAR
--- xen/arch/x86/spec_ctrl.c | 2 ++ 1 file changed, 2 insertions(+)
xen/arch/x86/spec_ctrl.c +2 -0
@@ -128,12 +128,14 @@ static int __init parse_spec_ctrl(const char *s) opt_msr_sc_pv = val; opt_rsb_pv = val; opt_md_clear_pv = val; + opt_eager_fpu = val; }else if ( (val =parse_boolean ("hvm" , s, ss)) >=0 ) { opt_msr_sc_hvm = val; opt_rsb_hvm = val; opt_md_clear_hvm = val; + opt_eager_fpu = val; }else if ( (val =parse_boolean ("msr-sc" , s, ss)) >=0 ) {
Signature · 7 lines
2.22.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 5 lines · Jin Nan Wang
In commit
ac3f9a72141a48d40fabfff561d5a7dc0e1b810d:
For one, "no-xen" should not imply "no-eager-fpu", as "eager FPU" mode is to guard guests, not Xen itself, which is also expressed so byprint_details().
Quoted 8 lines
So when spec-ctrl=pv=off,hvm=off;
EAGER_FPUshouldn't be display in lines:
Current[Wrong]:
(XEN) Support for HVM VMs:EAGER_FPUMD_CLEAR
(XEN) Support for PV VMs:EAGER_FPUMD_CLEARexpectation:
(XEN) Support for HVM VMs:MD_CLEAR
(XEN) Support for PV VMs:MD_CLEAR
Eager FPU is a performance win across the board. It will become an even bigger performance win when we follow in Linux's footsteps and remove the eager option, and associated logic.
I don't see any value in turning it off for speculation related reasons.
~Andrew
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 11 lines · Andrew Cooper
Quoted 10 lines · Jin Nan Wang
In commit
ac3f9a72141a48d40fabfff561d5a7dc0e1b810d:
For one, "no-xen" should not imply "no-eager-fpu", as "eager FPU" mode is to guard guests, not Xen itself, which is also expressed so byprint_details().So when spec-ctrl=pv=off,hvm=off;
EAGER_FPUshouldn't be display in lines:
Current[Wrong]:
(XEN) Support for HVM VMs:EAGER_FPUMD_CLEAR
(XEN) Support for PV VMs:EAGER_FPUMD_CLEAR
Quoted 6 lines
Quoted 3 lines
expectation:
(XEN) Support for HVM VMs:MD_CLEAR
(XEN) Support for PV VMs:MD_CLEAREager FPU is a performance win across the board. It will become an even bigger performance win when we follow in Linux's footsteps and remove the eager option, and associated logic.
OK.
Quoted 1 line
I don't see any value in turning it off for speculation related reasons.
Got it.
Quoted 2 lines
~Andrew
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel