Skip to contentSkip to conversation

dt-bindings: pwm: pwm-mediatek: Add documentation for MT8516

PATCH In review Fabien Parent 4 participants 5 messages Aug 5, 2019 – Aug 22, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 dt-bindings: pwm: pwm-mediatek: Add documentation for MT8516

Add the device-tree documentation for the PWM IP on the MediaTek MT8516 SoCs.

---
 Documentation/devicetree/bindings/pwm/pwm-mediatek.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/pwm/pwm-mediatek.txt +1 -0
index 991728cb46cb..9152bf5afe56 100644
@@ -6,6 +6,7 @@ Required properties:
    - "mediatek,mt7622-pwm": found on mt7622 SoC.
    - "mediatek,mt7623-pwm": found on mt7623 SoC.
    - "mediatek,mt7628-pwm": found on mt7628 SoC.
+   - "mediatek,mt8516-pwm": found on mt8516 SoC.
  - reg: physical base address and length of the controller's registers.
  - #pwm-cells: must be 2. See pwm.txt in this directory for a description of
    the cell format.
Signature · 1 line
2.23.0.rc1
#1 lore raw

PATCH 2/2 pwm: pwm-mediatek: Add MT8516 SoC support

Add the compatible and the platform data to support PWM on the MT8516 SoC.

---
 drivers/pwm/pwm-mediatek.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/pwm/pwm-mediatek.c +7 -0
index eb6674ce995f..6697e30811e7 100644
@@ -302,11 +302,18 @@ static const struct mtk_pwm_platform_data mt7628_pwm_data = {
 	.has_clks = false,
 };
 
+static const struct mtk_pwm_platform_data mt8516_pwm_data = {
+	.num_pwms = 5,
+	.pwm45_fixup = false,
+	.has_clks = true,
+};
+
 static const struct of_device_id mtk_pwm_of_match[] = {
 	{ .compatible = "mediatek,mt2712-pwm", .data = &mt2712_pwm_data },
 	{ .compatible = "mediatek,mt7622-pwm", .data = &mt7622_pwm_data },
 	{ .compatible = "mediatek,mt7623-pwm", .data = &mt7623_pwm_data },
 	{ .compatible = "mediatek,mt7628-pwm", .data = &mt7628_pwm_data },
+	{ .compatible = "mediatek,mt8516-pwm", .data = &mt8516_pwm_data },
 	{ },
 };
 MODULE_DEVICE_TABLE(of, mtk_pwm_of_match);
Signature · 1 line
2.23.0.rc1
maintainer Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] pwm: pwm-mediatek: Add MT8516 SoC support

Quoted 4 lines · Fabien Parent

Add the compatible and the platform data to support PWM on the MT8516 SoC.

Quoted 28 lines
---
 drivers/pwm/pwm-mediatek.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/pwm/pwm-mediatek.c +7 -0
index eb6674ce995f..6697e30811e7 100644
@@ -302,11 +302,18 @@ static const struct mtk_pwm_platform_data mt7628_pwm_data = {
 	.has_clks = false,
 };
 
+static const struct mtk_pwm_platform_data mt8516_pwm_data = {
+	.num_pwms = 5,
+	.pwm45_fixup = false,
+	.has_clks = true,
+};
+
 static const struct of_device_id mtk_pwm_of_match[] = {
 	{ .compatible = "mediatek,mt2712-pwm", .data = &mt2712_pwm_data },
 	{ .compatible = "mediatek,mt7622-pwm", .data = &mt7622_pwm_data },
 	{ .compatible = "mediatek,mt7623-pwm", .data = &mt7623_pwm_data },
 	{ .compatible = "mediatek,mt7628-pwm", .data = &mt7628_pwm_data },
+	{ .compatible = "mediatek,mt8516-pwm", .data = &mt8516_pwm_data },
 	{ },
 };
 MODULE_DEVICE_TABLE(of, mtk_pwm_of_match);
Acked-by on v1 2/2
#3 lore raw

Re: [PATCH 2/2] pwm: pwm-mediatek: Add MT8516 SoC support

In reply to Fabien Parent
Quoted 4 lines · Fabien Parent

Add the compatible and the platform data to support PWM on the MT8516 SoC.

The change looks fine, there is however another series currently waiting for application for this driver that conflicts with this one (I think).

Maybe it would be sensible to join your forces and produce a single series without conflicts?

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |