staging: pi433 line over 80 characters in multiple places
PATCH 1/1 staging: pi433 line over 80 characters in multiple places
Fix the following checkpatch warnings:
WARNING: line over 80 characters
FILE: drivers/staging/pi433/pi433_if.h
Signed-off-by Giridhar Prasath R <[email protected]>
--- drivers/staging/pi433/pi433_if.h | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-)
drivers/staging/pi433/pi433_if.h +16 -7
@@ -117,9 +117,14 @@ struct pi433_rx_cfg {/* packet format */ enum option_on_off enable_sync; -enum option_on_off enable_length_byte;/* should be used in combination with sync, only */ -enum address_filtering enable_address_filtering;/* operational with sync, only */ -enum option_on_off enable_crc;/* only operational, if sync on and fixed length or length byte is used */ +/* should be used in combination with sync, only */ +enum option_on_off enable_length_byte; +/* operational with sync, only */ +enum address_filtering enable_address_filtering; +/* only operational, +* if sync on and fixed length or length byte is used +*/ +enum option_on_off enable_crc;__u8 sync_length;__u8 fixed_message_length;
@@ -132,10 +137,14 @@ struct pi433_rx_cfg {#define PI433_IOC_MAGIC 'r' -#define PI433_IOC_RD_TX_CFG _IOR(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR, char[sizeof(struct pi433_tx_cfg)]) -#define PI433_IOC_WR_TX_CFG _IOW(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR, char[sizeof(struct pi433_tx_cfg)]) +#define PI433_IOC_RD_TX_CFG _IOR(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR,\ +char[sizeof(struct pi433_tx_cfg)]) +#define PI433_IOC_WR_TX_CFG _IOW(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR,\ +char[sizeof(struct pi433_tx_cfg)]) -#define PI433_IOC_RD_RX_CFG _IOR(PI433_IOC_MAGIC, PI433_RX_CFG_IOCTL_NR, char[sizeof(struct pi433_rx_cfg)]) -#define PI433_IOC_WR_RX_CFG _IOW(PI433_IOC_MAGIC, PI433_RX_CFG_IOCTL_NR, char[sizeof(struct pi433_rx_cfg)]) +#define PI433_IOC_RD_RX_CFG _IOR(PI433_IOC_MAGIC, PI433_RX_CFG_IOCTL_NR,\ +char[sizeof(struct pi433_rx_cfg)]) +#define PI433_IOC_WR_RX_CFG _IOW(PI433_IOC_MAGIC, PI433_RX_CFG_IOCTL_NR,\ +char[sizeof(struct pi433_rx_cfg)])#endif /* PI433_H */
Signature · 1 line
2.22.0
The subject needs a colon after "pi433:" but also this change isn't really an improvement so far as readability goes.
regards,
dan carpenter
Greg Kroah-Hartman
maintainerQuoted 33 lines · Giridhar Prasath R
Fix the following checkpatch warnings:
WARNING: line over 80 characters
FILE:drivers/staging/pi433/pi433_if.hSigned-off-by Giridhar Prasath R <[email protected]>--- drivers/staging/pi433/pi433_if.h | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-)drivers/staging/pi433/pi433_if.h +8
-3@@ -117,9 +117,14 @@ struct pi433_rx_cfg {/* packet format */ enum option_on_off enable_sync; -enum option_on_off enable_length_byte;/* should be used in combination with sync, only */ -enum address_filtering enable_address_filtering;/* operational with sync, only */ -enum option_on_off enable_crc;/* only operational, if sync on and fixed length or length byte is used */ +/* should be used in combination with sync, only */ +enum option_on_off enable_length_byte; +/* operational with sync, only */ +enum address_filtering enable_address_filtering; +/* only operational, +* if sync on and fixed length or length byte is used +*/ +enum option_on_off enable_crc;__u8 sync_length;__u8 fixed_message_length;
drivers/staging/pi433/pi433_if.h struct pi433_rx_cfg { · line 141
Quoted 7 lines
drivers/staging/pi433/pi433_if.h +2
-2@@ -132,10 +137,14 @@ struct pi433_rx_cfg {#define PI433_IOC_MAGIC 'r' -#define PI433_IOC_RD_TX_CFG _IOR(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR, char[sizeof(struct pi433_tx_cfg)]) -#define PI433_IOC_WR_TX_CFG _IOW(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR, char[sizeof(struct pi433_tx_cfg)]) +#define PI433_IOC_RD_TX_CFG _IOR(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR,\ +char[sizeof(struct pi433_tx_cfg)])
Ick, that does not look better :(
We write code for humans first, compilers second.
The original is fine, thanks.
greg k-h