Skip to contentSkip to conversation

firmware: ti_sci: Parse all resource ranges even if some is not available

PATCH New Andreas Dannenberg 3 participants 3 messages Aug 5, 2019 – Aug 13, 2019 Texas instruments' system control interface (TISCI) protocol driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firmware: ti_sci: Parse all resource ranges even if some is not available

From: Vignesh Raghavendra <[email protected]>

Do not fail if any of the requested subtypes are not available, but set the number of resources to 0 and continue parsing the resource ranges.

Based on Linux kernel patch by Peter Ujfalusi <[email protected]>

---
 drivers/firmware/ti_sci.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)
drivers/firmware/ti_sci.c +10 -3
index 1fd29f2cdf..62b1dc2006 100644
@@ -3170,6 +3170,7 @@ devm_ti_sci_get_of_resource(const struct ti_sci_handle *handle,
 	u32 resource_subtype;
 	u16 resource_type;
 	struct ti_sci_resource *res;
+	bool valid_set = false;
 	int sets, i, ret;
 	u32 *temp;
 
@@ -3209,12 +3210,15 @@ devm_ti_sci_get_of_resource(const struct ti_sci_handle *handle,
 							&res->desc[i].start,
 							&res->desc[i].num);
 		if (ret) {
-			dev_err(dev, "type %d subtype %d not allocated for host %d\n",
+			dev_dbg(dev, "type %d subtype %d not allocated for host %d\n",
 				resource_type, resource_subtype,
 				handle_to_ti_sci_info(handle)->host_id);
-			return ERR_PTR(ret);
+			res->desc[i].start = 0;
+			res->desc[i].num = 0;
+			continue;
 		}
 
+		valid_set = true;
 		dev_dbg(dev, "res type = %d, subtype = %d, start = %d, num = %d\n",
 			resource_type, resource_subtype, res->desc[i].start,
 			res->desc[i].num);
@@ -3226,7 +3230,10 @@ devm_ti_sci_get_of_resource(const struct ti_sci_handle *handle,
 			return ERR_PTR(-ENOMEM);
 	}
 
-	return res;
+	if (valid_set)
+		return res;
+
+	return ERR_PTR(-EINVAL);
 }
 
 /* Description for K2G */
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 firmware: ti_sci: Parse all resource ranges even if some is not available

Quoted 8 lines · Andreas Dannenberg

From: Vignesh Raghavendra <[email protected]>

Do not fail if any of the requested subtypes are not available, but set the number of resources to 0 and continue parsing the resource ranges.

Based on Linux kernel patch by Peter Ujfalusi <[email protected]>

Thanks and regards,
Lokesh

#2 lore raw

PATCH 1/1 firmware: ti_sci: Parse all resource ranges even if some is not available

In reply to Andreas Dannenberg
Quoted 9 lines · Andreas Dannenberg

From: Vignesh Raghavendra <[email protected]>

Do not fail if any of the requested subtypes are not available, but set the number of resources to 0 and continue parsing the resource ranges.

Based on Linux kernel patch by Peter Ujfalusi <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190813/d7e52076/attachment.sig>