gdbstub: Fix handling of '!' packet with new infra
PATCH 1/1 gdbstub: Fix handling of '!' packet with new infra
Since the '!' packet is not handled by the new infrastructure, gdb_handle_packet() would call run_cmd_parser() with a NULL cmd_parser value, which would lead to an unsupported packet ("$#00") being sent, which could confuse the gdb client.
This also has a side-effect of speeding up the initial connection with gdb.
--- gdbstub.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
gdbstub.c +3 -1
@@ -2587,7 +2587,9 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf)break ; } -run_cmd_parser (s, line_buf, cmd_parser); +if (cmd_parser) { +run_cmd_parser (s, line_buf, cmd_parser); + }return RS_IDLE ; }
Signature · 1 line
2.11.0
Alex Bennée
AppliedQuoted 10 lines · Ramiro Polla
Since the '!' packet is not handled by the new infrastructure,
gdb_handle_packet()would callrun_cmd_parser()with a NULLcmd_parservalue, which would lead to an unsupported packet ("$#00") being sent, which could confuse the gdb client.This also has a side-effect of speeding up the initial connection with gdb.
Fixes 3e2c12615b52 ("gdbstub: Implement deatch (D pkt) with new infra")Signed-off-by Ramiro Polla <[email protected]>
Queued to gdbstub/next, thanks.
Quoted 9 lines
--- gdbstub.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)gdbstub.c +0
-0
gdbstub.c static int gdb_handle_packet(GDBState *s, const char *line_buf) · line 2595
Quoted 10 lines
gdbstub.c +3
-1@@ -2587,7 +2587,9 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf)break ; } -run_cmd_parser (s, line_buf, cmd_parser); +if (cmd_parser) { +run_cmd_parser (s, line_buf, cmd_parser); + }return RS_IDLE ; }
--
Alex Bennée