Skip to contentSkip to conversation

gdbstub: Fix handling of '!' packet with new infra

PATCH Applied Ramiro Polla 2 participants 2 messages Aug 5, 2019 – Aug 6, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gdbstub: Fix handling of '!' packet with new infra

Since the '!' packet is not handled by the new infrastructure, gdb_handle_packet() would call run_cmd_parser() with a NULL cmd_parser value, which would lead to an unsupported packet ("$#00") being sent, which could confuse the gdb client.

This also has a side-effect of speeding up the initial connection with gdb.

Fixes 3e2c12615b52 ("gdbstub: Implement deatch (D pkt) with new infra")
---
 gdbstub.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
gdbstub.c +3 -1
index b470aec8ea..d051344488 100644
@@ -2587,7 +2587,9 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf)
         break;
     }
 
-    run_cmd_parser(s, line_buf, cmd_parser);
+    if (cmd_parser) {
+        run_cmd_parser(s, line_buf, cmd_parser);
+    }
 
     return RS_IDLE;
 }
Signature · 1 line
2.11.0
Applied
#1 lore raw
Quoted 10 lines · Ramiro Polla

Since the '!' packet is not handled by the new infrastructure, gdb_handle_packet() would call run_cmd_parser() with a NULL cmd_parser value, which would lead to an unsupported packet ("$#00") being sent, which could confuse the gdb client.

This also has a side-effect of speeding up the initial connection with gdb.

Fixes 3e2c12615b52 ("gdbstub: Implement deatch (D pkt) with new infra")

Queued to gdbstub/next, thanks.

Quoted 9 lines
---
 gdbstub.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
gdbstub.c +0 -0
index b470aec8ea..d051344488 100644

gdbstub.c static int gdb_handle_packet(GDBState *s, const char *line_buf) · line 2595

Quoted 10 lines
gdbstub.c +3 -1
@@ -2587,7 +2587,9 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf)
         break;
     }
 
-    run_cmd_parser(s, line_buf, cmd_parser);
+    if (cmd_parser) {
+        run_cmd_parser(s, line_buf, cmd_parser);
+    }
 
     return RS_IDLE;
 }

--
Alex Bennée