Skip to contentSkip to conversation

glibc-package.inc: Add linux-libc-headers-dev to glibc-dev

PATCH Superseded Mark Hatle 1 participant 2 messages Aug 6, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Mark Hatle

author
#0 lore raw

PATCH 1/1 glibc-package.inc: Add linux-libc-headers-dev to glibc-dev

Without linux-libc-headers-dev being added to the libc6-dev as a RDEPENDS, the system may fail to install the necessary libc headers.

This can happen when NO_RECOMMENDATIONS = "1" is defined.

During the 'testsdk' this results in failures that look like:

fatal error: linux/errno.h: No such file or directory # include <linux/errno.h>
^~~~~~~~~~~~~~~

This also matches the behavior of musl, which does not suffer from this problem.

---
 meta/recipes-core/glibc/glibc-package.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-core/glibc/glibc-package.inc +2 -1
index b150a34..f5fd87e 100644
@@ -35,7 +35,8 @@ FILES_sln = "${base_sbindir}/sln"
 FILES_${PN}-pic = "${libdir}/*_pic.a ${libdir}/*_pic.map ${libdir}/libc_pic/*.o"
 FILES_libsotruss = "${libdir}/audit/sotruss-lib.so"
 FILES_SOLIBSDEV = "${libdir}/lib*${SOLIBSDEV}"
-FILES_${PN}-dev += "${libdir}/*_nonshared.a ${base_libdir}/*_nonshared.a ${base_libdir}/*.o ${datadir}/aclocal"
+FILES_${PN}-dev = "${libdir}/*_nonshared.a ${base_libdir}/*_nonshared.a ${base_libdir}/*.o ${datadir}/aclocal"
+RDEPENDS_${PN}-dev += "linux-libc-headers-dev"
 FILES_${PN}-staticdev += "${libdir}/*.a ${base_libdir}/*.a"
 FILES_nscd = "${sbindir}/nscd* ${sysconfdir}/init.d/nscd ${systemd_unitdir}/system/nscd* ${sysconfdir}/tmpfiles.d/nscd.conf \
               ${sysconfdir}/nscd.conf ${sysconfdir}/default/volatiles/98_nscd ${localstatedir}/db/nscd"
Signature · 1 line
1.8.3.1
author
#1 lore raw
Quoted 24 lines · Mark Hatle

Without linux-libc-headers-dev being added to the libc6-dev as a RDEPENDS, the system may fail to install the necessary libc headers.

This can happen when NO_RECOMMENDATIONS = "1" is defined.

During the 'testsdk' this results in failures that look like:

fatal error: linux/errno.h: No such file or directory # include <linux/errno.h>
^~~~~~~~~~~~~~~

This also matches the behavior of musl, which does not suffer from this problem.

---
 meta/recipes-core/glibc/glibc-package.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-core/glibc/glibc-package.inc +0 -0
index b150a34..f5fd87e 100644

meta/recipes-core/glibc/glibc-package.inc FILES_sln = "${base_sbindir}/sln" · line 39

Quoted 6 lines
meta/recipes-core/glibc/glibc-package.inc +2 -1
@@ -35,7 +35,8 @@ FILES_sln = "${base_sbindir}/sln"
 FILES_${PN}-pic = "${libdir}/*_pic.a ${libdir}/*_pic.map ${libdir}/libc_pic/*.o"
 FILES_libsotruss = "${libdir}/audit/sotruss-lib.so"
 FILES_SOLIBSDEV = "${libdir}/lib*${SOLIBSDEV}"
-FILES_${PN}-dev += "${libdir}/*_nonshared.a ${base_libdir}/*_nonshared.a ${base_libdir}/*.o ${datadir}/aclocal"
+FILES_${PN}-dev = "${libdir}/*_nonshared.a ${base_libdir}/*_nonshared.a ${base_libdir}/*.o ${datadir}/aclocal"
+RDEPENDS_${PN}-dev += "linux-libc-headers-dev"

Argh, I mangled the above.. Will send a V2.. sorry.

Quoted 4 lines
meta/recipes-core/glibc/glibc-package.inc +0 -0
 FILES_${PN}-staticdev += "${libdir}/*.a ${base_libdir}/*.a"
 FILES_nscd = "${sbindir}/nscd* ${sysconfdir}/init.d/nscd ${systemd_unitdir}/system/nscd* ${sysconfdir}/tmpfiles.d/nscd.conf \
               ${sysconfdir}/nscd.conf ${sysconfdir}/default/volatiles/98_nscd ${localstatedir}/db/nscd"