Skip to contentSkip to conversation

i2c: designware: Fix unused variable warning in i2c_dw_init_recovery_info

PATCH In review Gustavo A. R. Silva 2 participants 2 messages Aug 6, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c: designware: Fix unused variable warning in i2c_dw_init_recovery_info

Fix the following warning:

drivers/i2c/busses/i2c-designware-master.c: In function ‘i2c_dw_init_recovery_info’:
drivers/i2c/busses/i2c-designware-master.c:658:6: warning: unused variable ‘r’ [-Wunused-variable]

  int r;
      ^
Fixes 33eb09a02e8d ("i2c: designware: make use of devm_gpiod_get_optional")
---
 drivers/i2c/busses/i2c-designware-master.c | 1 -
 1 file changed, 1 deletion(-)
drivers/i2c/busses/i2c-designware-master.c +0 -1
index 867787dade43..e8b328242256 100644
@@ -655,7 +655,6 @@ static int i2c_dw_init_recovery_info(struct dw_i2c_dev *dev)
 	struct i2c_bus_recovery_info *rinfo = &dev->rinfo;
 	struct i2c_adapter *adap = &dev->adapter;
 	struct gpio_desc *gpio;
-	int r;
 
 	gpio = devm_gpiod_get_optional(dev->dev, "scl", GPIOD_OUT_HIGH);
 	if (IS_ERR_OR_NULL(gpio))
Signature · 1 line
2.22.0
#1 lore raw

Hi

Quoted 10 lines · Gustavo A. R. Silva

Fix the following warning:

drivers/i2c/busses/i2c-designware-master.c: In function ‘i2c_dw_init_recovery_info’:
drivers/i2c/busses/i2c-designware-master.c:658:6: warning: unused variable ‘r’ [-Wunused-variable]

   int r;
       ^
Fixes 33eb09a02e8d ("i2c: designware: make use of devm_gpiod_get_optional")

---

This was fixed yesterday, not applied yet though:

https://www.spinics.net/lists/linux-i2c/msg41651.html

Signature · 1 line
Jarkko