Skip to contentSkip to conversation

app/compress-perf: fix memory deallocation issue

PATCH Applied Adam Dybkowski 3 participants 3 messages Aug 6, 2019 – Sep 19, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 app/compress-perf: fix memory deallocation issue

This patch fixes the memory deallocation issue which happened after unsuccessful allocation (e.g. due to the out of memory) and produced the segmentation fault.

Fixes 424dd6c8c1 ("app/compress-perf: add weak functions for multicore test")
---
 app/test-compress-perf/comp_perf_test_common.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
app/test-compress-perf/comp_perf_test_common.c +7 -4
index 6edc40f04..7b26734c9 100644
@@ -81,10 +81,13 @@ comp_perf_free_memory(struct cperf_mem_resources *mem)
 {
 	uint32_t i;
 
-	for (i = 0; i < mem->total_bufs; i++) {
-		rte_pktmbuf_free(mem->comp_bufs[i]);
-		rte_pktmbuf_free(mem->decomp_bufs[i]);
-	}
+	if (mem->decomp_bufs != NULL)
+		for (i = 0; i < mem->total_bufs; i++)
+			rte_pktmbuf_free(mem->decomp_bufs[i]);
+
+	if (mem->comp_bufs != NULL)
+		for (i = 0; i < mem->total_bufs; i++)
+			rte_pktmbuf_free(mem->comp_bufs[i]);
 
 	rte_free(mem->decomp_bufs);
 	rte_free(mem->comp_bufs);
Signature · 1 line
2.17.1
Applied
#2 lore raw
In reply to Adam Dybkowski
Quoted 10 lines

This patch fixes the memory deallocation issue which happened after unsuccessful allocation (e.g. due to the out of memory) and produced the segmentation fault.

Fixes 424dd6c8c1 ("app/compress-perf: add weak functions for multicore

test")

---

Applied to dpdk-next-crypto

Thanks.