Staging: rtl8188eu: core: rtw_security: fixed a coding style issue
PATCH 1/1 Staging: rtl8188eu: core: rtw_security: fixed a coding style issue
Fixed WARNING: else is not generally useful after a break or return
--- drivers/staging/rtl8188eu/core/rtw_security.c | 41 +++++++++---------- 1 file changed, 20 insertions(+), 21 deletions(-)
drivers/staging/rtl8188eu/core/rtw_security.c +20 -21
@@ -87,29 +87,28 @@ static u8 crc32_reverseBit(u8 data)static void crc32_init (void ) { -if (bcrc32initialized ==1 ) { +int i, j; +u32 c; +u8 *p = (u8 *)&c, *p1; +u8 k; + +if (bcrc32initialized ==1 )return ; - }else { -int i, j; -u32 c; -u8 *p = (u8 *)&c, *p1; -u8 k; - - c =0x12340000 ; - -for (i =0 ; i <256 ; ++i) { - k =crc32_reverseBit ((u8 )i); -for (c = ((u32 )k) <<24 , j =8 ; j >0 ; --j) - c = c &0x80000000 ? (c <<1 ) ^CRC32_POLY : (c <<1 ); - p1 = (u8 *)&crc32_table[i]; - - p1[0 ] =crc32_reverseBit (p[3 ]); - p1[1 ] =crc32_reverseBit (p[2 ]); - p1[2 ] =crc32_reverseBit (p[1 ]); - p1[3 ] =crc32_reverseBit (p[0 ]); - } - bcrc32initialized =1 ; + + c =0x12340000 ; + +for (i =0 ; i <256 ; ++i) { + k =crc32_reverseBit ((u8 )i); +for (c = ((u32 )k) <<24 , j =8 ; j >0 ; --j) + c = c &0x80000000 ? (c <<1 ) ^CRC32_POLY : (c <<1 ); + p1 = (u8 *)&crc32_table[i]; + + p1[0 ] =crc32_reverseBit (p[3 ]); + p1[1 ] =crc32_reverseBit (p[2 ]); + p1[2 ] =crc32_reverseBit (p[1 ]); + p1[3 ] =crc32_reverseBit (p[0 ]); } + bcrc32initialized =1 ; }static __le32 getcrc32 (u8 *buf,int len)
Signature · 1 line
2.17.1
Quoted 2 lines · Merwin Trever Ferrao
Fixed WARNING: else is not generally useful after a break or return
---
Much better, but you forgot the the Signed-off-by so we can't apply it.
Also it's nice to be more specific with the subject. [PATCH] Staging: rtl8188eu: rtw_security: tidy up crc32_init(). And for the full commit message maybe write something like:
This code generates a checkpatch warning:
WARNING: else is not generally useful after a break or return
If we move the declarations to the start of the function then we can pull the code back one tab and it makes the function a lot more readable.
regards,
dan carpenter