Skip to contentSkip to conversation

package/wpewebkit: fix gstreamer-gl dependency

PATCH New James Hilliard 3 participants 4 messages Aug 7, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/wpewebkit: fix gstreamer-gl dependency

The gstreamer1 opengl plugin was moved from gst1-plugins-bad to gst1-plugins-base so we need to update wpewebkit to depend on the correct package.

---
 package/wpewebkit/Config.in    | 3 +--
 package/wpewebkit/wpewebkit.mk | 1 +
 2 files changed, 2 insertions(+), 2 deletions(-)
package/wpewebkit/Config.in +1 -2
index 2808a3c8b3..5f3e237c53 100644
@@ -93,8 +93,7 @@ if BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA
 config BR2_PACKAGE_WPEWEBKIT_USE_GSTREAMER_GL
 	bool "use gstreamer-gl"
 	default y
-	depends on BR2_PACKAGE_GST1_PLUGINS_BASE_HAS_LIB_OPENGL
-	select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_GL
+	depends on BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_OPENGL
 	help
 	  Use the GStreamer GL elements for handling video content.
 	  This is recommended as it improves performance of video
package/wpewebkit/wpewebkit.mk +1 -0
index 4dc4a29064..f6cc7a23ce 100644
@@ -34,6 +34,7 @@ endif
 
 ifeq ($(BR2_PACKAGE_WPEWEBKIT_USE_GSTREAMER_GL),y)
 WPEWEBKIT_CONF_OPTS += -DUSE_GSTREAMER_GL=ON
+WPEWEBKIT_DEPENDENCIES += gst1-plugins-base
 else
 WPEWEBKIT_CONF_OPTS += -DUSE_GSTREAMER_GL=OFF
 endif
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/wpewebkit: fix gstreamer-gl dependency

Hello James,

Patch looks good. We are going to need the similar changes for the webkitgtk package as well. Would you like to take care of it as well?

Quoted 5 lines · James Hilliard

The gstreamer1 opengl plugin was moved from gst1-plugins-bad to gst1-plugins-base so we need to update wpewebkit to depend on the correct package.

Quoted 34 lines
---
 package/wpewebkit/Config.in    | 3 +--
 package/wpewebkit/wpewebkit.mk | 1 +
 2 files changed, 2 insertions(+), 2 deletions(-)
package/wpewebkit/Config.in +1 -2
index 2808a3c8b3..5f3e237c53 100644
@@ -93,8 +93,7 @@ if BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA
 config BR2_PACKAGE_WPEWEBKIT_USE_GSTREAMER_GL
 	bool "use gstreamer-gl"
 	default y
-	depends on BR2_PACKAGE_GST1_PLUGINS_BASE_HAS_LIB_OPENGL
-	select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_GL
+	depends on BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_OPENGL
 	help
 	  Use the GStreamer GL elements for handling video content.
 	  This is recommended as it improves performance of video
package/wpewebkit/wpewebkit.mk +1 -0
index 4dc4a29064..f6cc7a23ce 100644
@@ -34,6 +34,7 @@ endif
 
 ifeq ($(BR2_PACKAGE_WPEWEBKIT_USE_GSTREAMER_GL),y)
 WPEWEBKIT_CONF_OPTS += -DUSE_GSTREAMER_GL=ON
+WPEWEBKIT_DEPENDENCIES += gst1-plugins-base
 else
 WPEWEBKIT_CONF_OPTS += -DUSE_GSTREAMER_GL=OFF
 endif
Signature · 1 line
2.20.1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190807/fdc13dbf/attachment.asc>

#2 lore raw

PATCH 1/1 package/wpewebkit: fix gstreamer-gl dependency

Quoted 5 lines · Adrian Perez de Castro

Hello James,

Patch looks good. We are going to need the similar changes for the webkitgtk package as well. Would you like to take care of it as well?

https://patchwork.ozlabs.org/patch/1143636/

Quoted 44 lines · James Hilliard
Quoted 5 lines

The gstreamer1 opengl plugin was moved from gst1-plugins-bad to gst1-plugins-base so we need to update wpewebkit to depend on the correct package.

Quoted 34 lines
---
 package/wpewebkit/Config.in    | 3 +--
 package/wpewebkit/wpewebkit.mk | 1 +
 2 files changed, 2 insertions(+), 2 deletions(-)
package/wpewebkit/Config.in +1 -2
index 2808a3c8b3..5f3e237c53 100644
@@ -93,8 +93,7 @@ if BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA
 config BR2_PACKAGE_WPEWEBKIT_USE_GSTREAMER_GL
      bool "use gstreamer-gl"
      default y
-     depends on BR2_PACKAGE_GST1_PLUGINS_BASE_HAS_LIB_OPENGL
-     select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_GL
+     depends on BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_OPENGL
      help
        Use the GStreamer GL elements for handling video content.
        This is recommended as it improves performance of video
package/wpewebkit/wpewebkit.mk +1 -1
index 4dc4a29064..f6cc7a23ce 100644
@@ -34,6 +34,7 @@ endif
 
 ifeq ($(BR2_PACKAGE_WPEWEBKIT_USE_GSTREAMER_GL),y)
 WPEWEBKIT_CONF_OPTS += -DUSE_GSTREAMER_GL=ON
+WPEWEBKIT_DEPENDENCIES += gst1-plugins-base
 else
 WPEWEBKIT_CONF_OPTS += -DUSE_GSTREAMER_GL=OFF
 endif
--

2.20.1

#3 lore raw

PATCH 1/1 package/wpewebkit: fix gstreamer-gl dependency

In reply to James Hilliard
Quoted 3 lines · On Tue, 6 Aug 2019 22:45:11 -0600 James Hilliard <[email protected]>…

ifeq ($(BR2_PACKAGE_WPEWEBKIT_USE_GSTREAMER_GL),y) WPEWEBKIT_CONF_OPTS += -DUSE_GSTREAMER_GL=ON
+WPEWEBKIT_DEPENDENCIES += gst1-plugins-base

This addition is not needed: gst1-plugins-base is already added to DEPENDENCIES when BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA=y, and BR2_PACKAGE_WPEWEBKIT_USE_GSTREAMER_GL depends on BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA.

Applied with this fixed. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com