test/py: avb: Move AVB test to android dir
PATCH 1/1 test/py: avb: Move AVB test to android dir
---
test/py/tests/{ => test_android}/test_avb.py | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename test/py/tests/{ => test_android}/test_avb.py (100%)test/py/tests/test_android/test_avb.py renamed from test/py/tests/test_avb.py +0 -0
Signature · 1 line
2.20.1
PATCH 1/1 test/py: avb: Move AVB test to android dir
Hi,
test/py/tests/test_android/test_avb.py
Quoted 12 lines · Sam Protsenko
Signed-off-by Sam Protsenko <[email protected]>--- test/py/tests/{ => test_android}/test_avb.py | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename test/py/tests/{ => test_android}/test_avb.py (100%)test/py/tests/test_android/test_avb.py renamed from test/py/tests/test_avb.py +0
-1--
I'd prefer to keep tsts in one place. What is the goal of this patch?
Regards,
Simon
Quoted 2 lines
2.20.1
PATCH 1/1 test/py: avb: Move AVB test to android dir
Hi Simon,
Quoted 11 lines · Simon Glass
Hi,
Quoted 7 lines · Sam Protsenko
Signed-off-by Sam Protsenko <[email protected]>--- test/py/tests/{ => test_android}/test_avb.py | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename test/py/tests/{ => test_android}/test_avb.py (100%)
Quoted 8 lines
test/py/tests/test_android/test_avb.py
Quoted 5 lines
test/py/tests/test_android/test_avb.py renamed from test/py/tests/test_avb.py +0
-1--I'd prefer to keep tsts in one place. What is the goal of this patch?
It was me who asked Igor to make that change. I thought it would be convenient to keep all Android related tests in one place (for now it's AVB and A/B tests), so that:
1. We can tell which ones are Android related
2. We can run all Android tests with one command
As I understand, it doesn't break anything. I got the idea from test_fs/ I guess. If you oppose this change, we can just drop it.
Thanks!
Quoted 6 lines
Regards,
SimonQuoted 2 lines
2.20.1
PATCH 1/1 test/py: avb: Move AVB test to android dir
Quoted 24 lines · Sam Protsenko
Hi Simon,
Quoted 11 lines · Simon Glass
Hi,
Quoted 7 lines · Sam Protsenko
Signed-off-by Sam Protsenko <[email protected]>--- test/py/tests/{ => test_android}/test_avb.py | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename test/py/tests/{ => test_android}/test_avb.py (100%)Quoted 8 lines
test/py/tests/test_android/test_avb.py
Quoted 5 lines
test/py/tests/test_android/test_avb.py renamed from test/py/tests/test_avb.py +0
-1--I'd prefer to keep tsts in one place. What is the goal of this patch?
Quoted 9 lines
It was me who asked Igor to make that change. I thought it would be convenient to keep all Android related tests in one place (for now it's AVB and A/B tests), so that:
1. We can tell which ones are Android related
2. We can run all Android tests with one commandAs I understand, it doesn't break anything. I got the idea from test_fs/ I guess. If you oppose this change, we can just drop it.
Sorry, I confused this one with Igor Opaniuk patch from A/B patch series, where he adds the test for A/B, in test_android/ directory. I thought it was good idea to keep everything Android-related in separate namespace. If you want to keep all patches in one place, we can do that, but Igor will need to re-send his A/B patch series once again.
Quoted 8 lines
Thanks!
Quoted 6 lines
Regards,
SimonQuoted 2 lines
2.20.1
PATCH 1/1 test/py: avb: Move AVB test to android dir
In reply to Simon GlassHi Simon,
Quoted 11 lines · Simon Glass
Hi,
Quoted 7 lines · Sam Protsenko
Signed-off-by Sam Protsenko <[email protected]>--- test/py/tests/{ => test_android}/test_avb.py | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename test/py/tests/{ => test_android}/test_avb.py (100%)
Quoted 8 lines
test/py/tests/test_android/test_avb.py
Quoted 5 lines
test/py/tests/test_android/test_avb.py renamed from test/py/tests/test_avb.py +0
-1--I'd prefer to keep tsts in one place. What is the goal of this patch?
Similar patch was merged recently (adding test_android/ dir):
https://patchwork.ozlabs.org/patch/1128013/
So we need either:
1. move that test out of test_android/ dir, and drop this one
2. or apply this patch
What would you prefer? (I've explained my perspective on that matter earlier in this thread). We should do either (1) or (2) to keep the consistency.
Thanks.
Quoted 6 lines
Regards,
SimonQuoted 2 lines
2.20.1
PATCH 1/1 test/py: avb: Move AVB test to android dir
Quoted 27 lines · Sam Protsenko
Hi Simon,
Quoted 11 lines · Simon Glass
Hi,
Quoted 7 lines · Sam Protsenko
Signed-off-by Sam Protsenko <[email protected]>--- test/py/tests/{ => test_android}/test_avb.py | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename test/py/tests/{ => test_android}/test_avb.py (100%)Quoted 8 lines
test/py/tests/test_android/test_avb.py
Quoted 5 lines
test/py/tests/test_android/test_avb.py renamed from test/py/tests/test_avb.py +0
-1--I'd prefer to keep tsts in one place. What is the goal of this patch?
Similar patch was merged recently (adding test_android/ dir):
https://patchwork.ozlabs.org/patch/1128013/
Quoted 7 lines
So we need either:
1. move that test out of test_android/ dir, and drop this one
2. or apply this patchWhat would you prefer? (I've explained my perspective on that matter earlier in this thread). We should do either (1) or (2) to keep the consistency.
Note that we've also had vboot as a sub-directory since it was introduced and test_fs is also a sub-directory. My two cents is that sub-directories help with organization as the number of tests increase.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190725/8cc59ef6/attachment.sig>
PATCH 1/1 test/py: avb: Move AVB test to android dir
Hi Tom,
Quoted 33 lines · Tom Rini
Quoted 31 lines · Sam Protsenko
Hi Simon,
Quoted 11 lines · Simon Glass
Hi,
Quoted 7 lines · Sam Protsenko
Signed-off-by Sam Protsenko <[email protected]>--- test/py/tests/{ => test_android}/test_avb.py | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename test/py/tests/{ => test_android}/test_avb.py (100%)Quoted 8 lines
test/py/tests/test_android/test_avb.py
Quoted 5 lines
test/py/tests/test_android/test_avb.py renamed from test/py/tests/test_avb.py +0
-1--I'd prefer to keep tsts in one place. What is the goal of this patch?
Similar patch was merged recently (adding test_android/ dir):
https://patchwork.ozlabs.org/patch/1128013/So we need either:
1. move that test out of test_android/ dir, and drop this one
2. or apply this patch
Quoted 8 lines
Quoted 3 lines
What would you prefer? (I've explained my perspective on that matter earlier in this thread). We should do either (1) or (2) to keep the consistency.
Note that we've also had vboot as a sub-directory since it was introduced and
test_fsis also a sub-directory. My two cents is that sub-directories help with organization as the number of tests increase.
If there are no further concerns, can you please apply it for -rc2, so it doesn't get lost in ML?
Thanks!
Quoted 2 lines
--
Tom
PATCH 1/1 test/py: avb: Move AVB test to android dir
Quoted 40 lines · Sam Protsenko
Hi Tom,
Quoted 37 lines · Tom Rini
Quoted 34 lines · Sam Protsenko
Hi Simon,
Quoted 11 lines · Simon Glass
Hi,
Quoted 7 lines · Sam Protsenko
Signed-off-by Sam Protsenko <[email protected]>--- test/py/tests/{ => test_android}/test_avb.py | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename test/py/tests/{ => test_android}/test_avb.py (100%)Quoted 8 lines
test/py/tests/test_android/test_avb.py
Quoted 5 lines
test/py/tests/test_android/test_avb.py renamed from test/py/tests/test_avb.py +0
-1--I'd prefer to keep tsts in one place. What is the goal of this patch?
Similar patch was merged recently (adding test_android/ dir):
https://patchwork.ozlabs.org/patch/1128013/So we need either:
1. move that test out of test_android/ dir, and drop this one
2. or apply this patchWhat would you prefer? (I've explained my perspective on that matter earlier in this thread). We should do either (1) or (2) to keep the consistency.
Quoted 7 lines
Quoted 4 lines
Note that we've also had vboot as a sub-directory since it was introduced and
test_fsis also a sub-directory. My two cents is that sub-directories help with organization as the number of tests increase.If there are no further concerns, can you please apply it for -rc2, so it doesn't get lost in ML?
For the record, yes. Given that we do have other sub-directories of tests and that over time organization will help with clarity not hinder it, I'm going to grab this.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190807/7b8a199a/attachment.sig>
PATCH 1/1 test/py: avb: Move AVB test to android dir
In reply to Sam ProtsenkoQuoted 1 line · Sam Protsenko
Signed-off-by Sam Protsenko <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190807/b94a12c0/attachment.sig>