ixgbe: fix possible deadlock in ixgbe_service_task()
Subsystems (2)
PATCH v2 1/1 ixgbe: fix possible deadlock in ixgbe_service_task()
ixgbe_service_task() calls unregister_netdev() under rtnl_lock(). But unregister_netdev() internally calls rtnl_lock(). So deadlock would occur.
Fixes 59dd45d550c5 ("ixgbe: firmware recovery mode")
Signed-off-by Taehee Yoo <[email protected]>
---
v2: remove unnecessary curly braces.
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +1 -4
@@ -7897,11 +7897,8 @@ static void ixgbe_service_task(struct work_struct *work)return ; }if (ixgbe_check_fw_error (adapter)) { -if (!test_bit (__IXGBE_DOWN, &adapter->state)) { -rtnl_lock (); +if (!test_bit (__IXGBE_DOWN, &adapter->state))unregister_netdev (adapter->netdev); -rtnl_unlock (); - }ixgbe_service_event_complete (adapter);return ; }
Signature · 1 line
2.17.1