video: fbdev/mmp/core: Use struct_size() in kzalloc()
PATCH 1/1 video: fbdev/mmp/core: Use struct_size() in kzalloc()
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example:
struct mmp_path {
...
struct mmp_overlay overlays[0];
};size = sizeof(struct mmp_path) + count * sizeof(struct mmp_overlay); instance = kzalloc(size, GFP_KERNEL)
Instead of leaving these open-coded and prone to type mistakes, we can now use the new struct_size() helper:
instance = kzalloc(struct_size(instance, overlays, count), GFP_KERNEL)
Notice that, in this case, variable size is not necessary, hence it is removed.
This code was detected with the help of Coccinelle.
--- drivers/video/fbdev/mmp/core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/video/fbdev/mmp/core.c +2 -4
@@ -153,13 +153,11 @@ EXPORT_SYMBOL_GPL(mmp_get_path);struct mmp_path *mmp_register_path (struct mmp_path_info *info) {int i; -size_t size;struct mmp_path *path =NULL ;struct mmp_panel *panel; - size =sizeof (struct mmp_path ) - +sizeof (struct mmp_overlay ) * info->overlay_num; - path =kzalloc (size,GFP_KERNEL ); + path =kzalloc (struct_size (path, overlays, info->overlay_num), +GFP_KERNEL );if (!path)return NULL ;
Signature · 1 line
2.22.0
Quoted 15 lines · Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example:
struct mmp_path { ... struct mmp_overlay overlays[0]; };size =
sizeof(struct mmp_path)+ count *sizeof(struct mmp_overlay); instance =kzalloc(size, GFP_KERNEL)Instead of leaving these open-coded and prone to type mistakes, we can now use the new
struct_size()helper:
Quoted 8 lines
instance =
kzalloc(struct_size(instance, overlays, count), GFP_KERNEL)Notice that, in this case, variable size is not necessary, hence it is removed.
This code was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Patch queued for v5.4, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics