migration: use migration_in_postcopy() to check POSTCOPY_ACTIVE
PATCH 1/1 migration: use migration_in_postcopy() to check POSTCOPY_ACTIVE
Use common helper function to check the state.
Signed-off-by Wei Yang <[email protected]>
--- migration/rdma.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
migration/rdma.c +3 -3
@@ -3140,7 +3140,7 @@ static size_t qemu_rdma_save_page(QEMUFile *f, void *opaque,CHECK_ERROR_STATE (); -if (migrate_get_current ()->state ==MIGRATION_STATUS_POSTCOPY_ACTIVE ) { +if (migration_in_postcopy ()) {rcu_read_unlock ();return RAM_SAVE_CONTROL_NOT_SUPP ; }
@@ -3775,7 +3775,7 @@ static int qemu_rdma_registration_start(QEMUFile *f, void *opaque,CHECK_ERROR_STATE (); -if (migrate_get_current ()->state ==MIGRATION_STATUS_POSTCOPY_ACTIVE ) { +if (migration_in_postcopy ()) {rcu_read_unlock ();return 0 ; }
@@ -3810,7 +3810,7 @@ static int qemu_rdma_registration_stop(QEMUFile *f, void *opaque,CHECK_ERROR_STATE (); -if (migrate_get_current ()->state ==MIGRATION_STATUS_POSTCOPY_ACTIVE ) { +if (migration_in_postcopy ()) {rcu_read_unlock ();return 0 ; }
Signature · 1 line
2.17.1
Quoted 3 lines · * Wei Yang ([email protected]) wrote:
Use common helper function to check the state.
Signed-off-by Wei Yang <[email protected]>
Reviewed-by Dr. David Alan Gilbert <[email protected]>
Quoted 38 lines
--- migration/rdma.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)migration/rdma.c +3
-3@@ -3140,7 +3140,7 @@ static size_t qemu_rdma_save_page(QEMUFile *f, void *opaque,CHECK_ERROR_STATE (); -if (migrate_get_current ()->state ==MIGRATION_STATUS_POSTCOPY_ACTIVE ) { +if (migration_in_postcopy ()) {rcu_read_unlock ();return RAM_SAVE_CONTROL_NOT_SUPP ; }@@ -3775,7 +3775,7 @@ static int qemu_rdma_registration_start(QEMUFile *f, void *opaque,CHECK_ERROR_STATE (); -if (migrate_get_current ()->state ==MIGRATION_STATUS_POSTCOPY_ACTIVE ) { +if (migration_in_postcopy ()) {rcu_read_unlock ();return 0 ; }@@ -3810,7 +3810,7 @@ static int qemu_rdma_registration_stop(QEMUFile *f, void *opaque,CHECK_ERROR_STATE (); -if (migrate_get_current ()->state ==MIGRATION_STATUS_POSTCOPY_ACTIVE ) { +if (migration_in_postcopy ()) {rcu_read_unlock ();return 0 ; }Signature · 1 line
2.17.1
--
Dr. David Alan Gilbert / [email protected] / Manchester, UK
Quoted 3 lines · * Wei Yang ([email protected]) wrote:
Use common helper function to check the state.
Signed-off-by Wei Yang <[email protected]>
queued
Quoted 39 lines
--- migration/rdma.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)migration/rdma.c +3
-3@@ -3140,7 +3140,7 @@ static size_t qemu_rdma_save_page(QEMUFile *f, void *opaque,CHECK_ERROR_STATE (); -if (migrate_get_current ()->state ==MIGRATION_STATUS_POSTCOPY_ACTIVE ) { +if (migration_in_postcopy ()) {rcu_read_unlock ();return RAM_SAVE_CONTROL_NOT_SUPP ; }@@ -3775,7 +3775,7 @@ static int qemu_rdma_registration_start(QEMUFile *f, void *opaque,CHECK_ERROR_STATE (); -if (migrate_get_current ()->state ==MIGRATION_STATUS_POSTCOPY_ACTIVE ) { +if (migration_in_postcopy ()) {rcu_read_unlock ();return 0 ; }@@ -3810,7 +3810,7 @@ static int qemu_rdma_registration_stop(QEMUFile *f, void *opaque,CHECK_ERROR_STATE (); -if (migrate_get_current ()->state ==MIGRATION_STATUS_POSTCOPY_ACTIVE ) { +if (migration_in_postcopy ()) {rcu_read_unlock ();return 0 ; }Signature · 1 line
2.17.1
--
Dr. David Alan Gilbert / [email protected] / Manchester, UK