drm/msm: Make DRM_MSM default to 'm'
PATCH 1/1 drm/msm: Make DRM_MSM default to 'm'
Most use cases for DRM_MSM will prefer to build both DRM and MSM_DRM as modules but there are some cases where DRM might be built in for whatever reason and in those situations it is preferable to still keep MSM as a module by default and let the user decide if they _really_ want to build it in.
Additionally select QCOM_COMMAND_DB for ARCH_QCOM targets to make sure it doesn't get missed when we need it for a6xx tarets.
---
drivers/gpu/drm/msm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/msm/Kconfig +2 -1
@@ -14,11 +14,12 @@ config DRM_MSM select SHMEM select TMPFS select QCOM_SCM if ARCH_QCOM + select QCOM_COMMAND_DB if ARCH_QCOM select WANT_DEV_COREDUMP select SND_SOC_HDMI_CODEC if SND_SOC select SYNC_FILE select PM_OPP - default y + default m help DRM/KMS driver for MSM/snapdragon.
Signature · 1 line
2.7.4
Hi Jordan.
Quoted 20 lines · Jordan Crouse
Most use cases for
DRM_MSMwill prefer to build both DRM andMSM_DRMas modules but there are some cases where DRM might be built in for whatever reason and in those situations it is preferable to still keep MSM as a module by default and let the user decide if they _really_ want to build it in.Additionally select
QCOM_COMMAND_DBforARCH_QCOMtargets to make sure it doesn't get missed when we need it for a6xx tarets.Signed-off-by Jordan Crouse <[email protected]>---
drivers/gpu/drm/msm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/msm/Kconfig +0
-0
drivers/gpu/drm/msm/Kconfig config DRM_MSM · line 22
Quoted 10 lines
drivers/gpu/drm/msm/Kconfig +2
-1@@ -14,11 +14,12 @@ config DRM_MSM select SHMEM select TMPFS select QCOM_SCM if ARCH_QCOM + select QCOM_COMMAND_DB if ARCH_QCOM select WANT_DEV_COREDUMP select SND_SOC_HDMI_CODEC if SND_SOC select SYNC_FILE select PM_OPP - default y + default m
As a general comment the right thing would be to drop this default. As it is now the Kconfig says that when DRM is selected then all of the world would then also get DRM_MSM, which only a small part of this world you see any benefit in.
So they now have to de-select MSM.
Kconfig has:
depends on ARCH_QCOM || SOC_IMX5 || (ARM && COMPILE_TEST)
So maybe not all of the world but all QCOM or IMX5 users. Maybe they are all interested in MSM. Otherwise the default should rather be dropped. If there is any good hints then the help text could anyway use some love, and then add the info there.
The other change with QCOM_COMMAND_DB seems on the other hand to make sense but then this is another patch.
Sam
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 31 lines · Sam Ravnborg
Hi Jordan.
Quoted 28 lines · Jordan Crouse
Most use cases for
DRM_MSMwill prefer to build both DRM andMSM_DRMas modules but there are some cases where DRM might be built in for whatever reason and in those situations it is preferable to still keep MSM as a module by default and let the user decide if they _really_ want to build it in.Additionally select
QCOM_COMMAND_DBforARCH_QCOMtargets to make sure it doesn't get missed when we need it for a6xx tarets.Signed-off-by Jordan Crouse <[email protected]>---
drivers/gpu/drm/msm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/msm/Kconfig +1
-0@@ -14,11 +14,12 @@ config DRM_MSM select SHMEM select TMPFS select QCOM_SCM if ARCH_QCOM + select QCOM_COMMAND_DB if ARCH_QCOM select WANT_DEV_COREDUMP select SND_SOC_HDMI_CODEC if SND_SOC select SYNC_FILE select PM_OPP
Quoted 8 lines
drivers/gpu/drm/msm/Kconfig config DRM_MSM · line 22
Quoted 2 lines
drivers/gpu/drm/msm/Kconfig +1
-1- default y + default mAs a general comment the right thing would be to drop this default. As it is now the
Kconfigsays that when DRM is selected then all of the world would then also getDRM_MSM, which only a small part of this world you see any benefit in.
So they now have to de-select MSM.
If the default is dropped, it should probably be accompanied by adding CONFIG_DRM_MSM=m to defconfig's, I think
BR,
-R
Quoted 8 lines
Kconfighas:depends on ARCH_QCOM || SOC_IMX5 || (ARM && COMPILE_TEST)So maybe not all of the world but all QCOM or IMX5 users. Maybe they are all interested in MSM. Otherwise the default should rather be dropped. If there is any good hints then the help text could anyway use some love, and then add the info there.
Quoted 8 lines
The other change with
QCOM_COMMAND_DBseems on the other hand to make sense but then this is another patch.Sam
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno
Quoted 41 lines · Rob Clark
Quoted 31 lines · Sam Ravnborg
Hi Jordan.
Quoted 28 lines · Jordan Crouse
Most use cases for
DRM_MSMwill prefer to build both DRM andMSM_DRMas modules but there are some cases where DRM might be built in for whatever reason and in those situations it is preferable to still keep MSM as a module by default and let the user decide if they _really_ want to build it in.Additionally select
QCOM_COMMAND_DBforARCH_QCOMtargets to make sure it doesn't get missed when we need it for a6xx tarets.Signed-off-by Jordan Crouse <[email protected]>---
drivers/gpu/drm/msm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/msm/Kconfig +1
-0@@ -14,11 +14,12 @@ config DRM_MSM select SHMEM select TMPFS select QCOM_SCM if ARCH_QCOM + select QCOM_COMMAND_DB if ARCH_QCOM select WANT_DEV_COREDUMP select SND_SOC_HDMI_CODEC if SND_SOC select SYNC_FILE select PM_OPPQuoted 8 lines
drivers/gpu/drm/msm/Kconfig config DRM_MSM · line 22
Quoted 2 lines
drivers/gpu/drm/msm/Kconfig +1
-1- default y + default mAs a general comment the right thing would be to drop this default. As it is now the
Kconfigsays that when DRM is selected then all of the world would then also getDRM_MSM, which only a small part of this world you see any benefit in.
So they now have to de-select MSM.
Quoted 2 lines
If the default is dropped, it should probably be accompanied by adding
CONFIG_DRM_MSM=mto defconfig's, I think
In general I prefer to not use a default but this is the only GPU driver for ARCH_QCOM and I think its safe to stay that 99% of ARCH_QCOM users would select this module and those that wouldn't will omit DRM entirely.
I feel it is net negative if we dropped the default but then had to turn around and enable it in every defconfig.
Jordan
Quoted 19 lines
BR,
-RQuoted 16 lines
Kconfighas:depends on ARCH_QCOM || SOC_IMX5 || (ARM && COMPILE_TEST)So maybe not all of the world but all QCOM or IMX5 users. Maybe they are all interested in MSM. Otherwise the default should rather be dropped. If there is any good hints then the help text could anyway use some love, and then add the info there.
The other change with
QCOM_COMMAND_DBseems on the other hand to make sense but then this is another patch.Sam
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
Hi Jordan/Rob.
Quoted 42 lines · Jordan Crouse
Quoted 41 lines · Rob Clark
Quoted 39 lines · Sam Ravnborg
Hi Jordan.
Quoted 20 lines · Jordan Crouse
Most use cases for
DRM_MSMwill prefer to build both DRM andMSM_DRMas modules but there are some cases where DRM might be built in for whatever reason and in those situations it is preferable to still keep MSM as a module by default and let the user decide if they _really_ want to build it in.Additionally select
QCOM_COMMAND_DBforARCH_QCOMtargets to make sure it doesn't get missed when we need it for a6xx tarets.Signed-off-by Jordan Crouse <[email protected]>---
drivers/gpu/drm/msm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/msm/Kconfig +0
-0drivers/gpu/drm/msm/Kconfig config DRM_MSM · line 22
Quoted 10 lines
drivers/gpu/drm/msm/Kconfig +2
-1@@ -14,11 +14,12 @@ config DRM_MSM select SHMEM select TMPFS select QCOM_SCM if ARCH_QCOM + select QCOM_COMMAND_DB if ARCH_QCOM select WANT_DEV_COREDUMP select SND_SOC_HDMI_CODEC if SND_SOC select SYNC_FILE select PM_OPP - default y + default mAs a general comment the right thing would be to drop this default. As it is now the
Kconfigsays that when DRM is selected then all of the world would then also getDRM_MSM, which only a small part of this world you see any benefit in.
So they now have to de-select MSM.
Quoted 2 lines
Quoted 2 lines
If the default is dropped, it should probably be accompanied by adding
CONFIG_DRM_MSM=mto defconfig's, I think
That would be best. So the defconfigs end up with the same config as before.
Quoted 7 lines
In general I prefer to not use a default but this is the only GPU driver for
ARCH_QCOMand I think its safe to stay that 99% ofARCH_QCOMusers would select this module and those that wouldn't will omit DRM entirely.I feel it is net negative if we dropped the default but then had to turn around and enable it in every defconfig.
"in every" equals three defconfigs:
$ git grep ARCH_QCOM | grep defconfig arch/arm/configs/multi_v7_defconfig:CONFIG_ARCH_QCOM=y arch/arm/configs/qcom_defconfig:CONFIG_ARCH_QCOM=y arch/arm64/configs/defconfig:CONFIG_ARCH_QCOM=y
Sam
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno