hmp: Remove migration capabilities from "info migrate"
PATCH v3 1/1 hmp: Remove migration capabilities from "info migrate"
With the growth of migration capabilities, it is not proper to display them in "info migrate". Users are recommended to use "info migrate_capabiltiies" to list them.
---
v3:
* remove un-used variable caps
v2:
* remove capabilities from "info migrate"
--- monitor/hmp-cmds.c | 14 -------------- 1 file changed, 14 deletions(-)
monitor/hmp-cmds.c +0 -14
@@ -220,24 +220,11 @@ static char *SocketAddress_to_str(SocketAddress *addr)void hmp_info_migrate (Monitor *mon,const QDict *qdict) {MigrationInfo *info; -MigrationCapabilityStatusList *caps, *cap; info =qmp_query_migrate (NULL ); - caps =qmp_query_migrate_capabilities (NULL );migration_global_dump (mon); -/* do not display parameters during setup */ -if (info->has_status && caps) { -monitor_printf (mon,"capabilities: " ); -for (cap = caps; cap; cap = cap->next) { -monitor_printf (mon,"%s: %s " , -MigrationCapability_str (cap->value->capability), - cap->value->state ?"on" :"off" ); - } -monitor_printf (mon,"\n" ); - } -if (info->has_status) {monitor_printf (mon,"Migration status: %s" ,MigrationStatus_str (info->status));
@@ -370,7 +357,6 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict)monitor_printf (mon,"]\n" ); }qapi_free_MigrationInfo (info); -qapi_free_MigrationCapabilityStatusList (caps); }void hmp_info_migrate_capabilities (Monitor *mon,const QDict *qdict)
Signature · 1 line
2.17.1
Quoted 6 lines · * Wei Yang ([email protected]) wrote:
With the growth of migration capabilities, it is not proper to display them in "info migrate". Users are recommended to use "info
migrate_capabiltiies" to list them.Signed-off-by Wei Yang <[email protected]>Suggested-by Dr. David Alan Gilbert <[email protected]>
Quoted 50 lines
---
v3:
* remove un-used variable caps
v2:
* remove capabilities from "info migrate"--- monitor/hmp-cmds.c | 14 -------------- 1 file changed, 14 deletions(-)monitor/hmp-cmds.c +0
-14@@ -220,24 +220,11 @@ static char *SocketAddress_to_str(SocketAddress *addr)void hmp_info_migrate (Monitor *mon,const QDict *qdict) {MigrationInfo *info; -MigrationCapabilityStatusList *caps, *cap; info =qmp_query_migrate (NULL ); - caps =qmp_query_migrate_capabilities (NULL );migration_global_dump (mon); -/* do not display parameters during setup */ -if (info->has_status && caps) { -monitor_printf (mon,"capabilities: " ); -for (cap = caps; cap; cap = cap->next) { -monitor_printf (mon,"%s: %s " , -MigrationCapability_str (cap->value->capability), - cap->value->state ?"on" :"off" ); - } -monitor_printf (mon,"\n" ); - } -if (info->has_status) {monitor_printf (mon,"Migration status: %s" ,MigrationStatus_str (info->status));@@ -370,7 +357,6 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict)monitor_printf (mon,"]\n" ); }qapi_free_MigrationInfo (info); -qapi_free_MigrationCapabilityStatusList (caps); }void hmp_info_migrate_capabilities (Monitor *mon,const QDict *qdict)Signature · 1 line
2.17.1
--
Dr. David Alan Gilbert / [email protected] / Manchester, UK
Quoted 6 lines · * Wei Yang ([email protected]) wrote:
With the growth of migration capabilities, it is not proper to display them in "info migrate". Users are recommended to use "info
migrate_capabiltiies" to list them.Signed-off-by Wei Yang <[email protected]>Suggested-by Dr. David Alan Gilbert <[email protected]>
Queued
Quoted 50 lines
---
v3:
* remove un-used variable caps
v2:
* remove capabilities from "info migrate"--- monitor/hmp-cmds.c | 14 -------------- 1 file changed, 14 deletions(-)monitor/hmp-cmds.c +0
-14@@ -220,24 +220,11 @@ static char *SocketAddress_to_str(SocketAddress *addr)void hmp_info_migrate (Monitor *mon,const QDict *qdict) {MigrationInfo *info; -MigrationCapabilityStatusList *caps, *cap; info =qmp_query_migrate (NULL ); - caps =qmp_query_migrate_capabilities (NULL );migration_global_dump (mon); -/* do not display parameters during setup */ -if (info->has_status && caps) { -monitor_printf (mon,"capabilities: " ); -for (cap = caps; cap; cap = cap->next) { -monitor_printf (mon,"%s: %s " , -MigrationCapability_str (cap->value->capability), - cap->value->state ?"on" :"off" ); - } -monitor_printf (mon,"\n" ); - } -if (info->has_status) {monitor_printf (mon,"Migration status: %s" ,MigrationStatus_str (info->status));@@ -370,7 +357,6 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict)monitor_printf (mon,"]\n" ); }qapi_free_MigrationInfo (info); -qapi_free_MigrationCapabilityStatusList (caps); }void hmp_info_migrate_capabilities (Monitor *mon,const QDict *qdict)Signature · 1 line
2.17.1
--
Dr. David Alan Gilbert / [email protected] / Manchester, UK