Skip to contentSkip to conversation

part: always enable part_get_info_ptr() for driver

PATCH New Kever Yang 2 participants 3 messages Jul 25, 2019 – Aug 8, 2019

lore
Share & tools
lore

Kever Yang

author
#0 lore raw

PATCH 1/1 part: always enable part_get_info_ptr() for driver

The partition driver has its Kconfig option, and the part_get_info_prt() interface are mendatory interface for partition drivers, always enable the macro to make partition driver works correctly.

---

 include/part.h | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)
include/part.h +2 -9
index ebca546db5..7d00fae56f 100644
@@ -241,22 +241,15 @@ static inline int blk_get_device_part_str(const char *ifname,
 #endif
 
 /*
- * We don't support printing partition information in SPL and only support
- * getting partition information in a few cases.
+ * We don't support printing partition information in SPL
  */
 #ifdef CONFIG_SPL_BUILD
 # define part_print_ptr(x)	NULL
-# if defined(CONFIG_SPL_FS_EXT4) || defined(CONFIG_SPL_FS_FAT) || \
-	defined(CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION)
-#  define part_get_info_ptr(x)	x
-# else
-#  define part_get_info_ptr(x)	NULL
-# endif
 #else
 #define part_print_ptr(x)	x
-#define part_get_info_ptr(x)	x
 #endif
 
+#define part_get_info_ptr(x)	x
 
 struct part_driver {
 	const char *name;
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 part: always enable part_get_info_ptr() for driver

Quoted 5 lines · Kever Yang

The partition driver has its Kconfig option, and the part_get_info_prt() interface are mendatory interface for partition drivers, always enable the macro to make partition driver works correctly.

This makes some boards such as r8a77995_draak overflow their memory map.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190807/ffb612c4/attachment.sig>
author
#2 lore raw

PATCH 1/1 part: always enable part_get_info_ptr() for driver

Tom,

Quoted 9 lines · Tom Rini
Quoted 5 lines · Kever Yang

The partition driver has its Kconfig option, and the part_get_info_prt() interface are mendatory interface for partition drivers, always enable the macro to make partition driver works correctly.

This makes some boards such as r8a77995_draak overflow their memory map.

Is it overflow in SPL? then these board have very limited space left for SPL.

There use to have a CONFIG_SPL_LIBDISK_SUPPORT to decide if we need partition

driver and now it convert to use CONFIG_PARTITIONS&CONFIG_SPL_FRAMEWORK after:

91ff686562 blk: Rework guard around part_init call

If the board really needs the partition driver, then we must have part_get_info_prt()

to make it work, or else we'd better disable the the partition driver in SPL to remove the no

use code.

Do you think SPL of boards like r8a77995_draak really need partition driver?

Thanks,

- Kever