mfd: ab3100: no need to check return value of debugfs_create functions
Subsystems (2)
PATCH 1/3 mfd: ab3100: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
--- drivers/mfd/ab3100-core.c | 45 ++++++--------------------------------- drivers/mfd/ab3100-otp.c | 21 ++++++------------ 2 files changed, 13 insertions(+), 53 deletions(-)
drivers/mfd/ab3100-core.c +7 -38
@@ -575,58 +575,27 @@ static const struct file_operations ab3100_get_set_reg_fops = { .llseek = noop_llseek, }; -static struct dentry *ab3100_dir; -static struct dentry *ab3100_reg_file;static struct ab3100_get_set_reg_priv ab3100_get_priv; -static struct dentry *ab3100_get_reg_file;static struct ab3100_get_set_reg_priv ab3100_set_priv; -static struct dentry *ab3100_set_reg_file;static void ab3100_setup_debugfs (struct ab3100 *ab3100) { -int err; +struct dentry *ab3100_dir; ab3100_dir =debugfs_create_dir ("ab3100" ,NULL ); -if (!ab3100_dir) - goto exit_no_debugfs; - ab3100_reg_file =debugfs_create_file ("registers" , -S_IRUGO , ab3100_dir, ab3100, - &ab3100_registers_fops); -if (!ab3100_reg_file) { - err = -ENOMEM ; - goto exit_destroy_dir; - } +debugfs_create_file ("registers" ,S_IRUGO , ab3100_dir, ab3100, + &ab3100_registers_fops); ab3100_get_priv.ab3100 = ab3100; ab3100_get_priv.mode = false; - ab3100_get_reg_file =debugfs_create_file ("get_reg" , -S_IWUSR , ab3100_dir, &ab3100_get_priv, - &ab3100_get_set_reg_fops); -if (!ab3100_get_reg_file) { - err = -ENOMEM ; - goto exit_destroy_reg; - } +debugfs_create_file ("get_reg" ,S_IWUSR , ab3100_dir, &ab3100_get_priv, + &ab3100_get_set_reg_fops); ab3100_set_priv.ab3100 = ab3100; ab3100_set_priv.mode = true; - ab3100_set_reg_file =debugfs_create_file ("set_reg" , -S_IWUSR , ab3100_dir, &ab3100_set_priv, - &ab3100_get_set_reg_fops); -if (!ab3100_set_reg_file) { - err = -ENOMEM ; - goto exit_destroy_get_reg; - } -return ; - - exit_destroy_get_reg: -debugfs_remove (ab3100_get_reg_file); - exit_destroy_reg: -debugfs_remove (ab3100_reg_file); - exit_destroy_dir: -debugfs_remove (ab3100_dir); - exit_no_debugfs: -return ; +debugfs_create_file ("set_reg" ,S_IWUSR , ab3100_dir, &ab3100_set_priv, + &ab3100_get_set_reg_fops); }#else static inline void ab3100_setup_debugfs (struct ab3100 *ab3100)
drivers/mfd/ab3100-otp.c +6 -15
@@ -122,17 +122,11 @@ static const struct file_operations ab3100_otp_operations = { .release = single_release, }; -static int __init ab3100_otp_init_debugfs (struct device *dev, -struct ab3100_otp *otp) +static void __init ab3100_otp_init_debugfs (struct device *dev, +struct ab3100_otp *otp) { otp->debugfs =debugfs_create_file ("ab3100_otp" ,S_IFREG |S_IRUGO , -NULL , otp, - &ab3100_otp_operations); -if (!otp->debugfs) { -dev_err (dev,"AB3100 debugfs OTP file registration failed!\n" ); -return -ENOENT ; - } -return 0 ; +NULL , otp, &ab3100_otp_operations); } static void __exit ab3100_otp_exit_debugfs(struct ab3100_otp *otp)
@@ -141,10 +135,9 @@ static void __exit ab3100_otp_exit_debugfs(struct ab3100_otp *otp) }#else /* Compile this out if debugfs not selected */ -static inline int __init ab3100_otp_init_debugfs (struct device *dev, -struct ab3100_otp *otp) +static inline void __init ab3100_otp_init_debugfs (struct device *dev, +struct ab3100_otp *otp) { -return 0 ; } static inline void __exit ab3100_otp_exit_debugfs(struct ab3100_otp *otp)
@@ -211,9 +204,7 @@ static int __init ab3100_otp_probe(struct platform_device *pdev) }/* debugfs entries */ - err =ab3100_otp_init_debugfs (&pdev->dev, otp); -if (err) - goto err; +ab3100_otp_init_debugfs (&pdev->dev, otp);return 0 ;
Signature · 1 line
2.22.0
PATCH 2/3 mfd: ab8500: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
--- drivers/mfd/ab8500-debugfs.c | 324 +++++++++++------------------------ 1 file changed, 98 insertions(+), 226 deletions(-)
drivers/mfd/ab8500-debugfs.c +98 -226
@@ -2644,12 +2644,10 @@ static const struct file_operations ab8500_hwreg_fops = { .owner = THIS_MODULE, }; -static struct dentry *ab8500_dir; -static struct dentry *ab8500_gpadc_dir; -static int ab8500_debug_probe (struct platform_device *plf) { -struct dentry *file; +struct dentry *ab8500_dir; +struct dentry *ab8500_gpadc_dir;struct ab8500 *ab8500;struct resource *res;
@@ -2694,47 +2692,22 @@ static int ab8500_debug_probe(struct platform_device *plf) } ab8500_dir =debugfs_create_dir (AB8500_NAME_STRING ,NULL ); -if (!ab8500_dir) - goto err; ab8500_gpadc_dir =debugfs_create_dir (AB8500_ADC_NAME_STRING , ab8500_dir); -if (!ab8500_gpadc_dir) - goto err; - - file =debugfs_create_file ("all-bank-registers" ,S_IRUGO , ab8500_dir, - &plf->dev, &ab8500_bank_registers_fops); -if (!file) - goto err; - - file =debugfs_create_file ("all-banks" ,S_IRUGO , ab8500_dir, - &plf->dev, &ab8500_all_banks_fops); -if (!file) - goto err; - - file =debugfs_create_file ("register-bank" , - (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_dir, &plf->dev, &ab8500_bank_fops); -if (!file) - goto err; - - file =debugfs_create_file ("register-address" , - (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_dir, &plf->dev, &ab8500_address_fops); -if (!file) - goto err; - - file =debugfs_create_file ("register-value" , - (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_dir, &plf->dev, &ab8500_val_fops); -if (!file) - goto err; - - file =debugfs_create_file ("irq-subscribe" , - (S_IRUGO |S_IWUSR |S_IWGRP ), ab8500_dir, - &plf->dev, &ab8500_subscribe_fops); -if (!file) - goto err; + +debugfs_create_file ("all-bank-registers" ,S_IRUGO , ab8500_dir, + &plf->dev, &ab8500_bank_registers_fops); +debugfs_create_file ("all-banks" ,S_IRUGO , ab8500_dir, + &plf->dev, &ab8500_all_banks_fops); +debugfs_create_file ("register-bank" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_dir, &plf->dev, &ab8500_bank_fops); +debugfs_create_file ("register-address" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_dir, &plf->dev, &ab8500_address_fops); +debugfs_create_file ("register-value" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_dir, &plf->dev, &ab8500_val_fops); +debugfs_create_file ("irq-subscribe" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_dir, &plf->dev, &ab8500_subscribe_fops);if (is_ab8500 (ab8500)) { debug_ranges = ab8500_debug_ranges;
@@ -2750,194 +2723,93 @@ static int ab8500_debug_probe(struct platform_device *plf) num_interrupt_lines =AB8540_NR_IRQS ; } - file =debugfs_create_file ("interrupts" , (S_IRUGO ), ab8500_dir, - &plf->dev, &ab8500_interrupts_fops); -if (!file) - goto err; - - file =debugfs_create_file ("irq-unsubscribe" , - (S_IRUGO |S_IWUSR |S_IWGRP ), ab8500_dir, - &plf->dev, &ab8500_unsubscribe_fops); -if (!file) - goto err; - - file =debugfs_create_file ("hwreg" , (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_dir, &plf->dev, &ab8500_hwreg_fops); -if (!file) - goto err; - - file =debugfs_create_file ("all-modem-registers" , - (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_dir, &plf->dev, &ab8500_modem_fops); -if (!file) - goto err; - - file =debugfs_create_file ("bat_ctrl" , (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_gpadc_dir, &plf->dev, - &ab8500_gpadc_bat_ctrl_fops); -if (!file) - goto err; - - file =debugfs_create_file ("btemp_ball" , (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_gpadc_dir, - &plf->dev, &ab8500_gpadc_btemp_ball_fops); -if (!file) - goto err; - - file =debugfs_create_file ("main_charger_v" , - (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_gpadc_dir, &plf->dev, - &ab8500_gpadc_main_charger_v_fops); -if (!file) - goto err; - - file =debugfs_create_file ("acc_detect1" , - (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_gpadc_dir, &plf->dev, - &ab8500_gpadc_acc_detect1_fops); -if (!file) - goto err; - - file =debugfs_create_file ("acc_detect2" , - (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_gpadc_dir, &plf->dev, - &ab8500_gpadc_acc_detect2_fops); -if (!file) - goto err; - - file =debugfs_create_file ("adc_aux1" , (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_gpadc_dir, &plf->dev, - &ab8500_gpadc_aux1_fops); -if (!file) - goto err; - - file =debugfs_create_file ("adc_aux2" , (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_gpadc_dir, &plf->dev, - &ab8500_gpadc_aux2_fops); -if (!file) - goto err; - - file =debugfs_create_file ("main_bat_v" , (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_gpadc_dir, &plf->dev, - &ab8500_gpadc_main_bat_v_fops); -if (!file) - goto err; - - file =debugfs_create_file ("vbus_v" , (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_gpadc_dir, &plf->dev, - &ab8500_gpadc_vbus_v_fops); -if (!file) - goto err; - - file =debugfs_create_file ("main_charger_c" , - (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_gpadc_dir, &plf->dev, - &ab8500_gpadc_main_charger_c_fops); -if (!file) - goto err; - - file =debugfs_create_file ("usb_charger_c" , - (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_gpadc_dir, - &plf->dev, &ab8500_gpadc_usb_charger_c_fops); -if (!file) - goto err; - - file =debugfs_create_file ("bk_bat_v" , (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_gpadc_dir, &plf->dev, - &ab8500_gpadc_bk_bat_v_fops); -if (!file) - goto err; - - file =debugfs_create_file ("die_temp" , (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_gpadc_dir, &plf->dev, - &ab8500_gpadc_die_temp_fops); -if (!file) - goto err; - - file =debugfs_create_file ("usb_id" , (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_gpadc_dir, &plf->dev, - &ab8500_gpadc_usb_id_fops); -if (!file) - goto err; - +debugfs_create_file ("interrupts" , (S_IRUGO ), ab8500_dir, &plf->dev, + &ab8500_interrupts_fops); +debugfs_create_file ("irq-unsubscribe" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_dir, &plf->dev, &ab8500_unsubscribe_fops); +debugfs_create_file ("hwreg" , (S_IRUGO |S_IWUSR |S_IWGRP ), ab8500_dir, + &plf->dev, &ab8500_hwreg_fops); +debugfs_create_file ("all-modem-registers" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_dir, &plf->dev, &ab8500_modem_fops); +debugfs_create_file ("bat_ctrl" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_gpadc_dir, &plf->dev, + &ab8500_gpadc_bat_ctrl_fops); +debugfs_create_file ("btemp_ball" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_gpadc_dir, &plf->dev, + &ab8500_gpadc_btemp_ball_fops); +debugfs_create_file ("main_charger_v" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_gpadc_dir, &plf->dev, + &ab8500_gpadc_main_charger_v_fops); +debugfs_create_file ("acc_detect1" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_gpadc_dir, &plf->dev, + &ab8500_gpadc_acc_detect1_fops); +debugfs_create_file ("acc_detect2" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_gpadc_dir, &plf->dev, + &ab8500_gpadc_acc_detect2_fops); +debugfs_create_file ("adc_aux1" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_gpadc_dir, &plf->dev, + &ab8500_gpadc_aux1_fops); +debugfs_create_file ("adc_aux2" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_gpadc_dir, &plf->dev, + &ab8500_gpadc_aux2_fops); +debugfs_create_file ("main_bat_v" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_gpadc_dir, &plf->dev, + &ab8500_gpadc_main_bat_v_fops); +debugfs_create_file ("vbus_v" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_gpadc_dir, &plf->dev, + &ab8500_gpadc_vbus_v_fops); +debugfs_create_file ("main_charger_c" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_gpadc_dir, &plf->dev, + &ab8500_gpadc_main_charger_c_fops); +debugfs_create_file ("usb_charger_c" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_gpadc_dir, &plf->dev, + &ab8500_gpadc_usb_charger_c_fops); +debugfs_create_file ("bk_bat_v" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_gpadc_dir, &plf->dev, + &ab8500_gpadc_bk_bat_v_fops); +debugfs_create_file ("die_temp" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_gpadc_dir, &plf->dev, + &ab8500_gpadc_die_temp_fops); +debugfs_create_file ("usb_id" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_gpadc_dir, &plf->dev, + &ab8500_gpadc_usb_id_fops);if (is_ab8540 (ab8500)) { - file =debugfs_create_file ("xtal_temp" , - (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_gpadc_dir, &plf->dev, - &ab8540_gpadc_xtal_temp_fops); -if (!file) - goto err; - file =debugfs_create_file ("vbattruemeas" , - (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_gpadc_dir, &plf->dev, - &ab8540_gpadc_vbat_true_meas_fops); -if (!file) - goto err; - file =debugfs_create_file ("batctrl_and_ibat" , - (S_IRUGO |S_IWUGO ), - ab8500_gpadc_dir, - &plf->dev, - &ab8540_gpadc_bat_ctrl_and_ibat_fops); -if (!file) - goto err; - file =debugfs_create_file ("vbatmeas_and_ibat" , - (S_IRUGO |S_IWUGO ), - ab8500_gpadc_dir, &plf->dev, - &ab8540_gpadc_vbat_meas_and_ibat_fops); -if (!file) - goto err; - file =debugfs_create_file ("vbattruemeas_and_ibat" , - (S_IRUGO |S_IWUGO ), - ab8500_gpadc_dir, - &plf->dev, - &ab8540_gpadc_vbat_true_meas_and_ibat_fops); -if (!file) - goto err; - file =debugfs_create_file ("battemp_and_ibat" , - (S_IRUGO |S_IWUGO ), - ab8500_gpadc_dir, - &plf->dev, &ab8540_gpadc_bat_temp_and_ibat_fops); -if (!file) - goto err; - file =debugfs_create_file ("otp_calib" , - (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_gpadc_dir, - &plf->dev, &ab8540_gpadc_otp_calib_fops); -if (!file) - goto err; +debugfs_create_file ("xtal_temp" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_gpadc_dir, &plf->dev, + &ab8540_gpadc_xtal_temp_fops); +debugfs_create_file ("vbattruemeas" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_gpadc_dir, &plf->dev, + &ab8540_gpadc_vbat_true_meas_fops); +debugfs_create_file ("batctrl_and_ibat" , (S_IRUGO |S_IWUGO ), + ab8500_gpadc_dir, &plf->dev, + &ab8540_gpadc_bat_ctrl_and_ibat_fops); +debugfs_create_file ("vbatmeas_and_ibat" , (S_IRUGO |S_IWUGO ), + ab8500_gpadc_dir, &plf->dev, + &ab8540_gpadc_vbat_meas_and_ibat_fops); +debugfs_create_file ("vbattruemeas_and_ibat" , (S_IRUGO |S_IWUGO ), + ab8500_gpadc_dir, &plf->dev, + &ab8540_gpadc_vbat_true_meas_and_ibat_fops); +debugfs_create_file ("battemp_and_ibat" , (S_IRUGO |S_IWUGO ), + ab8500_gpadc_dir, &plf->dev, + &ab8540_gpadc_bat_temp_and_ibat_fops); +debugfs_create_file ("otp_calib" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_gpadc_dir, &plf->dev, + &ab8540_gpadc_otp_calib_fops); } - file =debugfs_create_file ("avg_sample" , (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_gpadc_dir, &plf->dev, - &ab8500_gpadc_avg_sample_fops); -if (!file) - goto err; - - file =debugfs_create_file ("trig_edge" , (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_gpadc_dir, &plf->dev, - &ab8500_gpadc_trig_edge_fops); -if (!file) - goto err; - - file =debugfs_create_file ("trig_timer" , (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_gpadc_dir, &plf->dev, - &ab8500_gpadc_trig_timer_fops); -if (!file) - goto err; - - file =debugfs_create_file ("conv_type" , (S_IRUGO |S_IWUSR |S_IWGRP ), - ab8500_gpadc_dir, &plf->dev, - &ab8500_gpadc_conv_type_fops); -if (!file) - goto err; +debugfs_create_file ("avg_sample" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_gpadc_dir, &plf->dev, + &ab8500_gpadc_avg_sample_fops); +debugfs_create_file ("trig_edge" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_gpadc_dir, &plf->dev, + &ab8500_gpadc_trig_edge_fops); +debugfs_create_file ("trig_timer" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_gpadc_dir, &plf->dev, + &ab8500_gpadc_trig_timer_fops); +debugfs_create_file ("conv_type" , (S_IRUGO |S_IWUSR |S_IWGRP ), + ab8500_gpadc_dir, &plf->dev, + &ab8500_gpadc_conv_type_fops);return 0 ; - -err: -debugfs_remove_recursive (ab8500_dir); -dev_err (&plf->dev,"failed to create debugfs entries.\n" ); - -return -ENOMEM ; }static struct platform_driver ab8500_debug_driver = {
Signature · 1 line
2.22.0
Re: [PATCH 2/3] mfd: ab8500: no need to check return value of debugfs_create functions
Quoted 8 lines · Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc Linus Walleij <[email protected]>Cc Lee Jones <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
Yours,
Linus Walleij
Lee Jones
AppliedRe: [PATCH 2/3] mfd: ab8500: no need to check return value of debugfs_create functions
In reply to Greg Kroah-HartmanQuoted 11 lines · Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc Linus Walleij <[email protected]>Cc Lee Jones <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>--- drivers/mfd/ab8500-debugfs.c | 324 +++++++++++------------------------ 1 file changed, 98 insertions(+), 226 deletions(-)
Applied, thanks.
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH 3/3 mfd: aat2870: no need to check return value of debugfs_create functions
In reply to Greg Kroah-HartmanWhen calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
--- drivers/mfd/aat2870-core.c | 13 ++----------- include/linux/mfd/aat2870.h | 1 - 2 files changed, 2 insertions(+), 12 deletions(-)
drivers/mfd/aat2870-core.c +2 -11
@@ -334,18 +334,9 @@ static const struct file_operations aat2870_reg_fops = {static void aat2870_init_debugfs (struct aat2870_data *aat2870) { aat2870->dentry_root =debugfs_create_dir ("aat2870" ,NULL ); -if (!aat2870->dentry_root) { -dev_warn (aat2870->dev, -"Failed to create debugfs root directory\n" ); -return ; - } - aat2870->dentry_reg =debugfs_create_file ("regs" ,0644 , - aat2870->dentry_root, - aat2870, &aat2870_reg_fops); -if (!aat2870->dentry_reg) -dev_warn (aat2870->dev, -"Failed to create debugfs register file\n" ); +debugfs_create_file ("regs" ,0644 , aat2870->dentry_root, aat2870, + &aat2870_reg_fops); }#else
include/linux/mfd/aat2870.h +0 -1
@@ -149,7 +149,6 @@ struct aat2870_data {/* for debugfs */ struct dentry *dentry_root; -struct dentry *dentry_reg; };struct aat2870_subdev_info {
Signature · 1 line
2.22.0
Lee Jones
AppliedRe: [PATCH 3/3] mfd: aat2870: no need to check return value of debugfs_create functions
Quoted 10 lines · Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc Lee Jones <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>--- drivers/mfd/aat2870-core.c | 13 ++----------- include/linux/mfd/aat2870.h | 1 - 2 files changed, 2 insertions(+), 12 deletions(-)
Applied, thanks.
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Quoted 8 lines · Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc Linus Walleij <[email protected]>Cc Lee Jones <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
Yours,
Linus Walleij
Lee Jones
AppliedQuoted 4 lines · Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Quoted 8 lines
Cc Linus Walleij <[email protected]>Cc Lee Jones <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>--- drivers/mfd/ab3100-core.c | 45 ++++++--------------------------------- drivers/mfd/ab3100-otp.c | 21 ++++++------------ 2 files changed, 13 insertions(+), 53 deletions(-)
Applied, thanks.
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog