mtd: spi-nor: aspeed-smc: Add of_node_put()
Subsystems (3)
PATCH 1/1 mtd: spi-nor: aspeed-smc: Add of_node_put()
Each iteration of for_each_available_child_of_node puts the previous node, but in the case of a break from the middle of the loop, there is no put, thus causing a memory leak. Upon termination of the loop (whether by break or a natural exit), either ret will have a non-zero value or child will be NULL. Hence add an of_node_put() that will execute only when ret has a non-zero value, as calling of_node_put() on a possible NULL value does not cause any further issues. Issue found with Coccinelle.
--- drivers/mtd/spi-nor/aspeed-smc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/mtd/spi-nor/aspeed-smc.c +3 -1
@@ -836,8 +836,10 @@ static int aspeed_smc_setup_flash(struct aspeed_smc_controller *controller, controller->chips[cs] = chip; } -if (ret) +if (ret) { +of_node_put (child);aspeed_smc_unregister (controller); + }return ret; }
Signature · 1 line
2.19.1
Quoted 10 lines · Nishka Dasgupta
Each iteration of
for_each_available_child_of_nodeputs the previous node, but in the case of a break from the middle of the loop, there is no put, thus causing a memory leak. Upon termination of the loop (whether by break or a natural exit), either ret will have a non-zero value or child will be NULL. Hence add anof_node_put()that will execute only when ret has a non-zero value, as callingof_node_put()on a possible NULL value does not cause any further issues. Issue found with Coccinelle.Signed-off-by Nishka Dasgupta <[email protected]>
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
[email protected]
AppliedQuoted 12 lines · Nishka Dasgupta
External E-Mail
Each iteration of
for_each_available_child_of_nodeputs the previous node, but in the case of a break from the middle of the loop, there is no put, thus causing a memory leak. Upon termination of the loop (whether by break or a natural exit), either ret will have a non-zero value or child will be NULL. Hence add anof_node_put()that will execute only when ret has a non-zero value, as callingof_node_put()on a possible NULL value does not cause any further issues. Issue found with Coccinelle.
Quoted 5 lines
Signed-off-by Nishka Dasgupta <[email protected]>--- drivers/mtd/spi-nor/aspeed-smc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git,
spi-nor/next branch.
Thanks,
ta