pinctrl: stm32: stm32: Add of_node_put() before return
Subsystems (4)
PATCH 1/1 pinctrl: stm32: stm32: Add of_node_put() before return
Each iteration of for_each_child_of_node and for_each_available_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return in two places.
Issue found with Coccinelle.
Signed-off-by Nishka Dasgupta <[email protected]>
--- drivers/pinctrl/stm32/pinctrl-stm32.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/pinctrl/stm32/pinctrl-stm32.c +4 -1
@@ -615,6 +615,7 @@ static int stm32_pctrl_dt_node_to_map(struct pinctrl_dev *pctldev, &reserved_maps, num_maps);if (ret <0 ) {pinctrl_utils_free_map (pctldev, *map, *num_maps); +of_node_put (np);return ret; } }
@@ -1468,8 +1469,10 @@ int stm32_pctl_probe(struct platform_device *pdev)for_each_available_child_of_node (np, child) {if (of_property_read_bool (child,"gpio-controller" )) { ret =stm32_gpiolib_register_bank (pctl, child); -if (ret) +if (ret) { +of_node_put (child);return ret; + } pctl->nbanks++; }
Signature · 1 line
2.19.1
Quoted 8 lines · Nishka Dasgupta
Each iteration of
for_each_child_of_nodeandfor_each_available_child_of_nodeputs the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add anof_node_putbefore the return in two places.
Issue found with Coccinelle.Signed-off-by Nishka Dasgupta <[email protected]>
Patch applied.
Yours,
Linus Walleij