Skip to contentSkip to conversation

sgi-xp: xpc_uv: Make structure xpc_arch_ops_uv constant

PATCH New Nishka Dasgupta 1 participant 1 message Aug 8, 2019 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sgi-xp: xpc_uv: Make structure xpc_arch_ops_uv constant

The static xpc_arch_operations structure xpc_arch_ops_uv is only copied into the structure xpc_arch_ops, after which it is never modified; nor is it used in any other way. Hence it can be declared as a constant to prevent unintended modifications of its fields.
Issue found with Coccinelle.

---
 drivers/misc/sgi-xp/xpc_uv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/sgi-xp/xpc_uv.c +1 -1
index 0c6de97dd347..89c4b04337d3 100644
@@ -1678,7 +1678,7 @@ xpc_received_payload_uv(struct xpc_channel *ch, void *payload)
 		XPC_DEACTIVATE_PARTITION(&xpc_partitions[ch->partid], ret);
 }
 
-static struct xpc_arch_operations xpc_arch_ops_uv = {
+static const struct xpc_arch_operations xpc_arch_ops_uv = {
 	.setup_partitions = xpc_setup_partitions_uv,
 	.teardown_partitions = xpc_teardown_partitions_uv,
 	.process_activate_IRQ_rcvd = xpc_process_activate_IRQ_rcvd_uv,
Signature · 1 line
2.19.1