Skip to contentSkip to conversation

tools: imx8mimage: fix HDMI/FIT parsing

PATCH New Peng Fan 3 participants 4 messages Aug 6, 2019 – Aug 13, 2019 Arm i.MX and Layerscape

lore
Share & tools
lore

Peng Fan

author
#0 lore raw

PATCH 1/1 tools: imx8mimage: fix HDMI/FIT parsing

Add missed break for HDMI entry.
And moving FIT parsing earlier, because it does not have parameter, it will not runs into CFG_REG_SIZE.

---
 tools/imx8mimage.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
tools/imx8mimage.c +5 -2
index 50a256cbac..6c02337698 100644
@@ -99,8 +99,6 @@ static void parse_cfg_cmd(int32_t cmd, char *token, char *name, int lineno)
 		break;
 	case CMD_SIGNED_HDMI:
 		signed_hdmi = token;
-	case CMD_FIT:
-		using_fit = 1;
 		break;
 	case CMD_DDR_FW:
 		/* Do nothing */
@@ -120,6 +118,11 @@ static void parse_cfg_fld(int32_t *cmd, char *token,
 				name, lineno, token);
 			exit(EXIT_FAILURE);
 		}
+		switch (*cmd) {
+		case CMD_FIT:
+			using_fit = 1;
+			break;
+		}
 		break;
 	case CFG_REG_SIZE:
 		parse_cfg_cmd(*cmd, token, name, lineno);
Signature · 1 line
2.16.4
#1 lore raw

PATCH 1/1 tools: imx8mimage: fix HDMI/FIT parsing

Quoted 25 lines

Add missed break for HDMI entry.
And moving FIT parsing earlier, because it does not have parameter, it will not runs into CFG_REG_SIZE.

---
 tools/imx8mimage.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
tools/imx8mimage.c +0 -2
index 50a256cbac..6c02337698 100644
@@ -99,8 +99,6 @@ static void parse_cfg_cmd(int32_t cmd, char *token, char *name, int lineno)
 		break;
 	case CMD_SIGNED_HDMI:
 		signed_hdmi = token;
-	case CMD_FIT:
-		using_fit = 1;
 		break;
 	case CMD_DDR_FW:
 		/* Do nothing */
@@ -120,6 +118,11 @@ static void parse_cfg_fld(int32_t *cmd, char *token,
 				name, lineno, token);

tools/imx8mimage.c static void parse_cfg_fld(int32_t *cmd, char *token, · line 128

Quoted 10 lines
tools/imx8mimage.c +5 -0
 			exit(EXIT_FAILURE);
 		}
+		switch (*cmd) {
+		case CMD_FIT:
+			using_fit = 1;
+			break;
+		}
 		break;
 	case CFG_REG_SIZE:
 		parse_cfg_cmd(*cmd, token, name, lineno);

Best regards,
Ye Li

#2 lore raw

PATCH 1/1 tools: imx8mimage: fix HDMI/FIT parsing

In reply to Peng Fan
Quoted 24 lines · On Tue, 6 Aug 2019 10:07:26 +0000 Peng Fan <[email protected]> wrote:

Add missed break for HDMI entry.
And moving FIT parsing earlier, because it does not have parameter, it will not runs into CFG_REG_SIZE.

---
 tools/imx8mimage.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
tools/imx8mimage.c +0 -2
index 50a256cbac..6c02337698 100644
@@ -99,8 +99,6 @@ static void parse_cfg_cmd(int32_t cmd, char *token,
 char *name, int lineno) break;
 	case CMD_SIGNED_HDMI:
 		signed_hdmi = token;
-	case CMD_FIT:
-		using_fit = 1;
 		break;
 	case CMD_DDR_FW:
 		/* Do nothing */
@@ -120,6 +118,11 @@ static void parse_cfg_fld(int32_t *cmd, char
 *token, name, lineno, token);

tools/imx8mimage.c static void parse_cfg_fld(int32_t *cmd, char · line 128

Quoted 10 lines
tools/imx8mimage.c +5 -0
 			exit(EXIT_FAILURE);
 		}
+		switch (*cmd) {
+		case CMD_FIT:
+			using_fit = 1;
+			break;
+		}
 		break;
 	case CFG_REG_SIZE:
 		parse_cfg_cmd(*cmd, token, name, lineno);

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190808/bb930389/attachment.sig>