Skip to contentSkip to conversation

staging: m57621-mmc: delete driver from the tree.

PATCH New Jan Kiszka 4 participants 7 messages Aug 8, 2019 – Aug 15, 2019

Subsystems (2)
lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

PATCH 1/1 staging: m57621-mmc: delete driver from the tree.

From: Greg Kroah-Hartman <[email protected]>

The license text in this driver is "interesting" and not really obvious that it is supposed to be able to be distributed in the kernel source tree. Yes, the MODULE_LICENSE() text says GPL, so it's probably ok, but to be safe, I am deleting this driver. I will be glad to add it back if the license is properly sorted out, but for now, this isn't worth the potential risk, I should have never taken it in the first place.

Upstream commit 441bf7332d55c4d34afae9ffc3bbec621093f4d1

Cc Matthias Brugger <[email protected]>
Cc NeilBrown <[email protected]>
Cc George Hilliard <[email protected]>
Cc "Christian L?tke-Stetzkamp" <[email protected]>
Cc Nishad Kamdar <[email protected]>
Cc Sergej Perschin <[email protected]>
Cc John Crispin <[email protected]>
[Jan: backport to 4.19]

---

Found to be "interesting" also by our license analysis. I think it's best to purge it in CIP as well. Staging is out of scope for us anyway.

 drivers/staging/Kconfig                |    2 -
 drivers/staging/Makefile               |    1 -
 drivers/staging/mt7621-mmc/Kconfig     |   16 -
 drivers/staging/mt7621-mmc/Makefile    |   42 -
 drivers/staging/mt7621-mmc/TODO        |    8 -
 drivers/staging/mt7621-mmc/board.h     |   63 -
 drivers/staging/mt7621-mmc/dbg.c       |  307 ----
 drivers/staging/mt7621-mmc/dbg.h       |  149 --
 drivers/staging/mt7621-mmc/mt6575_sd.h |  488 -------
 drivers/staging/mt7621-mmc/sd.c        | 2392 --------------------------------
 10 files changed, 3468 deletions(-)
 delete mode 100644 drivers/staging/mt7621-mmc/Kconfig
 delete mode 100644 drivers/staging/mt7621-mmc/Makefile
 delete mode 100644 drivers/staging/mt7621-mmc/TODO
 delete mode 100644 drivers/staging/mt7621-mmc/board.h
 delete mode 100644 drivers/staging/mt7621-mmc/dbg.c
 delete mode 100644 drivers/staging/mt7621-mmc/dbg.h
 delete mode 100644 drivers/staging/mt7621-mmc/mt6575_sd.h
 delete mode 100644 drivers/staging/mt7621-mmc/sd.c
drivers/staging/Kconfig +0 -2
index 1abf76be2aa8..58e8140c1f57 100644
@@ -114,8 +114,6 @@ source "drivers/staging/mt7621-spi/Kconfig"
 
 source "drivers/staging/mt7621-dma/Kconfig"
 
-source "drivers/staging/mt7621-mmc/Kconfig"
-
 source "drivers/staging/mt7621-eth/Kconfig"
 
 source "drivers/staging/mt7621-dts/Kconfig"
drivers/staging/Makefile +0 -1
index ab0cbe8815b1..6f3065569fa0 100644
@@ -47,7 +47,6 @@ obj-$(CONFIG_SOC_MT7621)	+= mt7621-pci/
 obj-$(CONFIG_SOC_MT7621)	+= mt7621-pinctrl/
 obj-$(CONFIG_SOC_MT7621)	+= mt7621-spi/
 obj-$(CONFIG_SOC_MT7621)	+= mt7621-dma/
-obj-$(CONFIG_SOC_MT7621)	+= mt7621-mmc/
 obj-$(CONFIG_SOC_MT7621)	+= mt7621-eth/
 obj-$(CONFIG_SOC_MT7621)	+= mt7621-dts/
 obj-$(CONFIG_STAGING_GASKET_FRAMEWORK)	+= gasket/
drivers/staging/mt7621-mmc/Kconfig deleted +0 -16
deleted file mode 100644
index c6dfe8c637dc..000000000000
@@ -1,16 +0,0 @@
-config MTK_MMC
-	tristate "MTK SD/MMC"
-	depends on !MTD_NAND_RALINK && MMC
-
-config MTK_AEE_KDUMP
-	bool "MTK AEE KDUMP"
-	depends on MTK_MMC
-
-config MTK_MMC_CD_POLL
-	bool "Card Detect with Polling"
-	depends on MTK_MMC
-
-config MTK_MMC_EMMC_8BIT
-	bool "eMMC 8-bit support"
-	depends on MTK_MMC && RALINK_MT7628
-
drivers/staging/mt7621-mmc/Makefile deleted +0 -42

42 lines not on this page · raw message

drivers/staging/mt7621-mmc/TODO deleted +0 -8
deleted file mode 100644
index febb32d37e07..000000000000
@@ -1,8 +0,0 @@
-
-- general code review and clean up
-- ensure device-tree requirements are documented
-- should probably be merged with drivers/mmc/host/mtk-sd.c
-- possibly fix to work with highmem pages so a bounce buffer isn't
-  needed.
-
-Cc: NeilBrown <[email protected]>
drivers/staging/mt7621-mmc/board.h deleted +0 -63

63 lines not on this page · raw message

drivers/staging/mt7621-mmc/dbg.c deleted +0 -307

307 lines not on this page · raw message

drivers/staging/mt7621-mmc/dbg.h deleted +0 -149

149 lines not on this page · raw message

drivers/staging/mt7621-mmc/mt6575_sd.h deleted +0 -488

488 lines not on this page · raw message

drivers/staging/mt7621-mmc/sd.c deleted +0 -2392

1,912 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.16.4

Part of the diff is not shown here. View the raw message.

#1 lore raw

PATCH 1/1 staging: m57621-mmc: delete driver from the tree.

Hi!

Quoted 10 lines

From: Greg Kroah-Hartman <[email protected]>

The license text in this driver is "interesting" and not really obvious that it is supposed to be able to be distributed in the kernel source tree. Yes, the MODULE_LICENSE() text says GPL, so it's probably ok, but to be safe, I am deleting this driver. I will be glad to add it back if the license is properly sorted out, but for now, this isn't worth the potential risk, I should have never taken it in the first place.

Quoted 3 lines

Found to be "interesting" also by our license analysis. I think it's best to purge it in CIP as well. Staging is out of scope for us anyway.

Greetings to your lawyers ;-). The code is clearly derived work of kernel, so it has to be GPL, if Mediatek wants it or not.

drivers/staging/mt7621-mmc/sd.c line 2392

Quoted 5 lines
drivers/staging/mt7621-mmc/sd.c deleted +0 -5
-module_init(mt_msdc_init);
-module_exit(mt_msdc_exit);
-MODULE_LICENSE("GPL");
-MODULE_DESCRIPTION("MediaTek MT6575 SD/MMC Card Driver");
-MODULE_AUTHOR("Infinity Chen <[email protected]>");

And Mediatek says so here.

Now, nobody is using that one, so removing it does little damage.

On the other hand.... nobody is using that one. You are unlikely to build it into your product. And yes, I can apply the patch; I'd prefer to get it from -stable... But that will not solve the problem.

_We will be still distributing that driver_, even if I remove it. git will just mark it as removed, it will still be in repository. (Granted, it will help with generated tarballs).

Best regards,
Pavel

Signature · 9 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.cip-project.org/pipermail/cip-dev/attachments/20190808/7e50ea3f/attachment.sig>
author
#2 lore raw

PATCH 1/1 staging: m57621-mmc: delete driver from the tree.

Quoted 33 lines · Pavel Machek

Hi!

Quoted 10 lines

From: Greg Kroah-Hartman <[email protected]>

The license text in this driver is "interesting" and not really obvious that it is supposed to be able to be distributed in the kernel source tree. Yes, the MODULE_LICENSE() text says GPL, so it's probably ok, but to be safe, I am deleting this driver. I will be glad to add it back if the license is properly sorted out, but for now, this isn't worth the potential risk, I should have never taken it in the first place.

Quoted 3 lines

Found to be "interesting" also by our license analysis. I think it's best to purge it in CIP as well. Staging is out of scope for us anyway.

Greetings to your lawyers ;-). The code is clearly derived work of kernel, so it has to be GPL, if Mediatek wants it or not.

drivers/staging/mt7621-mmc/sd.c line 2392

Quoted 5 lines
drivers/staging/mt7621-mmc/sd.c deleted +0 -5
-module_init(mt_msdc_init);
-module_exit(mt_msdc_exit);
-MODULE_LICENSE("GPL");
-MODULE_DESCRIPTION("MediaTek MT6575 SD/MMC Card Driver");
-MODULE_AUTHOR("Infinity Chen <[email protected]>");

And Mediatek says so here.

Now, nobody is using that one, so removing it does little damage.

On the other hand.... nobody is using that one. You are unlikely to build it into your product. And yes, I can apply the patch; I'd prefer to get it from -stable... But that will not solve the problem.

Quoted 7 lines

_We will be still distributing that driver_, even if I remove it. git will just mark it as removed, it will still be in repository. (Granted, it will help with generated tarballs).

Best regards,
Pavel

Let's not discuss this if there is a real issue or not. Fact is that the programmatic declaration is not in sync with the verbal one, and that was enough to remove the code from *upstream*. Yes, it will remain in git forever, but not in snapshots that may be part of source packages.

So please merge.

Jan

Signature · 2 lines
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
author
#3 lore raw

PATCH 1/1 staging: m57621-mmc: delete driver from the tree.

Quoted 42 lines · [ext] Jan Kiszka
Quoted 33 lines · Pavel Machek

Hi!

Quoted 10 lines

From: Greg Kroah-Hartman <[email protected]>

The license text in this driver is "interesting" and not really obvious that it is supposed to be able to be distributed in the kernel source tree. Yes, the MODULE_LICENSE() text says GPL, so it's probably ok, but to be safe, I am deleting this driver. I will be glad to add it back if the license is properly sorted out, but for now, this isn't worth the potential risk, I should have never taken it in the first place.

Quoted 3 lines

Found to be "interesting" also by our license analysis. I think it's best to purge it in CIP as well. Staging is out of scope for us anyway.

Greetings to your lawyers ;-). The code is clearly derived work of kernel, so it has to be GPL, if Mediatek wants it or not.

drivers/staging/mt7621-mmc/sd.c line 2392

Quoted 5 lines
drivers/staging/mt7621-mmc/sd.c deleted +0 -5
-module_init(mt_msdc_init);
-module_exit(mt_msdc_exit);
-MODULE_LICENSE("GPL");
-MODULE_DESCRIPTION("MediaTek MT6575 SD/MMC Card Driver");
-MODULE_AUTHOR("Infinity Chen <[email protected]>");

And Mediatek says so here.

Now, nobody is using that one, so removing it does little damage.

On the other hand.... nobody is using that one. You are unlikely to build it into your product. And yes, I can apply the patch; I'd prefer to get it from -stable... But that will not solve the problem.

Quoted 7 lines

_We will be still distributing that driver_, even if I remove it. git will just mark it as removed, it will still be in repository. (Granted, it will help with generated tarballs).

Best regards,
Pavel

Quoted 7 lines

Let's not discuss this if there is a real issue or not. Fact is that the programmatic declaration is not in sync with the verbal one, and that was enough to remove the code from *upstream*. Yes, it will remain in git forever, but not in snapshots that may be part of source packages.

So please merge.

BTW, we've backported the firmware removal changes for similar reasons.

Jan

Signature · 2 lines
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
#4 lore raw

PATCH 1/1 staging: m57621-mmc: delete driver from the tree.

Quoted 2 lines

The license text in this driver is "interesting" and not really obvious that it is supposed to be able to be distributed in the kernel source tree.

Evaluation clearing process by CIp Consortium (Legal Implications)???

Well... ;-)

Zoran
_______

Quoted 63 lines · Jan Kiszka
Quoted 42 lines · [ext] Jan Kiszka
Quoted 33 lines · Pavel Machek

Hi!

Quoted 10 lines

From: Greg Kroah-Hartman <[email protected]>

The license text in this driver is "interesting" and not really obvious that it is supposed to be able to be distributed in the kernel source tree. Yes, the MODULE_LICENSE() text says GPL, so it's probably ok, but to be safe, I am deleting this driver. I will be glad to add it back if the license is properly sorted out, but for now, this isn't worth the potential risk, I should have never taken it in the first place.

Quoted 3 lines

Found to be "interesting" also by our license analysis. I think it's best to purge it in CIP as well. Staging is out of scope for us anyway.

Greetings to your lawyers ;-). The code is clearly derived work of kernel, so it has to be GPL, if Mediatek wants it or not.

drivers/staging/mt7621-mmc/sd.c line 2392

Quoted 5 lines
drivers/staging/mt7621-mmc/sd.c deleted +0 -5
-module_init(mt_msdc_init);
-module_exit(mt_msdc_exit);
-MODULE_LICENSE("GPL");
-MODULE_DESCRIPTION("MediaTek MT6575 SD/MMC Card Driver");
-MODULE_AUTHOR("Infinity Chen <[email protected]>");

And Mediatek says so here.

Now, nobody is using that one, so removing it does little damage.

On the other hand.... nobody is using that one. You are unlikely to build it into your product. And yes, I can apply the patch; I'd prefer to get it from -stable... But that will not solve the problem.

Quoted 7 lines

_We will be still distributing that driver_, even if I remove it. git will just mark it as removed, it will still be in repository. (Granted, it will help with generated tarballs).

Best regards,
Pavel

Quoted 7 lines

Let's not discuss this if there is a real issue or not. Fact is that the programmatic declaration is not in sync with the verbal one, and that was enough to remove the code from *upstream*. Yes, it will remain in git forever, but not in snapshots that may be part of source packages.

So please merge.

BTW, we've backported the firmware removal changes for similar reasons.

Jan

--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux
_______________________________________________
cip-dev mailing list
cip-dev at lists.cip-project.org
https://lists.cip-project.org/mailman/listinfo/cip-dev

#5 lore raw

PATCH 1/1 staging: m57621-mmc: delete driver from the tree.

In reply to Pavel Machek
Quoted 14 lines · Pavel Machek

Hi!

Quoted 11 lines

From: Greg Kroah-Hartman <[email protected]>

The license text in this driver is "interesting" and not really obvious that it is supposed to be able to be distributed in the kernel source tree. Yes, the MODULE_LICENSE() text says GPL, so it's probably ok, but to be safe, I am deleting this driver. I will be glad to add it back if the license is properly sorted out, but for now, this isn't worth the potential risk, I should have never taken it in the first place. Found to be "interesting" also by our license analysis. I think it's best to purge it in CIP as well. Staging is out of scope for us anyway.

Quoted 2 lines

Greetings to your lawyers ;-). The code is clearly derived work of kernel, so it has to be GPL, if Mediatek wants it or not.

This might seem clear to you, but at least for source code I think it's less clear. Also, if the copyright holder is required to license it under GPL to comply with the kernel's copyright license, that still doesn't (so far as I know) happen automatically, at least not in the jurisdictions where the GPL has been tested so far.

[...]

Quoted 7 lines

On the other hand.... nobody is using that one. You are unlikely to build it into your product. And yes, I can apply the patch; I'd prefer to get it from -stable... But that will not solve the problem.

_We will be still distributing that driver_, even if I remove it. git will just mark it as removed, it will still be in repository. (Granted, it will help with generated tarballs).

Yes, it is not great to have such things in the history. We have a similar issue with firmware extracted from C sources labelled as "GPL" but without real source for the firmware.

But the law doesn't usually deal in absolutes, and taking this step can reduce the (probably already small) legal risk. It should completely remove the future risk for downstream distributors that provide source snapshots, or that were previously distributing this driver in binary form.

Ben.

Signature · 3 lines
Ben Hutchings, Software Developer                         Codethink Ltd
https://www.codethink.co.uk/                 Dale House, 35 Dale Street
                                     Manchester, M1 2HF, United Kingdom
#6 lore raw

PATCH 1/1 staging: m57621-mmc: delete driver from the tree.

In reply to Jan Kiszka

Hi!

Quoted 8 lines

From: Greg Kroah-Hartman <[email protected]>

The license text in this driver is "interesting" and not really obvious that it is supposed to be able to be distributed in the kernel source tree. Yes, the MODULE_LICENSE() text says GPL, so it's probably ok, but to be safe, I am deleting this driver. I will be glad to add it back if the license is properly sorted out, but for now, this isn't worth the potential risk, I should have never taken it in the first place.

Thanks for a patch, applied to 4.19-cip. It will appear in 4.19-cip-rt during the next update.

If you want to see it in -cip-rt sooner, let me know.

Best regards,
Pavel

Signature · 9 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.cip-project.org/pipermail/cip-dev/attachments/20190815/a0e31af3/attachment.sig>