build: Move -Werror-implicit-function-declaration from make to build.sh
PATCH v3 4/4 build: Move -Werror-implicit-function-declaration from make to build.sh
Previously it was passed only to Android build. Generally Werror flags should be on for development but disabled for releases and production. We don't have any configure flag stating development build, so using it in build.sh should be sufficient as it can be used in both Travis CI builds and local development.
+ respect CC variable in build.sh (for these lazy to pass it via -c flag)
---
Change v2->v3:
* move flag to build.sh, so it can be reused for local development
* respect CC
build.sh | 4 +++- include/mk/env_post.mk | 4 ---- 2 files changed, 3 insertions(+), 5 deletions(-)
build.sh +3 -1
@@ -9,6 +9,9 @@ set -e +CFLAGS="${CFLAGS:--Werror-implicit-function-declaration}" +CC="${CC:-gcc}" + DEFAULT_PREFIX="$HOME/ltp-install" DEFAULT_BUILD="native" DEFAULT_TREE="in"
@@ -16,7 +19,6 @@ CONFIGURE_OPTS_IN_TREE="--with-open-posix-testsuite --with-realtime-testsuite" # TODO: open posix testsuite is currently broken in out-tree-build. Enable it once it's fixed. CONFIGURE_OPTS_OUT_TREE="--with-realtime-testsuite" MAKE_OPTS="-j$(getconf _NPROCESSORS_ONLN)" -CC=gcc build_32() {
include/mk/env_post.mk +0 -4
@@ -42,10 +42,6 @@ CPPFLAGS += -D__UCLIBC__ -DUCLINUX endif ifeq ($(ANDROID),1) -# There are many undeclared functions, it's best not to accidentally overlook -# them. -CFLAGS += -Werror-implicit-function-declaration - LDFLAGS += -L$(top_builddir)/lib/android_libpthread LDFLAGS += -L$(top_builddir)/lib/android_librt endif
Signature · 1 line
2.22.0
PATCH v3 4/4 build: Move -Werror-implicit-function-declaration from make to build.sh
Hi!
Quoted 24 lines
Previously it was passed only to Android build. Generally Werror flags should be on for development but disabled for releases and production. We don't have any configure flag stating development build, so using it in
build.shshould be sufficient as it can be used in both Travis CI builds and local development.+ respect CC variable in
build.sh(for these lazy to pass it via -c flag)Suggested-by Cyril Hrubis <[email protected]>Signed-off-by Petr Vorel <[email protected]>---
Changev2->v3:
* move flag tobuild.sh, so it can be reused for local development
* respect CCbuild.sh | 4 +++- include/mk/env_post.mk | 4 ---- 2 files changed, 3 insertions(+), 5 deletions(-)build.sh +0
-0
build.sh line 12
Quoted 4 lines
build.sh +1
-0@@ -9,6 +9,9 @@ set -e +CFLAGS="${CFLAGS:--Werror-implicit-function-declaration}"
Shouldn't this be -Werror=implicit-function-declaration ?
Hmm, looks like both variants actually work, but the gcc manual speaks only about -Werror= one.
Otherwise it looks good, acked.
Signature · 2 lines
Cyril Hrubis [email protected]
PATCH v3 4/4 build: Move -Werror-implicit-function-declaration from make to build.sh
Hi Cyril,
Quoted 3 lines
Quoted 1 line
+CFLAGS="${CFLAGS:--Werror-implicit-function-declaration}"
Shouldn't this be -Werror=implicit-function-declaration ?
Yes, it is. '${CFLAGS:-' part is POSIX shell substitute (${parameter:-[word]} from [1]), the result is '-Werror=implicit-function-declaration' when CFLAGS is empty or not set.
I might change it as
I might change it to more readable form:
DEFAULT_CFLAGS="-Werror-implicit-function-declaration" CFLAGS="${CFLAGS:-$DEFAULT_CFLAGS}"
Quoted 5 lines
Hmm, looks like both variants actually work, but the gcc manual speaks only about -Werror= one.
Otherwise it looks good, acked.
Thx! Although I plan to send some RFC for moving ffsb as a subproject, it has a low priority. So I'll merge this with your ack.
Kind regards,
Petr
[1] http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_02
PATCH v3 4/4 build: Move -Werror-implicit-function-declaration from make to build.sh
Hi!
Quoted 5 lines
Quoted 1 line
Shouldn't this be -Werror=implicit-function-declaration ?
Yes, it is. '${CFLAGS:-' part is POSIX shell substitute (${parameter:-[word]} from [1]), the result is '-Werror=implicit-function-declaration' when CFLAGS is empty or not set.
I might change it as
I meant the = after -Werror vs -.
Signature · 2 lines
Cyril Hrubis [email protected]
PATCH v3 4/4 build: Move -Werror-implicit-function-declaration from make to build.sh
Hi Cyril,
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Shouldn't this be -Werror=implicit-function-declaration ?
Yes, it is. '${CFLAGS:-' part is POSIX shell substitute (${parameter:-[word]} from [1]), the result is '-Werror=implicit-function-declaration' when CFLAGS is empty or not set.
I might change it asI meant the = after -Werror vs -.
Sure (I'm blind today). Changed to more common
-Werror=implicit-function-declaration and merged.
Kind regards,
Petr