Skip to contentSkip to conversation

examples/qos_meter: fix meter color type conversion

PATCH Applied Jasvinder Singh 3 participants 3 messages Aug 9, 2019 – Aug 10, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 examples/qos_meter: fix meter color type conversion

In APP_MODE_SRTCM_COLOR_AWARE mode, sample app compilation fails due to wrong meter color type conversion.

Fixes fc8a10d8527a ("examples/qos_meter: add color policy")

error log-
/qos_meter/main.c:error: conversion to incomplete type (enum rte_meter_color) input_color);

---
 examples/qos_meter/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
examples/qos_meter/main.c +1 -1
index ce1f63dc7..da7afe8be 100644
@@ -156,7 +156,7 @@ app_pkt_handle(struct rte_mbuf *pkt, uint64_t time)
 		&PROFILE,
 		time,
 		pkt_len,
-		(enum rte_meter_color) input_color);
+		(enum rte_color) input_color);
 
 	/* Apply policing and set the output color */
 	action = policer_table[input_color][output_color];
Signature · 1 line
2.21.0
Acked-by on v1 1/1
#1 lore raw
Quoted 39 lines

-----Original Message-----
From: Singh, Jasvinder
Sent: Friday, August 9, 2019 10:37 AM
To: [email protected]
Cc: Dumitrescu, Cristian <[email protected]>; Peng, Yuan <[email protected]>
Subject: [PATCH] examples/qos_meter: fix meter color type conversion

In APP_MODE_SRTCM_COLOR_AWARE mode, sample app compilation fails due to wrong meter color type conversion.

Fixes fc8a10d8527a ("examples/qos_meter: add color policy")

error log-
/qos_meter/main.c:error: conversion to incomplete type (enum rte_meter_color) input_color);

---
 examples/qos_meter/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
examples/qos_meter/main.c +1 -2
index ce1f63dc7..da7afe8be 100644
@@ -156,7 +156,7 @@ app_pkt_handle(struct rte_mbuf *pkt, uint64_t time)
 		&PROFILE,
 		time,
 		pkt_len,
-		(enum rte_meter_color) input_color);
+		(enum rte_color) input_color);
 
 	/* Apply policing and set the output color */
 	action = policer_table[input_color][output_color];
--
Quoted 1 line

2.21.0

#2 lore raw

09/08/2019 13:56, Dumitrescu, Cristian:

Quoted 5 lines

From: Singh, Jasvinder

Quoted 4 lines

In APP_MODE_SRTCM_COLOR_AWARE mode, sample app compilation fails due to wrong meter color type conversion.

Fixes fc8a10d8527a ("examples/qos_meter: add color policy")

This is not the root cause. Replaced with:

Fixes c1656328dbc2 ("meter: replace color definitions")
Quoted 3 lines
Quoted 3 lines

error log-
/qos_meter/main.c:error: conversion to incomplete type (enum rte_meter_color) input_color);

This log should be before "Fixes" line.

Quoted 2 lines
Quoted 2 lines

Reported-by should be before SoB line (chronological order).

Quoted 1 line

Applied