sunxi: video: HDMI: Fix LCD clock divider
Subsystems (2)
PATCH 1/1 sunxi: video: HDMI: Fix LCD clock divider
Currently we may end up with an LCD clock divider that differs from the HDMI PHY clock divider if we can't exactly match the pixel clock. Fix this by using DIV_ROUND_UP to calculate the divider. This works since the PLL is chosen such that the resulting pixel clock is never higher than the requested pixel clock.
--- drivers/video/sunxi/sunxi_dw_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/sunxi/sunxi_dw_hdmi.c +1 -1
@@ -254,7 +254,7 @@ static void sunxi_dw_hdmi_lcdc_init(int mux, const struct display_timing *edid, {struct sunxi_ccm_reg *const ccm = (struct sunxi_ccm_reg *)SUNXI_CCM_BASE ; -int div =clock_get_pll3 () / edid->pixelclock.typ; +int div =DIV_ROUND_UP (clock_get_pll3 (), edid->pixelclock.typ);struct sunxi_lcdc_reg *lcdc;if (mux ==0 ) {
Signature · 1 line
2.22.0
PATCH 1/1 sunxi: video: HDMI: Fix LCD clock divider
Quoted 11 lines · Mark Kettenis
Currently we may end up with an LCD clock divider that differs from the HDMI PHY clock divider if we can't exactly match the pixel clock. Fix this by using
DIV_ROUND_UPto calculate the divider. This works since the PLL is chosen such that the resulting pixel clock is never higher than the requested pixel clock.Fixes 1feed358ed15 ("sunxi: video: HDMI: Fix clock setup")Signed-off-by Mark Kettenis <[email protected]>---
Moved, to Anatolij on pw
PATCH 1/1 sunxi: video: HDMI: Fix LCD clock divider
In reply to Mark KettenisOn Fri, 9 Aug 2019 22:30:26 +0200
Mark Kettenis kettenis at openbsd.org wrote:
...
Quoted 2 lines
--- drivers/video/sunxi/sunxi_dw_hdmi.c | 2 +-
Applied to u-boot-video/master, thanks!
--
Anatolij