Skip to contentSkip to conversation

lightnvm: remove unused variable 'geo'

PATCH In review Anders Roxell 2 participants 2 messages Aug 10, 2019 – Aug 11, 2019 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lightnvm: remove unused variable 'geo'

The variable 'geo' is no longer used.

../drivers/lightnvm/pblk-read.c: In function ‘pblk_submit_read_gc’:
../drivers/lightnvm/pblk-read.c:421:18: warning: unused variable ‘geo’
[-Wunused-variable]

  struct nvm_geo *geo = &dev->geo;
                  ^~~

Rework to remove the unused variable 'geo' and also the unused variable 'dev' that got unused when the 'geo' variable was removed.

Fixes ba6f7da99aaf ("lightnvm: remove set but not used variables 'data_len' and 'rq_len'")
---
 drivers/lightnvm/pblk-read.c | 2 --
 1 file changed, 2 deletions(-)
drivers/lightnvm/pblk-read.c +0 -2
index 0cdc48f9cfbf..8efd14e683dc 100644
@@ -417,8 +417,6 @@ static int read_rq_gc(struct pblk *pblk, struct nvm_rq *rqd,
 
 int pblk_submit_read_gc(struct pblk *pblk, struct pblk_gc_rq *gc_rq)
 {
-	struct nvm_tgt_dev *dev = pblk->dev;
-	struct nvm_geo *geo = &dev->geo;
 	struct nvm_rq rqd;
 	int ret = NVM_IO_OK;
 
Signature · 1 line
2.20.1
maintainer
#1 lore raw
Quoted 10 lines · Anders Roxell

The variable 'geo' is no longer used.

../drivers/lightnvm/pblk-read.c: In function ‘pblk_submit_read_gc’:
../drivers/lightnvm/pblk-read.c:421:18: warning: unused variable ‘geo’
[-Wunused-variable]

   struct nvm_geo *geo = &dev->geo;
                   ^~~

Rework to remove the unused variable 'geo' and also the unused variable 'dev' that got unused when the 'geo' variable was removed.

This was fixed a few days ago:

http://git.kernel.dk/cgit/linux-block/commit/?h=for-5.4/block&id=f0e6f41669d9e07f45b472e4de33d7c233a847bd

Signature · 1 line
Jens Axboe