Skip to contentSkip to conversation

package/nfs-utils: enable IPv6 if libtirpc is selected

PATCH New unixmania at gmail.com 3 participants 6 messages Aug 12, 2019 – Aug 13, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/nfs-utils: enable IPv6 if libtirpc is selected

From: Carlos Santos <[email protected]>

IPv6 support depends on libtirpc, so no not disable it if libtirpc is selected. In practice this always enables IPv6, since nfs-utils needs rpcbind, which in its turn always selects libtirpc.

---
CC: nathan.renniewaldock at gmail.com

---
 package/nfs-utils/nfs-utils.mk | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
package/nfs-utils/nfs-utils.mk +1 -2
index dc20942f71..974f2a5710 100644
@@ -19,7 +19,6 @@ NFS_UTILS_CONF_OPTS = \
 	--disable-nfsv41 \
 	--disable-gss \
 	--disable-uuid \
-	--disable-ipv6 \
 	--without-tcp-wrappers \
 	--with-statedir=/run/nfs \
 	--with-rpcgen=internal
@@ -55,7 +54,7 @@ ifeq ($(BR2_PACKAGE_LIBTIRPC),y)
 NFS_UTILS_CONF_OPTS += --enable-tirpc
 NFS_UTILS_DEPENDENCIES += libtirpc
 else
-NFS_UTILS_CONF_OPTS += --disable-tirpc
+NFS_UTILS_CONF_OPTS += --disable-ipv6 --disable-tirpc
 endif
 
 define NFS_UTILS_INSTALL_FIXUP
Signature · 1 line
2.18.1
#1 lore raw

PATCH 1/1 package/nfs-utils: enable IPv6 if libtirpc is selected

Hello Carlos,

Quoted 3 lines · unixmania at gmail.com

From: Carlos Santos <[email protected]>

IPv6 support depends on libtirpc, so no not disable it if libtirpc is

s/no not/do not/

Quoted 2 lines

selected. In practice this always enables IPv6, since nfs-utils needs rpcbind, which in its turn always selects libtirpc.

Why not simple select it directly?

Regards,
Peter

Quoted 31 lines

---
CC: nathan.renniewaldock at gmail.com

---
 package/nfs-utils/nfs-utils.mk | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
package/nfs-utils/nfs-utils.mk +1 -2
index dc20942f71..974f2a5710 100644
@@ -19,7 +19,6 @@ NFS_UTILS_CONF_OPTS = \
 	--disable-nfsv41 \
 	--disable-gss \
 	--disable-uuid \
-	--disable-ipv6 \
 	--without-tcp-wrappers \
 	--with-statedir=/run/nfs \
 	--with-rpcgen=internal
@@ -55,7 +54,7 @@ ifeq ($(BR2_PACKAGE_LIBTIRPC),y)
 NFS_UTILS_CONF_OPTS += --enable-tirpc
 NFS_UTILS_DEPENDENCIES += libtirpc
 else
-NFS_UTILS_CONF_OPTS += --disable-tirpc
+NFS_UTILS_CONF_OPTS += --disable-ipv6 --disable-tirpc
 endif
 
 define NFS_UTILS_INSTALL_FIXUP
#2 lore raw

PATCH 1/1 package/nfs-utils: enable IPv6 if libtirpc is selected

Quoted 10 lines · Peter Seiderer

Hello Carlos,

Quoted 3 lines · unixmania at gmail.com

From: Carlos Santos <[email protected]>

IPv6 support depends on libtirpc, so no not disable it if libtirpc is

s/no not/do not/

Ops! I will fix it.

Quoted 4 lines
Quoted 2 lines

selected. In practice this always enables IPv6, since nfs-utils needs rpcbind, which in its turn always selects libtirpc.

Why not simple select it directly?

I was following Arnout's suggested in

https://bugs.busybox.net/show_bug.cgi?id=10806#c1

But I agree that selecting directly is a simpler and better approach.

Signature · 1 line
Carlos Santos <[email protected]>
#3 lore raw

PATCH 1/1 package/nfs-utils: enable IPv6 if libtirpc is selected

In reply to Peter Seiderer

Hello,

Quoted 4 lines · On Mon, 12 Aug 2019 18:14:50 +0200 Peter Seiderer <[email protected]> wrote:
Quoted 2 lines · unixmania at gmail.com

From: Carlos Santos <[email protected]>

Quoted 8 lines
Quoted 1 line

IPv6 support depends on libtirpc, so no not disable it if libtirpc is

s/no not/do not/

Quoted 2 lines

selected. In practice this always enables IPv6, since nfs-utils needs rpcbind, which in its turn always selects libtirpc.

Why not simple select it directly?

Because it is an optional dependency and as such is not strictly required, so we don't typically force such optional dependencies in Buildroot.

I found the v1 from Carlos to be more appropriate than his v2. If you want RPC/IPv6 support, then you must enable libtirpc, and nfs-utils.mk properly uses libtirpc if available.

Arnout, what do you think ?

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/1 package/nfs-utils: enable IPv6 if libtirpc is selected

Quoted 19 lines · Thomas Petazzoni

Hello,

Quoted 4 lines · On Mon, 12 Aug 2019 18:14:50 +0200 Peter Seiderer <[email protected]> wrote:
Quoted 2 lines · unixmania at gmail.com

From: Carlos Santos <[email protected]>

Quoted 8 lines
Quoted 1 line

IPv6 support depends on libtirpc, so no not disable it if libtirpc is

s/no not/do not/

Quoted 2 lines

selected. In practice this always enables IPv6, since nfs-utils needs rpcbind, which in its turn always selects libtirpc.

Why not simple select it directly?

Quoted 8 lines

Because it is an optional dependency and as such is not strictly required, so we don't typically force such optional dependencies in Buildroot.
I found the v1 from Carlos to be more appropriate than his v2. If you want RPC/IPv6 support, then you must enable libtirpc, and nfs-utils.mk properly uses libtirpc if available.

Arnout, what do you think ?

It's an optional dependency only if we decide to make ipv6 optional, which goes against the decision taken years go, according to Arnout's comment[1]: "We decided a few years ago to no longer make ipv6 support in packages optional, i.e. always assume it is there." That's why by default autotools packages are configured with --enable-ipv6 (see package/pkg-autotools.mk).

1. https://bugs.busybox.net/show_bug.cgi?id=10806#c1

Signature · 1 line
Carlos Santos <[email protected]>
#5 lore raw

PATCH 1/1 package/nfs-utils: enable IPv6 if libtirpc is selected

Quoted 8 lines · On Mon, 12 Aug 2019 20:47:06 -0300 Carlos Santos <[email protected]> wrote:

It's an optional dependency only if we decide to make ipv6 optional, which goes against the decision taken years go, according to Arnout's comment[1]: "We decided a few years ago to no longer make ipv6 support in packages optional, i.e. always assume it is there." That's why by default autotools packages are configured with --enable-ipv6 (see package/pkg-autotools.mk).

1. https://bugs.busybox.net/show_bug.cgi?id=10806#c1

But then in this case, we should entirely drop the RPC support for uClibc-ng, as it doesn't support IPv6 if I remember correctly, and simply force libtirpc for all packages that need RPC support. This is not just something specific to nfs-utils, we have a number of other packages that use RPC.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com