checkpatch: revert broken NOTIFIER_HEAD check
Subsystems (2)
cover checkpatch: revert broken NOTIFIER_HEAD check
From: John Hubbard <[email protected]>
Hi,
This happens on today's linux-next.
If the commit message of the original patch were just a bit clearer, I might have been able to attempt a fix, instead of a revert, but so far, both the Perl and the English are beyond me. And we can't leave checkpatch broken.
I'll be glad to test out actual fixes, if you like. But here's a crude revert to kick off the discussion anyway. :)
John Hubbard (1):
checkpatch: revert broken NOTIFIER_HEAD check
scripts/checkpatch.pl | 1 - 1 file changed, 1 deletion(-)
Signature · 1 line
2.22.0
PATCH 1/1 checkpatch: revert broken NOTIFIER_HEAD check
From: John Hubbard <[email protected]>
commit 1a47005dd5aa ("checkpatch: add *_NOTIFIER_HEAD as var definition") causes the following warning when run on some patches:
Unescaped left brace in regex is passed through in regex; marked by < --HERE in m/(?:
...
[238 lines of appalling perl output, mercifully not included]
...
)/ at ./scripts/checkpatch.pl line 3889.
This is broken, so revert it until a better solution is found.
definition")
--- scripts/checkpatch.pl | 1 - 1 file changed, 1 deletion(-)
scripts/checkpatch.pl +0 -1
@@ -3891,7 +3891,6 @@ sub process { ^.DEFINE_$Ident\(\Q$name\E\)| ^.DECLARE_$Ident\(\Q$name\E\)| ^.LIST_HEAD\(\Q$name\E\)| - ^.{$Ident}_NOTIFIER_HEAD\(\Q$name\E\)| ^.(?:$Storage\s+)?$Type\s*\(\s*\*\s*\Q$name\E\s*\)\s*\(| \b\Q$name\E(?:\s+$Attribute)*\s*(?:;|=|\[|\() )/x) {
Signature · 1 line
2.22.0
Hi John,
Quoted 14 lines · On Sun, 11 Aug 2019 15:54:43 -0700 [email protected] wrote:
From: John Hubbard <[email protected]>
commit
1a47005dd5aa("checkpatch: add*_NOTIFIER_HEADas var definition") causes the following warning when run on some patches:Unescaped left brace in regex is passed through in regex; marked by < --HERE in m/(?:
...
[238 lines of appalling perl output, mercifully not included]
...
)/ at./scripts/checkpatch.plline 3889.
Quoted 4 lines
This is broken, so revert it until a better solution is found.
Fixes 1a47005dd5aa ("checkpatch: add *_NOTIFIER_HEAD as vardefinition")
Thanks for the report.
I have removed that patch from linux-next today.
Signature · 2 lines
Cheers, Stephen Rothwell