Skip to contentSkip to conversation

package/nfs-utils: enable IPv6

PATCH Superseded unixmania at gmail.com 3 participants 8 messages Aug 12, 2019 – Sep 10, 2019

v2 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/nfs-utils: enable IPv6

From: Carlos Santos <[email protected]>

IPv6 requires libtirpc, so select BR2_PACKAGE_LIBTIRPC inconditionally.

---
CC: nathan.renniewaldock at gmail.com
CC: Peter Seiderer <[email protected]>

---
 package/nfs-utils/Config.in    |  2 +-
 package/nfs-utils/nfs-utils.mk | 11 ++---------
 2 files changed, 3 insertions(+), 10 deletions(-)
package/nfs-utils/Config.in +1 -1
index 04ea4db3ed..cfca034019 100644
@@ -6,7 +6,7 @@ config BR2_PACKAGE_NFS_UTILS
 	bool "nfs-utils"
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libtirpc, rpcbind
 	depends on BR2_USE_MMU # fork()
-	select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC
+	select BR2_PACKAGE_LIBTIRPC # IPv6 requires libtirpc
 	select BR2_PACKAGE_RPCBIND # runtime
 	help
 	  The NFS Linux kernel server.
package/nfs-utils/nfs-utils.mk +2 -9
index dc20942f71..5e2525cdbf 100644
@@ -10,7 +10,7 @@ NFS_UTILS_SITE = https://www.kernel.org/pub/linux/utils/nfs-utils/$(NFS_UTILS_VE
 NFS_UTILS_LICENSE = GPL-2.0+
 NFS_UTILS_LICENSE_FILES = COPYING
 NFS_UTILS_AUTORECONF = YES
-NFS_UTILS_DEPENDENCIES = host-pkgconf
+NFS_UTILS_DEPENDENCIES = host-pkgconf libtirpc
 
 NFS_UTILS_CONF_ENV = knfsd_cv_bsd_signals=no
 
@@ -19,7 +19,7 @@ NFS_UTILS_CONF_OPTS = \
 	--disable-nfsv41 \
 	--disable-gss \
 	--disable-uuid \
-	--disable-ipv6 \
+	--enable-tirpc \
 	--without-tcp-wrappers \
 	--with-statedir=/run/nfs \
 	--with-rpcgen=internal
@@ -51,13 +51,6 @@ else
 NFS_UTILS_CONF_OPTS += --disable-caps
 endif
 
-ifeq ($(BR2_PACKAGE_LIBTIRPC),y)
-NFS_UTILS_CONF_OPTS += --enable-tirpc
-NFS_UTILS_DEPENDENCIES += libtirpc
-else
-NFS_UTILS_CONF_OPTS += --disable-tirpc
-endif
-
 define NFS_UTILS_INSTALL_FIXUP
 	cd $(TARGET_DIR) && rm -f $(NFS_UTILS_TARGETS_)
 	touch $(TARGET_DIR)/etc/exports
Signature · 1 line
2.18.1
#1 lore raw

PATCH v2 1/1 package/nfs-utils: enable IPv6

Hello,

Arnout, Peter added in Cc, see below.

Quoted 7 lines · On Mon, 12 Aug 2019 14:37:12 -0300 unixmania at gmail.com wrote:

From: Carlos Santos <[email protected]>

IPv6 requires libtirpc, so select BR2_PACKAGE_LIBTIRPC inconditionally.

Arnout, Peter, do you have an opinion about this change ?

Basically, this change makes libtirpc mandatory for nfs-utils, because it is necessary to have IPv6 RPC support.

However, libtirpc is always necessary if you want RPC on IPv6, so if we take the decision of making libtirpc mandatory for nfs-utils, we should make it mandatory for all packages that use RPC support, and remove the support for RPC from the toolchain.

My opinion is that we should keep things are they are today: nfs-utils uses libtirpc if it's there, and otherwise uses the toolchain RPC support. If a user wants IPv6 support, he should enable libtirpc.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH v2 1/1 package/nfs-utils: enable IPv6

Quoted 9 lines · Thomas Petazzoni

Hello,

Arnout, Peter added in Cc, see below.

Quoted 2 lines · On Mon, 12 Aug 2019 14:37:12 -0300 unixmania at gmail.com wrote:

From: Carlos Santos <[email protected]>

Quoted 7 lines
Quoted 5 lines

IPv6 requires libtirpc, so select BR2_PACKAGE_LIBTIRPC inconditionally.

Arnout, Peter, do you have an opinion about this change ?

Yes I do :-)

This thread was on my todo list of things I still had to reply to...

Quoted 11 lines

Basically, this change makes libtirpc mandatory for nfs-utils, because it is necessary to have IPv6 RPC support.

However, libtirpc is always necessary if you want RPC on IPv6, so if we take the decision of making libtirpc mandatory for nfs-utils, we should make it mandatory for all packages that use RPC support, and remove the support for RPC from the toolchain.

My opinion is that we should keep things are they are today: nfs-utils uses libtirpc if it's there, and otherwise uses the toolchain RPC support. If a user wants IPv6 support, he should enable libtirpc.

I agree with this analysis.

When we switched to "assume IPv6 support is there", this was about the
toolchain, i.e. we can assume that the libc functions and the kernel have IPv6 support when building packages. It doesn't mean that we will force all packages to be built with IPv6 support. That is still a case-by-case decision based on what the size impact is.

nfs-utils is not that large, but still: with br-arm-full (note that this
toolchain doesn't have native RPC, so libtirpc is built anyway; but native RPC in uClibc doesn't add much to the size anyway):

toolchain (excluding libstdc++): 763KiB
nfs-utils: 395KiB
libtirpc: 104KiB
rpcbind: 55KiB

So I would say that 104/395KiB is borderline of what we want to keep
configurable, but just on the side of keeping it configurable.

In other words, I agree with your analysis that it's better to keep libtirpc
optional.

Regards,
Arnout

#3 lore raw

PATCH v2 1/1 package/nfs-utils: enable IPv6 if libtirpc is selected

From: Carlos Santos <[email protected]>

IPv6 requires libtirpc but we don't want to select BR2_PACKAGE_LIBTIRPC inconditionally because it increases the size of system so enable IPv6 only if libtirpc is already selected.

---
CC: nathan.renniewaldock at gmail.com
CC: Peter Seiderer <[email protected]>
CC: Arnout Vandecappelle <[email protected]>
CC: Thomas Petazzoni <[email protected]> --
Changes v1->v2
- Do not select libtirpc inconditionally

---
 package/nfs-utils/nfs-utils.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/nfs-utils/nfs-utils.mk +3 -3
index dc20942f71..3d5f5412cf 100644
@@ -19,7 +19,6 @@ NFS_UTILS_CONF_OPTS = \
 	--disable-nfsv41 \
 	--disable-gss \
 	--disable-uuid \
-	--disable-ipv6 \
 	--without-tcp-wrappers \
 	--with-statedir=/run/nfs \
 	--with-rpcgen=internal
@@ -51,11 +50,12 @@ else
 NFS_UTILS_CONF_OPTS += --disable-caps
 endif
 
+# IPv6 requires libtirpc
 ifeq ($(BR2_PACKAGE_LIBTIRPC),y)
-NFS_UTILS_CONF_OPTS += --enable-tirpc
+NFS_UTILS_CONF_OPTS += --enable-tirpc --enable-ipv6
 NFS_UTILS_DEPENDENCIES += libtirpc
 else
-NFS_UTILS_CONF_OPTS += --disable-tirpc
+NFS_UTILS_CONF_OPTS += --disable-tirpc --disable-ipv6
 endif
 
 define NFS_UTILS_INSTALL_FIXUP
Signature · 1 line
2.18.1
#4 lore raw

PATCH v2 1/1 package/nfs-utils: enable IPv6 if libtirpc is selected

Quoted 4 lines · unixmania at gmail.com

From: Carlos Santos <[email protected]>

IPv6 requires libtirpc but we don't want to select BR2_PACKAGE_LIBTIRPC inconditionally because it increases the size of system so enable IPv6

unconditionally

Quoted 4 lines

only if libtirpc is already selected.

Quoted 8 lines

---
CC: nathan.renniewaldock at gmail.com
CC: Peter Seiderer <[email protected]>
CC: Arnout Vandecappelle <[email protected]>
CC: Thomas Petazzoni <[email protected]> --
Changes v1->v2

This is v3, actually... v1 did the same as here (but without the
--enable-ipv6), v2 selected LIBTIRPC unconditionally.

Quoted 18 lines

- Do not select libtirpc inconditionally

---
 package/nfs-utils/nfs-utils.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/nfs-utils/nfs-utils.mk +0 -1
index dc20942f71..3d5f5412cf 100644
@@ -19,7 +19,6 @@ NFS_UTILS_CONF_OPTS = \
 	--disable-nfsv41 \
 	--disable-gss \
 	--disable-uuid \
-	--disable-ipv6 \
 	--without-tcp-wrappers \
 	--with-statedir=/run/nfs \
 	--with-rpcgen=internal

package/nfs-utils/nfs-utils.mk else · line 53

Quoted 4 lines
package/nfs-utils/nfs-utils.mk +1 -0
@@ -51,11 +50,12 @@ else
 NFS_UTILS_CONF_OPTS += --disable-caps
 endif
 
+# IPv6 requires libtirpc

Just to be sure: IPv6 really requires libtirpc, so the RPC implementation in
glibc is not enough?

Assuming that this is the case:

Finally, a small nitpick remark: it would be good to update the Config.in help
text with this information. E.g.:

The NFS Linux kernel server.
+
+ For IPv6 support, select the libtirpc package.

Regards,
Arnout

Quoted 11 lines
package/nfs-utils/nfs-utils.mk +2 -2
 ifeq ($(BR2_PACKAGE_LIBTIRPC),y)
-NFS_UTILS_CONF_OPTS += --enable-tirpc
+NFS_UTILS_CONF_OPTS += --enable-tirpc --enable-ipv6
 NFS_UTILS_DEPENDENCIES += libtirpc
 else
-NFS_UTILS_CONF_OPTS += --disable-tirpc
+NFS_UTILS_CONF_OPTS += --disable-tirpc --disable-ipv6
 endif
 
 define NFS_UTILS_INSTALL_FIXUP
#5 lore raw

PATCH v2 1/1 package/nfs-utils: enable IPv6 if libtirpc is selected

Quoted 78 lines · Arnout Vandecappelle
Quoted 4 lines · unixmania at gmail.com

From: Carlos Santos <[email protected]>

IPv6 requires libtirpc but we don't want to select BR2_PACKAGE_LIBTIRPC inconditionally because it increases the size of system so enable IPv6

unconditionally

Quoted 4 lines

only if libtirpc is already selected.

Quoted 8 lines

---
CC: nathan.renniewaldock at gmail.com
CC: Peter Seiderer <[email protected]>
CC: Arnout Vandecappelle <[email protected]>
CC: Thomas Petazzoni <[email protected]> --
Changes v1->v2

This is v3, actually... v1 did the same as here (but without the
--enable-ipv6), v2 selected LIBTIRPC unconditionally.

Quoted 18 lines

- Do not select libtirpc inconditionally

---
 package/nfs-utils/nfs-utils.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/nfs-utils/nfs-utils.mk +0 -1
index dc20942f71..3d5f5412cf 100644
@@ -19,7 +19,6 @@ NFS_UTILS_CONF_OPTS = \
      --disable-nfsv41 \
      --disable-gss \
      --disable-uuid \
-     --disable-ipv6 \
      --without-tcp-wrappers \
      --with-statedir=/run/nfs \
      --with-rpcgen=internal

package/nfs-utils/nfs-utils.mk else · line 53

Quoted 4 lines
package/nfs-utils/nfs-utils.mk +1 -0
@@ -51,11 +50,12 @@ else
 NFS_UTILS_CONF_OPTS += --disable-caps
 endif
 
+# IPv6 requires libtirpc

Just to be sure: IPv6 really requires libtirpc, so the RPC implementation in
glibc is not enough?

Assuming that this is the case:

Finally, a small nitpick remark: it would be good to update the Config.in help
text with this information. E.g.:

The NFS Linux kernel server.

(quoted diff) +2 -0
+
+         For IPv6 support, select the libtirpc package.
 
 
 Regards,
 Arnout
Quoted 10 lines
package/nfs-utils/nfs-utils.mk +2 -2
 ifeq ($(BR2_PACKAGE_LIBTIRPC),y)
-NFS_UTILS_CONF_OPTS += --enable-tirpc
+NFS_UTILS_CONF_OPTS += --enable-tirpc --enable-ipv6
 NFS_UTILS_DEPENDENCIES += libtirpc
 else
-NFS_UTILS_CONF_OPTS += --disable-tirpc
+NFS_UTILS_CONF_OPTS += --disable-tirpc --disable-ipv6
 endif
 
Quoted 2 lines

package/nfs-utils/nfs-utils.mk else · line 61

Quoted 2 lines
package/nfs-utils/nfs-utils.mk +0 -0
 define NFS_UTILS_INSTALL_FIXUP
2019-09-10T07:22:05 configure: error: '--enable-ipv6' requires TIRPC support.

Quite frankly this is a foolish discussion since nfs-utils selects rpcbind which in its turn selects libtirpc. Anyway, your project, your rules...

Signature · 1 line
Carlos Santos <[email protected]>
#6 lore raw

PATCH v2 1/1 package/nfs-utils: enable IPv6 if libtirpc is selected

Quoted 9 lines · On Tue, 10 Sep 2019 07:29:39 -0300 Carlos Santos <[email protected]> wrote:
Quoted 9 lines
Quoted 9 lines

ifeq ($(BR2_PACKAGE_LIBTIRPC),y)

package/nfs-utils/nfs-utils.mk +2 -2
-NFS_UTILS_CONF_OPTS += --enable-tirpc
+NFS_UTILS_CONF_OPTS += --enable-tirpc --enable-ipv6
 NFS_UTILS_DEPENDENCIES += libtirpc
 else
-NFS_UTILS_CONF_OPTS += --disable-tirpc
+NFS_UTILS_CONF_OPTS += --disable-tirpc --disable-ipv6
 endif
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines

define NFS_UTILS_INSTALL_FIXUP

2019-09-10T07:22:05 configure: error: '--enable-ipv6' requires TIRPC support.

How come this happens ? We only pass --enable-ipv6 when TIRPC is available.

Quoted 3 lines

Quite frankly this is a foolish discussion since nfs-utils selects rpcbind which in its turn selects libtirpc. Anyway, your project, your rules...

Ah, but I didn't realize that and you never mentioned it so far I believe. Indeed, it even makes the current libtirpc condition in nfs-utils.mk completely useless.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#7 lore raw

PATCH v2 1/1 package/nfs-utils: enable IPv6 if libtirpc is selected

Quoted 13 lines · Thomas Petazzoni
Quoted 9 lines · On Tue, 10 Sep 2019 07:29:39 -0300 Carlos Santos <[email protected]> wrote:
Quoted 9 lines
Quoted 9 lines

ifeq ($(BR2_PACKAGE_LIBTIRPC),y)

package/nfs-utils/nfs-utils.mk +2 -2
-NFS_UTILS_CONF_OPTS += --enable-tirpc
+NFS_UTILS_CONF_OPTS += --enable-tirpc --enable-ipv6
 NFS_UTILS_DEPENDENCIES += libtirpc
 else
-NFS_UTILS_CONF_OPTS += --disable-tirpc
+NFS_UTILS_CONF_OPTS += --disable-tirpc --disable-ipv6
 endif
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines

define NFS_UTILS_INSTALL_FIXUP

2019-09-10T07:22:05 configure: error: '--enable-ipv6' requires TIRPC support.

How come this happens ? We only pass --enable-ipv6 when TIRPC is available.

I forced it to happen, just to provide the example. :-)

Signature · 1 line
Carlos Santos <[email protected]>