flush percpu vmstats
Subsystems (5)
cover flush percpu vmstats
While working on v2 of the slabs vmstats flushing patch, I've realized the the problem is much more generic and affects all vmstats, not only slabs. So the patch has been converted to set of 2.
v2:
1) added patch 1, patch 2 rebased on top
2) s/for_each_cpu()/for_each_online_cpu() (by Andrew Morton)
Roman Gushchin (2):
mm: memcontrol: flush percpu vmstats before releasing memcg
mm: memcontrol: flush percpu slab vmstats on kmem offlining
mm/memcontrol.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 59 insertions(+)
Signature · 1 line
2.21.0
PATCH 1/2 mm: memcontrol: flush percpu vmstats before releasing memcg
Percpu caching of local vmstats with the conditional propagation by the cgroup tree leads to an accumulation of errors on non-leaf levels.
Let's imagine two nested memory cgroups A and A/B. Say, a process belonging to A/B allocates 100 pagecache pages on the CPU 0. The percpu cache will spill 3 times, so that 32*3=96 pages will be accounted to A/B and A atomic vmstat counters, 4 pages will remain in the percpu cache.
Imagine A/B is nearby memory.max, so that every following allocation triggers a direct reclaim on the local CPU. Say, each such attempt will free 16 pages on a new cpu. That means every percpu cache will have -16 pages, except the first one, which will have 4 - 16 = -12. A/B and A atomic counters will not be touched at all.
Now a user removes A/B. All percpu caches are freed and corresponding vmstat numbers are forgotten. A has 96 pages more than expected.
As memory cgroups are created and destroyed, errors do accumulate. Even 1-2 pages differences can accumulate into large numbers.
To fix this issue let's accumulate and propagate percpu vmstat values before releasing the memory cgroup. At this point these numbers are stable and cannot be changed.
Since on cpu hotplug we do flush percpu vmstats anyway, we can iterate only over online cpus.
--- mm/memcontrol.c | 40 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+)
mm/memcontrol.c +40 -0
@@ -3412,6 +3412,41 @@ static int memcg_online_kmem(struct mem_cgroup *memcg)return 0 ; } +static void memcg_flush_percpu_vmstats (struct mem_cgroup *memcg) +{ +unsigned long stat[MEMCG_NR_STAT ]; +struct mem_cgroup *mi; +int node, cpu, i; + +for (i =0 ; i <MEMCG_NR_STAT ; i++) + stat[i] =0 ; + +for_each_online_cpu (cpu) +for (i =0 ; i <MEMCG_NR_STAT ; i++) + stat[i] +=raw_cpu_read (memcg->vmstats_percpu->stat[i]); + +for (mi = memcg; mi; mi =parent_mem_cgroup (mi)) +for (i =0 ; i <MEMCG_NR_STAT ; i++) +atomic_long_add (stat[i], &mi->vmstats[i]); + +for_each_node (node) { +struct mem_cgroup_per_node *pn = memcg->nodeinfo[node]; +struct mem_cgroup_per_node *pi; + +for (i =0 ; i <NR_VM_NODE_STAT_ITEMS ; i++) + stat[i] =0 ; + +for_each_online_cpu (cpu) +for (i =0 ; i <NR_VM_NODE_STAT_ITEMS ; i++) + stat[i] +=raw_cpu_read ( + pn->lruvec_stat_cpu->count[i]); + +for (pi = pn; pi; pi =parent_nodeinfo (pi, node)) +for (i =0 ; i <NR_VM_NODE_STAT_ITEMS ; i++) +atomic_long_add (stat[i], &pi->lruvec_stat[i]); + } +} +static void memcg_offline_kmem (struct mem_cgroup *memcg) {struct cgroup_subsys_state *css;
@@ -4805,6 +4840,11 @@ static void __mem_cgroup_free(struct mem_cgroup *memcg) {int node; +/* +* Flush percpu vmstats to guarantee the value correctness +* on parent's and all ancestor levels. +*/ +memcg_flush_percpu_vmstats (memcg);for_each_node (node)free_mem_cgroup_per_node_info (memcg, node);free_percpu (memcg->vmstats_percpu);
Signature · 1 line
2.21.0
Andrew Morton
maintainerRe: [PATCH 1/2] mm: memcontrol: flush percpu vmstats before releasing memcg
Quoted 22 lines · On Mon, 12 Aug 2019 15:29:10 -0700 Roman Gushchin <[email protected]> wrote:
Percpu caching of local vmstats with the conditional propagation by the cgroup tree leads to an accumulation of errors on non-leaf levels.
Let's imagine two nested memory cgroups A and A/B. Say, a process belonging to A/B allocates 100 pagecache pages on the CPU 0. The percpu cache will spill 3 times, so that 32*3=96 pages will be accounted to A/B and A atomic vmstat counters, 4 pages will remain in the percpu cache.
Imagine A/B is nearby memory.max, so that every following allocation triggers a direct reclaim on the local CPU. Say, each such attempt will free 16 pages on a new cpu. That means every percpu cache will have -16 pages, except the first one, which will have 4 - 16 = -12. A/B and A atomic counters will not be touched at all.
Now a user removes A/B. All percpu caches are freed and corresponding vmstat numbers are forgotten. A has 96 pages more than expected.
As memory cgroups are created and destroyed, errors do accumulate. Even 1-2 pages differences can accumulate into large numbers.
Quoted 8 lines
To fix this issue let's accumulate and propagate percpu vmstat values before releasing the memory cgroup. At this point these numbers are stable and cannot be changed.
Since on cpu hotplug we do flush percpu vmstats anyway, we can iterate only over online cpus.
Fixes 42a300353577 ("mm: memcontrol: fix recursive statistics correctness & scalabilty")
Is this not serious enough for a cc:stable?
Re: [PATCH 1/2] mm: memcontrol: flush percpu vmstats before releasing memcg
Quoted 28 lines · Andrew Morton
Quoted 26 lines · On Mon, 12 Aug 2019 15:29:10 -0700 Roman Gushchin <[email protected]> wrote:
Percpu caching of local vmstats with the conditional propagation by the cgroup tree leads to an accumulation of errors on non-leaf levels.
Let's imagine two nested memory cgroups A and A/B. Say, a process belonging to A/B allocates 100 pagecache pages on the CPU 0. The percpu cache will spill 3 times, so that 32*3=96 pages will be accounted to A/B and A atomic vmstat counters, 4 pages will remain in the percpu cache.
Imagine A/B is nearby memory.max, so that every following allocation triggers a direct reclaim on the local CPU. Say, each such attempt will free 16 pages on a new cpu. That means every percpu cache will have -16 pages, except the first one, which will have 4 - 16 = -12. A/B and A atomic counters will not be touched at all.
Now a user removes A/B. All percpu caches are freed and corresponding vmstat numbers are forgotten. A has 96 pages more than expected.
As memory cgroups are created and destroyed, errors do accumulate. Even 1-2 pages differences can accumulate into large numbers.
To fix this issue let's accumulate and propagate percpu vmstat values before releasing the memory cgroup. At this point these numbers are stable and cannot be changed.
Quoted 6 lines
Quoted 4 lines
Since on cpu hotplug we do flush percpu vmstats anyway, we can iterate only over online cpus.
Fixes 42a300353577 ("mm: memcontrol: fix recursive statistics correctness & scalabilty")Is this not serious enough for a cc:stable?
I hope the "Fixes" tag will work, but yeah, my bad, cc:stable is definitely a good idea here.
Added stable@ to cc.
Thanks!
Re: [PATCH 1/2] mm: memcontrol: flush percpu vmstats before releasing memcg
This report is kind of late, hope everyone still remembers the context.
I just happened to see a similar problem on our v4.19 kernel, please see the below output from memory.stat:
total_cache 7361626112total_rss 8268165120total_rss_huge 0total_shmem 0total_mapped_file 4154929152total_dirty 389689344total_writeback 101376000
...
[snip]
...total_inactive_anon 4096total_active_anon 1638400total_inactive_file 208990208total_active_file 275030016
And memory.usage_in_bytes:
1248215040
The total_* counters are way bigger than the counters of LRUs and usage.
Some ephemeral cgroups were created/deleted frequently under this problematic cgroup. And this host has been up for more than 200 days. I didn't see such problems on shorter uptime hosts (the other 4.19 host is up for 19 days) and v5.4 hosts.
v4.19 also updates stats from per-cpu caches, and total_* sum all sub cgroups together. So it seems this is the same problem.
Anyway this is not a significant problem since we can get the correct numbers from other counters, i.e. LRUs, but just confusing. Not sure if it is worth backporting the fix to v4.19.
Quoted 44 lines · Roman Gushchin
Quoted 28 lines · Andrew Morton
Quoted 26 lines · On Mon, 12 Aug 2019 15:29:10 -0700 Roman Gushchin <[email protected]> wrote:
Percpu caching of local vmstats with the conditional propagation by the cgroup tree leads to an accumulation of errors on non-leaf levels.
Let's imagine two nested memory cgroups A and A/B. Say, a process belonging to A/B allocates 100 pagecache pages on the CPU 0. The percpu cache will spill 3 times, so that 32*3=96 pages will be accounted to A/B and A atomic vmstat counters, 4 pages will remain in the percpu cache.
Imagine A/B is nearby memory.max, so that every following allocation triggers a direct reclaim on the local CPU. Say, each such attempt will free 16 pages on a new cpu. That means every percpu cache will have -16 pages, except the first one, which will have 4 - 16 = -12. A/B and A atomic counters will not be touched at all.
Now a user removes A/B. All percpu caches are freed and corresponding vmstat numbers are forgotten. A has 96 pages more than expected.
As memory cgroups are created and destroyed, errors do accumulate. Even 1-2 pages differences can accumulate into large numbers.
To fix this issue let's accumulate and propagate percpu vmstat values before releasing the memory cgroup. At this point these numbers are stable and cannot be changed.
Quoted 6 lines
Quoted 4 lines
Since on cpu hotplug we do flush percpu vmstats anyway, we can iterate only over online cpus.
Fixes 42a300353577 ("mm: memcontrol: fix recursive statistics correctness & scalabilty")Is this not serious enough for a cc:stable?
I hope the "Fixes" tag will work, but yeah, my bad, cc:stable is definitely a good idea here.
Added stable@ to cc.
Thanks!
Re: [PATCH 1/2] mm: memcontrol: flush percpu vmstats before releasing memcg
In reply to Roman GushchinQuoted 19 lines · Roman Gushchin
Percpu caching of local vmstats with the conditional propagation by the cgroup tree leads to an accumulation of errors on non-leaf levels.
Let's imagine two nested memory cgroups A and A/B. Say, a process belonging to A/B allocates 100 pagecache pages on the CPU 0. The percpu cache will spill 3 times, so that 32*3=96 pages will be accounted to A/B and A atomic vmstat counters, 4 pages will remain in the percpu cache.
Imagine A/B is nearby memory.max, so that every following allocation triggers a direct reclaim on the local CPU. Say, each such attempt will free 16 pages on a new cpu. That means every percpu cache will have -16 pages, except the first one, which will have 4 - 16 = -12. A/B and A atomic counters will not be touched at all.
Now a user removes A/B. All percpu caches are freed and corresponding vmstat numbers are forgotten. A has 96 pages more than expected.
Quoted 6 lines
As memory cgroups are created and destroyed, errors do accumulate. Even 1-2 pages differences can accumulate into large numbers.
To fix this issue let's accumulate and propagate percpu vmstat values before releasing the memory cgroup. At this point these numbers are stable and cannot be changed.
It is worth spending a word or two on why this doesn't matter during the memcg life time.
Quoted 6 lines
Since on cpu hotplug we do flush percpu vmstats anyway, we can iterate only over online cpus.
Fixes 42a300353577 ("mm: memcontrol: fix recursive statistics correctness & scalabilty")Signed-off-by Roman Gushchin <[email protected]>Cc Johannes Weiner <[email protected]>
Quoted 64 lines
--- mm/memcontrol.c | 40 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+)mm/memcontrol.c +40
-0@@ -3412,6 +3412,41 @@ static int memcg_online_kmem(struct mem_cgroup *memcg)return 0 ; } +static void memcg_flush_percpu_vmstats (struct mem_cgroup *memcg) +{ +unsigned long stat[MEMCG_NR_STAT ]; +struct mem_cgroup *mi; +int node, cpu, i; + +for (i =0 ; i <MEMCG_NR_STAT ; i++) + stat[i] =0 ; + +for_each_online_cpu (cpu) +for (i =0 ; i <MEMCG_NR_STAT ; i++) + stat[i] +=raw_cpu_read (memcg->vmstats_percpu->stat[i]); + +for (mi = memcg; mi; mi =parent_mem_cgroup (mi)) +for (i =0 ; i <MEMCG_NR_STAT ; i++) +atomic_long_add (stat[i], &mi->vmstats[i]); + +for_each_node (node) { +struct mem_cgroup_per_node *pn = memcg->nodeinfo[node]; +struct mem_cgroup_per_node *pi; + +for (i =0 ; i <NR_VM_NODE_STAT_ITEMS ; i++) + stat[i] =0 ; + +for_each_online_cpu (cpu) +for (i =0 ; i <NR_VM_NODE_STAT_ITEMS ; i++) + stat[i] +=raw_cpu_read ( + pn->lruvec_stat_cpu->count[i]); + +for (pi = pn; pi; pi =parent_nodeinfo (pi, node)) +for (i =0 ; i <NR_VM_NODE_STAT_ITEMS ; i++) +atomic_long_add (stat[i], &pi->lruvec_stat[i]); + } +} +static void memcg_offline_kmem (struct mem_cgroup *memcg) {struct cgroup_subsys_state *css;@@ -4805,6 +4840,11 @@ static void __mem_cgroup_free(struct mem_cgroup *memcg) {int node; +/* +* Flush percpu vmstats to guarantee the value correctness +* on parent's and all ancestor levels. +*/ +memcg_flush_percpu_vmstats (memcg);for_each_node (node)free_mem_cgroup_per_node_info (memcg, node);free_percpu (memcg->vmstats_percpu);Signature · 1 line
2.21.0
Signature · 2 lines
Michal Hocko SUSE Labs
PATCH 2/2 mm: memcontrol: flush percpu slab vmstats on kmem offlining
In reply to Roman GushchinI've noticed that the "slab" value in memory.stat is sometimes 0, even if some children memory cgroups have a non-zero "slab" value. The following investigation showed that this is the result of the kmem_cache reparenting in combination with the per-cpu batching of slab vmstats.
At the offlining some vmstat value may leave in the percpu cache, not being propagated upwards by the cgroup hierarchy. It means that stats on ancestor levels are lower than actual. Later when slab pages are released, the precise number of pages is substracted on the parent level, making the value negative. We don't show negative values, 0 is printed instead.
To fix this issue, let's flush percpu slab memcg and lruvec stats on memcg offlining. This guarantees that numbers on all ancestor levels are accurate and match the actual number of outstanding slab pages.
--- mm/memcontrol.c | 35 +++++++++++++++++++++++++++-------- 1 file changed, 27 insertions(+), 8 deletions(-)
mm/memcontrol.c +27 -8
@@ -3412,37 +3412,49 @@ static int memcg_online_kmem(struct mem_cgroup *memcg)return 0 ; } -static void memcg_flush_percpu_vmstats (struct mem_cgroup *memcg) +static void memcg_flush_percpu_vmstats (struct mem_cgroup *memcg,bool slab_only) {unsigned long stat[MEMCG_NR_STAT ];struct mem_cgroup *mi;int node, cpu, i; +int min_idx, max_idx; -for (i =0 ; i <MEMCG_NR_STAT ; i++) +if (slab_only) { + min_idx =NR_SLAB_RECLAIMABLE ; + max_idx =NR_SLAB_UNRECLAIMABLE ; + }else { + min_idx =0 ; + max_idx =MEMCG_NR_STAT ; + } + +for (i = min_idx; i < max_idx; i++) stat[i] =0 ;for_each_online_cpu (cpu) -for (i =0 ; i <MEMCG_NR_STAT ; i++) +for (i = min_idx; i < max_idx; i++) stat[i] +=raw_cpu_read (memcg->vmstats_percpu->stat[i]);for (mi = memcg; mi; mi =parent_mem_cgroup (mi)) -for (i =0 ; i <MEMCG_NR_STAT ; i++) +for (i = min_idx; i < max_idx; i++)atomic_long_add (stat[i], &mi->vmstats[i]); +if (!slab_only) + max_idx =NR_VM_NODE_STAT_ITEMS ; +for_each_node (node) {struct mem_cgroup_per_node *pn = memcg->nodeinfo[node];struct mem_cgroup_per_node *pi; -for (i =0 ; i <NR_VM_NODE_STAT_ITEMS ; i++) +for (i = min_idx; i < max_idx; i++) stat[i] =0 ;for_each_online_cpu (cpu) -for (i =0 ; i <NR_VM_NODE_STAT_ITEMS ; i++) +for (i = min_idx; i < max_idx; i++) stat[i] +=raw_cpu_read ( pn->lruvec_stat_cpu->count[i]);for (pi = pn; pi; pi =parent_nodeinfo (pi, node)) -for (i =0 ; i <NR_VM_NODE_STAT_ITEMS ; i++) +for (i = min_idx; i < max_idx; i++)atomic_long_add (stat[i], &pi->lruvec_stat[i]); } }
@@ -3467,7 +3479,14 @@ static void memcg_offline_kmem(struct mem_cgroup *memcg)if (!parent) parent = root_mem_cgroup; +/* +* Deactivate and reparent kmem_caches. Then flush percpu +* slab statistics to have precise values at the parent and +* all ancestor levels. It's required to keep slab stats +* accurate after the reparenting of kmem_caches. +*/ memcg_deactivate_kmem_caches (memcg, parent); +memcg_flush_percpu_vmstats (memcg, true); kmemcg_id = memcg->kmemcg_id;BUG_ON (kmemcg_id <0 );
@@ -4844,7 +4863,7 @@ static void __mem_cgroup_free(struct mem_cgroup *memcg)* Flush percpu vmstats to guarantee the value correctness * on parent's and all ancestor levels. */ -memcg_flush_percpu_vmstats (memcg); +memcg_flush_percpu_vmstats (memcg, false);for_each_node (node)free_mem_cgroup_per_node_info (memcg, node);free_percpu (memcg->vmstats_percpu);
Signature · 1 line
2.21.0
Michal Hocko
maintainerRe: [PATCH 2/2] mm: memcontrol: flush percpu slab vmstats on kmem offlining
Quoted 6 lines · Roman Gushchin
I've noticed that the "slab" value in memory.stat is sometimes 0, even if some children memory cgroups have a non-zero "slab" value. The following investigation showed that this is the result of the
kmem_cachereparenting in combination with the per-cpu batching of slab vmstats.
Quoted 6 lines
At the offlining some vmstat value may leave in the percpu cache, not being propagated upwards by the cgroup hierarchy. It means that stats on ancestor levels are lower than actual. Later when slab pages are released, the precise number of pages is substracted on the parent level, making the value negative. We don't show negative values, 0 is printed instead.
So the difference with other counters is that slab ones are reparented and that's why we have treat them specially? I guess that is what the comment in the code suggest but being explicit in the changelog would be nice.
[...]
Quoted 6 lines
mm/memcontrol.c +1
-1-static void memcg_flush_percpu_vmstats (struct mem_cgroup *memcg) +static void memcg_flush_percpu_vmstats (struct mem_cgroup *memcg,bool slab_only) {unsigned long stat[MEMCG_NR_STAT ];struct mem_cgroup *mi;int node, cpu, i;
mm/memcontrol.c static int memcg_online_kmem(struct mem_cgroup *memcg) · line 3428
Quoted 10 lines
mm/memcontrol.c +8
-1+int min_idx, max_idx; -for (i =0 ; i <MEMCG_NR_STAT ; i++) +if (slab_only) { + min_idx =NR_SLAB_RECLAIMABLE ; + max_idx =NR_SLAB_UNRECLAIMABLE ; + }else { + min_idx =0 ; + max_idx =MEMCG_NR_STAT ; + }
This is just ugly has hell! I really detest how this implicitly makes counters value very special without any note in the node_stat_item definition. Is it such a big deal to have a per counter flush and do the loop over all counters resp. specific counters around it so much worse? This should be really a slow path to safe few instructions or cache misses, no?
Signature · 2 lines
Michal Hocko SUSE Labs
Re: [PATCH 2/2] mm: memcontrol: flush percpu slab vmstats on kmem offlining
Quoted 14 lines · Michal Hocko
Quoted 6 lines · Roman Gushchin
I've noticed that the "slab" value in memory.stat is sometimes 0, even if some children memory cgroups have a non-zero "slab" value. The following investigation showed that this is the result of the
kmem_cachereparenting in combination with the per-cpu batching of slab vmstats.Quoted 6 lines
At the offlining some vmstat value may leave in the percpu cache, not being propagated upwards by the cgroup hierarchy. It means that stats on ancestor levels are lower than actual. Later when slab pages are released, the precise number of pages is substracted on the parent level, making the value negative. We don't show negative values, 0 is printed instead.
Quoted 4 lines
So the difference with other counters is that slab ones are reparented and that's why we have treat them specially? I guess that is what the comment in the code suggest but being explicit in the changelog would be nice.
Right. And I believe the list can be extended further. Objects which are often outliving the origin memory cgroup (e.g. pagecache pages) are pinning dead cgroups, so it will be cool to reparent them all.
Quoted 10 lines
[...]
Quoted 8 lines
(quoted diff) +2
-1-static void memcg_flush_percpu_vmstats(struct mem_cgroup *memcg) +static void memcg_flush_percpu_vmstats(struct mem_cgroup *memcg, bool slab_only) { unsigned long stat[MEMCG_NR_STAT]; struct mem_cgroup *mi; int node, cpu, i; + int min_idx, max_idx;
Quoted 15 lines
Review
Quoted 8 lines
(quoted diff) +7
-1- for (i = 0; i < MEMCG_NR_STAT; i++) + if (slab_only) { + min_idx = NR_SLAB_RECLAIMABLE; + max_idx = NR_SLAB_UNRECLAIMABLE; + } else { + min_idx = 0; + max_idx = MEMCG_NR_STAT; + }This is just ugly has hell! I really detest how this implicitly makes counters value very special without any note in the
node_stat_itemdefinition. Is it such a big deal to have a per counter flush and do the loop over all counters resp. specific counters around it so much worse? This should be really a slow path to safe few instructions or cache misses, no?
I believe that it is a big deal, because it'sNR_VMSTAT_ITEMS * all memory cgroups * online cpus * numa nodes. If the goal is to merge it with cpu hotplug code, I'd think about passing cpumask to it, and do the opposite. Also I'm not sure I understand why reordering loops will make it less ugly.
But you're right, a comment nearby NR_SLAB_(UN)RECLAIMABLE definition is totaly worth it. How about something like:
include/linux/mmzone.h +3 -2
@@ -215,8 +215,9 @@ enum node_stat_item {NR_INACTIVE_FILE ,/* " " " " " */ NR_ACTIVE_FILE ,/* " " " " " */ NR_UNEVICTABLE ,/* " " " " " */ -NR_SLAB_RECLAIMABLE , -NR_SLAB_UNRECLAIMABLE , +NR_SLAB_RECLAIMABLE ,/* Please, do not reorder this item */ +NR_SLAB_UNRECLAIMABLE ,/* and this one without looking at +* memcg_flush_percpu_vmstats() first. */ NR_ISOLATED_ANON ,/* Temporary isolated pages from anon lru */ NR_ISOLATED_FILE ,/* Temporary isolated pages from file lru */ WORKINGSET_NODES,
--
Thanks!
Michal Hocko
maintainerRe: [PATCH 2/2] mm: memcontrol: flush percpu slab vmstats on kmem offlining
Quoted 50 lines · Roman Gushchin
Quoted 14 lines · Michal Hocko
Quoted 6 lines · Roman Gushchin
I've noticed that the "slab" value in memory.stat is sometimes 0, even if some children memory cgroups have a non-zero "slab" value. The following investigation showed that this is the result of the
kmem_cachereparenting in combination with the per-cpu batching of slab vmstats.Quoted 6 lines
At the offlining some vmstat value may leave in the percpu cache, not being propagated upwards by the cgroup hierarchy. It means that stats on ancestor levels are lower than actual. Later when slab pages are released, the precise number of pages is substracted on the parent level, making the value negative. We don't show negative values, 0 is printed instead.
Quoted 4 lines
So the difference with other counters is that slab ones are reparented and that's why we have treat them specially? I guess that is what the comment in the code suggest but being explicit in the changelog would be nice.
Right. And I believe the list can be extended further. Objects which are often outliving the origin memory cgroup (e.g. pagecache pages) are pinning dead cgroups, so it will be cool to reparent them all.
Quoted 10 lines
[...]
Quoted 8 lines
(quoted diff) +2
-1-static void memcg_flush_percpu_vmstats(struct mem_cgroup *memcg) +static void memcg_flush_percpu_vmstats(struct mem_cgroup *memcg, bool slab_only) { unsigned long stat[MEMCG_NR_STAT]; struct mem_cgroup *mi; int node, cpu, i; + int min_idx, max_idx;Quoted 15 lines
Review
Quoted 8 lines
(quoted diff) +7
-1- for (i = 0; i < MEMCG_NR_STAT; i++) + if (slab_only) { + min_idx = NR_SLAB_RECLAIMABLE; + max_idx = NR_SLAB_UNRECLAIMABLE; + } else { + min_idx = 0; + max_idx = MEMCG_NR_STAT; + }This is just ugly has hell! I really detest how this implicitly makes counters value very special without any note in the
node_stat_itemdefinition. Is it such a big deal to have a per counter flush and do the loop over all counters resp. specific counters around it so much worse? This should be really a slow path to safe few instructions or cache misses, no?
Quoted 2 lines
I believe that it is a big deal, because it's
NR_VMSTAT_ITEMS* all memory cgroups * online cpus * numa nodes.
I am not sure I follow. I just meant to remove all for (i = 0; i < MEMCG_NR_STAT; i++) from flushing and do that loop around the flushing function. That would mean that the NR_SLAB_$FOO wouldn't have to play tricks and simply call the flushing for the two counters.
Quoted 3 lines
If the goal is to merge it with cpu hotplug code, I'd think about passing cpumask to it, and do the opposite. Also I'm not sure I understand why reordering loops will make it less ugly.
And adding a cpu/nodemasks would just work with that as well, right.
Quoted 10 lines
But you're right, a comment nearby NR_SLAB_(UN)RECLAIMABLE definition is totaly worth it. How about something like:
include/linux/mmzone.h +0
-0@@ -215,8 +215,9 @@ enum node_stat_item { NR_INACTIVE_FILE, /* " " " " " */
include/linux/mmzone.h enum node_stat_item { · line 223
Quoted 10 lines
include/linux/mmzone.h +3
-2NR_ACTIVE_FILE ,/* " " " " " */ NR_UNEVICTABLE ,/* " " " " " */ -NR_SLAB_RECLAIMABLE , -NR_SLAB_UNRECLAIMABLE , +NR_SLAB_RECLAIMABLE ,/* Please, do not reorder this item */ +NR_SLAB_UNRECLAIMABLE ,/* and this one without looking at +* memcg_flush_percpu_vmstats() first. */ NR_ISOLATED_ANON ,/* Temporary isolated pages from anon lru */ NR_ISOLATED_FILE ,/* Temporary isolated pages from file lru */ WORKINGSET_NODES,
Thanks, that is an improvement.
Signature · 2 lines
Michal Hocko SUSE Labs