package/ti-gfx: do not use devmem2 in script
PATCH 1/1 package/ti-gfx: do not use devmem2 in script
From: Carlos Santos <[email protected]>
ti-gfx may install a debug script that uses devmem2 but does not select BR2_PACKAGE_DEVMEM2. Use devmem, instead, already provided by Busybox.
---
CC: Ciro Santilli <[email protected]>
---
Found while investigating https://bugs.busybox.net/show_bug.cgi?id=10171
In the future we may decide to deprecate devmem2.
Tested on QEMU, forging the results of "devmem" 0x56000014", since I don't have any board with a TI GFX board.
--- package/ti-gfx/esrev.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
package/ti-gfx/esrev.sh +2 -1
@@ -48,7 +48,8 @@ case $CPUTYPE in devmem 0x48180900 w 0x2 devmem 0x48180920 w 0x2 - ES_REVISION="$(devmem2 0x56000014 | sed -e s:0x00010205:6: -e s:0x00010201:3: -e s:0x00010003:2: | tail -n1 | awk -F': ' '{print $2}')" + ES_REVISION="$(devmem 0x56000014 | sed -e s:0x00010205:6: \ + -e s:0x00010201:3: -e s:0x00010003:2:)" ;; *) echo Unable to determine SGX hardware
Signature · 1 line
2.18.1
Thomas Petazzoni
AppliedPATCH 1/1 package/ti-gfx: do not use devmem2 in script
Quoted 10 lines · On Sun, 11 Aug 2019 20:01:43 -0300 unixmania at gmail.com wrote:
From: Carlos Santos <[email protected]>
ti-gfx may install a debug script that uses devmem2 but does not select
BR2_PACKAGE_DEVMEM2. Use devmem, instead, already provided by Busybox.Signed-off-by Carlos Santos <[email protected]>---
CC: Ciro Santilli <[email protected]>
---
Found while investigating https://bugs.busybox.net/show_bug.cgi?id=10171
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com