Skip to contentSkip to conversation

package/python-brotli: new package

PATCH New James Hilliard 2 participants 3 messages Aug 12, 2019 – Aug 13, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/python-brotli: new package

---
 DEVELOPERS                               |  1 +
 package/Config.in                        |  1 +
 package/python-brotli/Config.in          |  7 +++++++
 package/python-brotli/python-brotli.hash |  5 +++++
 package/python-brotli/python-brotli.mk   | 20 ++++++++++++++++++++
 5 files changed, 34 insertions(+)
 create mode 100644 package/python-brotli/Config.in
 create mode 100644 package/python-brotli/python-brotli.hash
 create mode 100644 package/python-brotli/python-brotli.mk
DEVELOPERS +1 -0
index 8ad48b95cb..27a98db256 100644
@@ -1087,6 +1087,7 @@ F:	package/python-aiomonitor/
 F:	package/python-aiojobs/
 F:	package/python-aiorwlock/
 F:	package/python-async-timeout/
+F:	package/python-brotli/
 F:	package/python-cchardet/
 F:	package/python-multidict/
 F:	package/python-pycares/
package/Config.in +1 -0
index c984dcea6f..9f544f955c 100644
@@ -844,6 +844,7 @@ menu "External python modules"
 	source "package/python-beautifulsoup4/Config.in"
 	source "package/python-bitstring/Config.in"
 	source "package/python-bottle/Config.in"
+	source "package/python-brotli/Config.in"
 	source "package/python-cached-property/Config.in"
 	source "package/python-can/Config.in"
 	source "package/python-cbor/Config.in"
package/python-brotli/Config.in new file +7 -0
new file mode 100644
index 0000000000..1c09c26866
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_PYTHON_BROTLI
+	bool "python-brotli"
+	depends on BR2_INSTALL_LIBSTDCPP
+	help
+	  Python bindings for the Brotli compression library.
+
+	  https://github.com/google/brotli
package/python-brotli/python-brotli.hash new file +5 -0
new file mode 100644
index 0000000000..eaf59ae71e
@@ -0,0 +1,5 @@
+# md5, sha256 from https://pypi.org/pypi/brotli/json
+md5	3444b534e86f65f9f229fd123965be87  Brotli-1.0.7.zip
+sha256	0538dc1744fd17c314d2adc409ea7d1b779783b89fd95bcfb0c2acc93a6ea5a7  Brotli-1.0.7.zip
+# Locally computed sha256 checksums
+sha256	3d180008e36922a4e8daec11c34c7af264fed5962d07924aea928c38e8663c94  LICENSE
package/python-brotli/python-brotli.mk new file +20 -0
new file mode 100644
index 0000000000..fbbfee5239
@@ -0,0 +1,20 @@
+################################################################################
+#
+# python-brotli
+#
+################################################################################
+
+PYTHON_BROTLI_VERSION = 1.0.7
+PYTHON_BROTLI_SOURCE = Brotli-$(PYTHON_BROTLI_VERSION).zip
+PYTHON_BROTLI_SITE = https://files.pythonhosted.org/packages/cd/9c/7955895f5672ecc85270244582c6b53ff95bb4c24bf77bd9271d42351635
+PYTHON_BROTLI_SETUP_TYPE = setuptools
+PYTHON_BROTLI_LICENSE = Apache-2.0
+PYTHON_BROTLI_LICENSE_FILES = LICENSE
+
+define PYTHON_BROTLI_EXTRACT_CMDS
+	$(UNZIP) -d $(@D) $(PYTHON_BROTLI_DL_DIR)/$(PYTHON_BROTLI_SOURCE)
+	mv $(@D)/Brotli-$(PYTHON_BROTLI_VERSION)/* $(@D)
+	$(RM) -r $(@D)/Brotli-$(PYTHON_BROTLI_VERSION)
+endef
+
+$(eval $(python-package))
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/python-brotli: new package

Hello James,

package/python-brotli/python-brotli.mk line 11

Quoted 5 lines · On Mon, 12 Aug 2019 17:03:45 -0600 James Hilliard <[email protected]>…
package/python-brotli/python-brotli.mk new file +5 -0
+PYTHON_BROTLI_VERSION = 1.0.7
+PYTHON_BROTLI_SOURCE = Brotli-$(PYTHON_BROTLI_VERSION).zip
+PYTHON_BROTLI_SITE = https://files.pythonhosted.org/packages/cd/9c/7955895f5672ecc85270244582c6b53ff95bb4c24bf77bd9271d42351635
+PYTHON_BROTLI_SETUP_TYPE = setuptools
+PYTHON_BROTLI_LICENSE = Apache-2.0

Pypi is wrong: the license is MIT, not Apache-2.0 (just read the LICENSE file to verify). I've fixed this and applied your patch to next. You probably want to notify the python-brotli maintainers that the license details regarding their package are incorrect on pypi.org.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/python-brotli: new package

Quoted 6 lines · Thomas Petazzoni

Hello James,

On Mon, 12 Aug 2019 17:03:45 -0600
James Hilliard <[email protected]> wrote:

Quoted 10 lines

package/python-brotli/python-brotli.mk line 11

Quoted 5 lines
package/python-brotli/python-brotli.mk new file +5 -0
+PYTHON_BROTLI_VERSION = 1.0.7
+PYTHON_BROTLI_SOURCE = Brotli-$(PYTHON_BROTLI_VERSION).zip
+PYTHON_BROTLI_SITE = https://files.pythonhosted.org/packages/cd/9c/7955895f5672ecc85270244582c6b53ff95bb4c24bf77bd9271d42351635
+PYTHON_BROTLI_SETUP_TYPE = setuptools
+PYTHON_BROTLI_LICENSE = Apache-2.0

Pypi is wrong: the license is MIT, not Apache-2.0 (just read the LICENSE file to verify). I've fixed this and applied your patch to next. You probably want to notify the python-brotli maintainers that the license details regarding their package are incorrect on pypi.org.

Yeah, that's odd, the project specifies Apache-2.0 here:
https://github.com/google/brotli/blob/v1.0.7/setup.py#L145

That's what pypi seems to be picking up.

Quoted 8 lines

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com