Skip to contentSkip to conversation

mptcp: Add sock_put() call on error path

PATCH In review Peter Krystad 2 participants 2 messages Aug 12, 2019 – Aug 13, 2019

Subsystems (2)
lore
Share & tools
lore

Peter Krystad

author
#0 lore raw

PATCH 1/1 mptcp: Add sock_put() call on error path

Per final review comment

squashto: Add handling of outgoing MP_JOIN requests

Signed-off-by Peter Krystad <peter.krystad(a)linux.intel.com>
---
 net/mptcp/subflow.c | 1 +
 1 file changed, 1 insertion(+)
net/mptcp/subflow.c +1 -0
index 448c9e7f567a..27afc64d377f 100644
@@ -257,6 +257,7 @@ int subflow_connect(struct sock *sk, struct sockaddr_in *local,
 	return err;
 
 failed:
+	sock_put(sf->sk);
 	sock_release(sf);
 	return err;
 }
Signature · 1 line
2.17.2
#1 lore raw

Hi Mat, Peter,

Quoted 3 lines · Peter Krystad

Per final review comment

squashto: Add handling of outgoing MP_JOIN requests

Thank you for finding the issue and fixing it!

- 527d1a3ee6a8: "squashed" in "mptcp: Add handling of outgoing MP_JOIN requests"
- 6e195bff312b..a873cedf4afa: result

Tests are still OK.

Cheers,
Matt

Signature · 5 lines
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium