Skip to contentSkip to conversation

drm/amd/powerplay: fix message of SetHardMinByFreq failed when feature is disabled

PATCH In review Wang, Kevin(Yang) 2 participants 2 messages Aug 13, 2019 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amd/powerplay: fix message of SetHardMinByFreq failed when feature is disabled

the direct send message to smc to set hard clokc will failed when smc clock dpm feature is disabled.
so use function of smu_set_hard_freq_range to replace it. the function will check feature enablement.

eg: when uclk (mclk) dpm feature is disabled on navi10
[  300.675901] amdgpu: [powerplay] failed send message: SetHardMinByFreq(28)
   param: 0x00020064 response 0xfffffffb

---
 drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)
drivers/gpu/drm/amd/powerplay/smu_v11_0.c +1 -9
index 3a081acdf1a8..3a49cabf726f 100644
@@ -1306,16 +1306,8 @@ smu_v11_0_display_clock_voltage_request(struct smu_context *smu,
 		if (clk_select == SMU_UCLK && smu->disable_uclk_switch)
 			return 0;
 
-		clk_id = smu_clk_get_index(smu, clk_select);
-		if (clk_id < 0) {
-			ret = -EINVAL;
-			goto failed;
-		}
-
-
 		mutex_lock(&smu->mutex);
-		ret = smu_send_smc_msg_with_param(smu, SMU_MSG_SetHardMinByFreq,
-			(clk_id << 16) | clk_freq);
+		ret = smu_set_hard_freq_range(smu, clk_select, 0, clk_freq);
 		mutex_unlock(&smu->mutex);
 
 		if(clk_select == SMU_UCLK)
Signature · 6 lines
2.22.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

Reviewed-by Evan Quan
#2 lore raw
Quoted 50 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Wang, Kevin(Yang)
Sent: Tuesday, August 13, 2019 10:34 AM
To: dl.srdc_lnx_nv10 <[email protected]>
Cc: Wang, Kevin(Yang) <[email protected]>; Huang, Ray <[email protected]>; Feng, Kenneth <[email protected]>; amd- [email protected]
Subject: [PATCH] drm/amd/powerplay: fix message of SetHardMinByFreq failed when feature is disabled

the direct send message to smc to set hard clokc will failed when smc clock dpm feature is disabled.
so use function of smu_set_hard_freq_range to replace it. the function will check feature enablement.

eg: when uclk (mclk) dpm feature is disabled on navi10 [  300.675901] amdgpu: [powerplay] failed send message:
SetHardMinByFreq(28)
   param: 0x00020064 response 0xfffffffb

---
 drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)
drivers/gpu/drm/amd/powerplay/smu_v11_0.c +1 -9
index 3a081acdf1a8..3a49cabf726f 100644
@@ -1306,16 +1306,8 @@ smu_v11_0_display_clock_voltage_request(struct
 smu_context *smu,
 		if (clk_select == SMU_UCLK && smu->disable_uclk_switch)
 			return 0;
 
-		clk_id = smu_clk_get_index(smu, clk_select);
-		if (clk_id < 0) {
-			ret = -EINVAL;
-			goto failed;
-		}
-
-
 		mutex_lock(&smu->mutex);
-		ret = smu_send_smc_msg_with_param(smu,
 SMU_MSG_SetHardMinByFreq,
-			(clk_id << 16) | clk_freq);
+		ret = smu_set_hard_freq_range(smu, clk_select, 0, clk_freq);
 		mutex_unlock(&smu->mutex);
Quoted 8 lines

if(clk_select == SMU_UCLK)
--
2.22.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx