Skip to contentSkip to conversation

zd1211rw: remove false assertion from zd_mac_clear()

PATCH In review Oliver Neukum 2 participants 2 messages Aug 13, 2019 – Sep 3, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 zd1211rw: remove false assertion from zd_mac_clear()

The function is called before the lock which is asserted was ever used. Just remove it.

V2: correct CCs
V3: correct name

---
 drivers/net/wireless/zydas/zd1211rw/zd_mac.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/wireless/zydas/zd1211rw/zd_mac.c +0 -1
index da7e63fca9f5..a9999d10ae81 100644
@@ -223,7 +223,6 @@ void zd_mac_clear(struct zd_mac *mac)
 {
 	flush_workqueue(zd_workqueue);
 	zd_chip_clear(&mac->chip);
-	lockdep_assert_held(&mac->lock);
 	ZD_MEMCLEAR(mac, sizeof(struct zd_mac));
 }
 
Signature · 1 line
2.16.4
#1 lore raw
Quoted 5 lines · Oliver Neukum

The function is called before the lock which is asserted was ever used. Just remove it.

Patch applied to wireless-drivers-next.git, thanks.

7a2eb7367fde zd1211rw: remove false assertion from zd_mac_clear()

Signature · 3 lines
https://patchwork.kernel.org/patch/11092009/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches