soc: ti: pm33xx: Fix static checker warnings
PATCH 1/1 soc: ti: pm33xx: Fix static checker warnings
The patch fixes a bunch of static checker warnings.
Reported-by Dan Carpenter <[email protected]>
Signed-off-by Keerthy <[email protected]>
--- drivers/soc/ti/pm33xx.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)
drivers/soc/ti/pm33xx.c +10 -5
@@ -252,7 +252,7 @@ static int am33xx_pm_begin(suspend_state_t state)if (state ==PM_SUSPEND_MEM && pm_ops->check_off_mode_enable ()) { nvmem =devm_nvmem_device_get (&omap_rtc->dev,"omap_rtc_scratch0" ); -if (nvmem) +if (!IS_ERR (nvmem))nvmem_device_write (nvmem,RTC_SCRATCH_MAGIC_REG *4 ,4 , (void *)&rtc_magic_val); rtc_only_idle =1 ;
@@ -278,9 +278,12 @@ static void am33xx_pm_end(void)struct nvmem_device *nvmem; nvmem =devm_nvmem_device_get (&omap_rtc->dev,"omap_rtc_scratch0" ); +if (IS_ERR (nvmem)) +return ; + m3_ipc->ops->finish_low_power (m3_ipc);if (rtc_only_idle) { -if (retrigger_irq) +if (retrigger_irq) {/* * 32 bits of Interrupt Set-Pending correspond to 32 * 32 interrupts. Compute the bit offset of the
@@ -291,8 +294,10 @@ static void am33xx_pm_end(void)writel_relaxed (1 << (retrigger_irq &31 ), gic_dist_base +GIC_INT_SET_PENDING_BASE + retrigger_irq /32 *4 ); -nvmem_device_write (nvmem,RTC_SCRATCH_MAGIC_REG *4 ,4 , - (void *)&val); + } + +nvmem_device_write (nvmem,RTC_SCRATCH_MAGIC_REG *4 ,4 , + (void *)&val); } rtc_only_idle =0 ;
@@ -415,7 +420,7 @@ static int am33xx_pm_rtc_setup(void) nvmem =devm_nvmem_device_get (&omap_rtc->dev,"omap_rtc_scratch0" ); -if (nvmem) { +if (!IS_ERR (nvmem)) {nvmem_device_read (nvmem,RTC_SCRATCH_MAGIC_REG *4 ,4 , (void *)&rtc_magic_val);if ((rtc_magic_val &0xffff ) !=RTC_REG_BOOT_MAGIC )
Signature · 1 line
2.17.1
Quoted 1 line · Keerthy
The patch fixes a bunch of static checker warnings.
Sorry I just noticed that this one is still pending, applying into fixes.
Tony
Quoted 5 lines · Tony Lindgren
Quoted 1 line · Keerthy
The patch fixes a bunch of static checker warnings.
Sorry I just noticed that this one is still pending, applying into fixes.
Thanks Tony
Quoted 3 lines
Tony
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel