Skip to contentSkip to conversation

igt-gpu-tools: add new package

PATCH New Gaël PORTAY 2 participants 4 messages Dec 4, 2018 – Aug 13, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 igt-gpu-tools: add new package

---
 DEVELOPERS                               |  1 +
 package/Config.in                        |  1 +
 package/igt-gpu-tools/Config.in          | 27 ++++++++++++++++++++++++
 package/igt-gpu-tools/igt-gpu-tools.hash |  5 +++++
 package/igt-gpu-tools/igt-gpu-tools.mk   | 16 ++++++++++++++
 5 files changed, 50 insertions(+)
 create mode 100644 package/igt-gpu-tools/Config.in
 create mode 100644 package/igt-gpu-tools/igt-gpu-tools.hash
 create mode 100644 package/igt-gpu-tools/igt-gpu-tools.mk
DEVELOPERS +1 -0
index 53467da489..c9189bf771 100644
@@ -846,6 +846,7 @@ F:	package/upx/
 F:	package/zxing-cpp/
 
 N:	Ga?l Portay <[email protected]>
+F:	package/igt-gpu-tools/
 F:	package/qt5/qt5virtualkeyboard/
 F:	package/qt5/qt5webengine/
 F:	package/qt5/qt5webkit/
package/Config.in +1 -0
index b60e7700ad..11f7e0c950 100644
@@ -1241,6 +1241,7 @@ menu "Graphics"
 	source "package/gtkmm3/Config.in"
 	source "package/gtksourceview/Config.in"
 	source "package/harfbuzz/Config.in"
+	source "package/igt-gpu-tools/Config.in"
 	source "package/ijs/Config.in"
 	source "package/imlib2/Config.in"
 	source "package/irrlicht/Config.in"
package/igt-gpu-tools/Config.in new file +27 -0
new file mode 100644
index 0000000000..73e217e93c
@@ -0,0 +1,27 @@
+config BR2_PACKAGE_IGT_GPU_TOOLS
+	bool "igt-gpu-tools"
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm libunwind
+	depends on !BR2_STATIC_LIBS # kmod libunwind
+	depends on BR2_USE_MMU # procps-ng
+	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # procps-ng
+	depends on BR2_PACKAGE_HAS_OPENSSL
+	depends on BR2_PACKAGE_HAS_UDEV
+	depends on BR2_PACKAGE_LIBUNWIND_ARCH_SUPPORTS # libunwind
+	select BR2_PACKAGE_CAIRO
+	select BR2_PACKAGE_CAIRO_PNG
+	select BR2_PACKAGE_KMOD
+	select BR2_PACKAGE_LIBDRM
+	select BR2_PACKAGE_LIBUNWIND
+	select BR2_PACKAGE_LIBPCIACCESS
+	select BR2_PACKAGE_PIXMAN
+	select BR2_PACKAGE_PROCPS_NG
+	select BR2_PACKAGE_ZLIB
+	help
+	  IGT GPU Tools is a collection of tools for development and
+	  testing of the DRM drivers.
+
+	  https://cgit.freedesktop.org/drm/igt-gpu-tools/
+
+comment "igt-gpu-tools needs udev /dev management and openssl library"
+        depends on !BR2_PACKAGE_IGT_GPU_TOOLS
+        depends on !BR2_PACKAGE_HAS_UDEV || !BR2_PACKAGE_HAS_OPENSSL
package/igt-gpu-tools/igt-gpu-tools.hash new file +5 -0
new file mode 100644
index 0000000000..ce27785256
@@ -0,0 +1,5 @@
+# Locally calculated from download
+sha256 df862d0053930f284a28906986f788fb28ee83216d14cf79265e190fcd97d17c  igt-gpu-tools-1.23.tar.gz
+
+# Hash for license file:
+sha256 8aa4d63ef4c018d0dd0e81cef38444eefea9ea11fe7dc488d0e48092bedfaa9a  COPYING
package/igt-gpu-tools/igt-gpu-tools.mk new file +16 -0
new file mode 100644
index 0000000000..fbd18b2d77
@@ -0,0 +1,16 @@
+################################################################################
+#
+# igt-gpu-tools 
+#
+################################################################################
+
+IGT_GPU_TOOLS_VERSION = 1.23
+IGT_GPU_TOOLS_SITE = https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/archive/igt-gpu-tools-$(IGT_GPU_TOOLS_VERSION)
+IGT_GPU_TOOLS_LICENSE = MIT
+IGT_GPU_TOOLS_LICENSE_FILES = COPYING
+IGT_GPU_TOOLS_INSTALL_STAGING = YES
+IGT_GPU_TOOLS_DEPENDENCIES = host-pkgconf cairo kmod libdrm libopenssl libglib2 libpciaccess libunwind pixman procps-ng zlib
+
+IGT_GPU_TOOLS_CONF_OPTS += -Dbuild_docs=false
+
+$(eval $(meson-package))
Signature · 1 line
2.19.2
#1 lore raw

PATCH 1/1 igt-gpu-tools: add new package

All,

I am responding to myself :/

Quoted 9 lines · Ga?l PORTAY
package/igt-gpu-tools/Config.in new file +3 -0
new file mode 100644
index 0000000000..73e217e93c
@@ -0,0 +1,27 @@
+config BR2_PACKAGE_IGT_GPU_TOOLS
+	bool "igt-gpu-tools"
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm libunwind

package/igt-gpu-tools/Config.in line 13

Quoted 10 lines
package/igt-gpu-tools/Config.in new file +10 -0
+	depends on !BR2_STATIC_LIBS # kmod libunwind
+	depends on BR2_USE_MMU # procps-ng
+	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # procps-ng
+	depends on BR2_PACKAGE_HAS_OPENSSL
+	depends on BR2_PACKAGE_HAS_UDEV
+	depends on BR2_PACKAGE_LIBUNWIND_ARCH_SUPPORTS # libunwind
+	select BR2_PACKAGE_CAIRO
+	select BR2_PACKAGE_CAIRO_PNG
+	select BR2_PACKAGE_KMOD
+	select BR2_PACKAGE_LIBDRM

select BR2_PACKAGE_LIBGLIB2 appears to be missing here.

package/igt-gpu-tools/Config.in line 15

Quoted 2 lines
package/igt-gpu-tools/Config.in new file +2 -0
+	select BR2_PACKAGE_LIBUNWIND
+	select BR2_PACKAGE_LIBPCIACCESS

The two selects above are not properly alphabetically sorted.

package/igt-gpu-tools/Config.in line 27

Quoted 12 lines
package/igt-gpu-tools/Config.in new file +12 -0
+	select BR2_PACKAGE_PIXMAN
+	select BR2_PACKAGE_PROCPS_NG
+	select BR2_PACKAGE_ZLIB
+	help
+	  IGT GPU Tools is a collection of tools for development and
+	  testing of the DRM drivers.
+
+	  https://cgit.freedesktop.org/drm/igt-gpu-tools/
+
+comment "igt-gpu-tools needs udev /dev management and openssl library"
+        depends on !BR2_PACKAGE_IGT_GPU_TOOLS
+        depends on !BR2_PACKAGE_HAS_UDEV || !BR2_PACKAGE_HAS_OPENSSL

Regards,
Gael

#2 lore raw

PATCH 1/1 igt-gpu-tools: add new package

In reply to Gaël PORTAY

Hi Ga?l,

Sorry it took so long to get feedback on this...

On 04/12/2018 03:27, Ga?l PORTAY wrote:
[snip]

package/igt-gpu-tools/Config.in line 3

Quoted 3 lines
package/igt-gpu-tools/Config.in new file +3 -0
+config BR2_PACKAGE_IGT_GPU_TOOLS
+	bool "igt-gpu-tools"
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm libunwind

Please separate with commas: libdrm, libglib2, libunwind

package/igt-gpu-tools/Config.in line 4

Quoted 1 line
package/igt-gpu-tools/Config.in new file +1 -0
+	depends on !BR2_STATIC_LIBS # kmod libunwind

BR2_STATIC_LIBS sorts before BR2_TOOLCHAIN_HAS_THREADS :-)

You'll also need to add:

depends on BR2_USE_WCHAR # libglib2 -> gettext

However, the README says that libglib2 is optional (only for chamelium support,
whatever that may be).

package/igt-gpu-tools/Config.in line 5

Quoted 1 line
package/igt-gpu-tools/Config.in new file +1 -0
+	depends on BR2_USE_MMU # procps-ng

This is considered an arch dependency so it should be first.

package/igt-gpu-tools/Config.in line 6

Quoted 1 line
package/igt-gpu-tools/Config.in new file +1 -0
+	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # procps-ng

We use select for that instead of depends. Cfr. tovid.

package/igt-gpu-tools/Config.in line 7

Quoted 1 line
package/igt-gpu-tools/Config.in new file +1 -0
+	depends on BR2_PACKAGE_HAS_OPENSSL

It is possible to select openssl because there's a choice for libopenssl/libressl.

package/igt-gpu-tools/Config.in line 8

Quoted 1 line
package/igt-gpu-tools/Config.in new file +1 -0
+	depends on BR2_PACKAGE_HAS_UDEV

It is strange that you have this dependency here, but not in .mk. Could you
explain that in the commit message? Or maybe add "# runtime" here? Or add the dependency in .mk, of course :-)

package/igt-gpu-tools/Config.in line 9

Quoted 1 line
package/igt-gpu-tools/Config.in new file +1 -0
+	depends on BR2_PACKAGE_LIBUNWIND_ARCH_SUPPORTS # libunwind

This is also an arch dependency so should be first.

Quoted 4 lines
package/igt-gpu-tools/Config.in new file +4 -0
+	select BR2_PACKAGE_CAIRO
+	select BR2_PACKAGE_CAIRO_PNG
+	select BR2_PACKAGE_KMOD
+	select BR2_PACKAGE_LIBDRM

package/igt-gpu-tools/Config.in line 23

Quoted 10 lines
package/igt-gpu-tools/Config.in new file +10 -0
+	select BR2_PACKAGE_LIBUNWIND
+	select BR2_PACKAGE_LIBPCIACCESS
+	select BR2_PACKAGE_PIXMAN
+	select BR2_PACKAGE_PROCPS_NG
+	select BR2_PACKAGE_ZLIB
+	help
+	  IGT GPU Tools is a collection of tools for development and
+	  testing of the DRM drivers.
+
+	  https://cgit.freedesktop.org/drm/igt-gpu-tools/

This is now https://gitlab.freedesktop.org/drm/igt-gpu-tools

package/igt-gpu-tools/Config.in line 27

Quoted 4 lines
package/igt-gpu-tools/Config.in new file +4 -0
+
+comment "igt-gpu-tools needs udev /dev management and openssl library"
+        depends on !BR2_PACKAGE_IGT_GPU_TOOLS
+        depends on !BR2_PACKAGE_HAS_UDEV || !BR2_PACKAGE_HAS_OPENSSL

This is completely wrong. It should be

comment "igt-gpu-tools needs udev /dev management and a toolchain w/ threads, wchar, dynamic library"

	depends on BR2_PACKAGE_LIBUNWIND_ARCH_SUPPORTS
	depends on BR2_USE_MMU
	depends on !BR2_PACKAGE_HAS_UDEV || BR2_STATIC_LIBS || \
		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
Quoted 1 line

+IGT_GPU_TOOLS_VERSION = 1.23

There's a 1.24 now (not surprising, when we wait 9 months to look at this patch :-)

Quoted 1 line

+IGT_GPU_TOOLS_SITE = https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/archive/igt-gpu-tools-$(IGT_GPU_TOOLS_VERSION)

So you did know about the gitlab site!

Note that this will be the first package that uses the auto-archive feature of
gitlab. Let's see how that goes...

Oh, I would also add

IGT_GPU_TOOLS_SOURCE = igt-gpu-tools-$(IGT_GPU_TOOLS_VERSION).tar.bz2

which should be a bit smaller.

package/igt-gpu-tools/igt-gpu-tools.mk line 11

Quoted 3 lines
package/igt-gpu-tools/igt-gpu-tools.mk new file +3 -0
+IGT_GPU_TOOLS_LICENSE = MIT
+IGT_GPU_TOOLS_LICENSE_FILES = COPYING
+IGT_GPU_TOOLS_INSTALL_STAGING = YES

Why install in staging?

Quoted 1 line

+IGT_GPU_TOOLS_DEPENDENCIES = host-pkgconf cairo kmod libdrm libopenssl libglib2 libpciaccess libunwind pixman procps-ng zlib

Does it really need libopenssl and not libressl?

If yes, you should select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL.

Obviously, I've marked this patch as Changes Requested :-)

Thanks!

Regards,
Arnout

Quoted 4 lines
package/igt-gpu-tools/igt-gpu-tools.mk new file +3 -0
+IGT_GPU_TOOLS_CONF_OPTS += -Dbuild_docs=false
+
+$(eval $(meson-package))
#3 lore raw

PATCH 1/1 igt-gpu-tools: add new package

Hi Arnout,

Quoted 118 lines · Arnout Vandecappelle

Hi Ga?l,

Sorry it took so long to get feedback on this...

On 04/12/2018 03:27, Ga?l PORTAY wrote:
[snip]

package/igt-gpu-tools/Config.in line 3

Quoted 3 lines
package/igt-gpu-tools/Config.in new file +3 -0
+config BR2_PACKAGE_IGT_GPU_TOOLS
+	bool "igt-gpu-tools"
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm libunwind

Please separate with commas: libdrm, libglib2, libunwind

package/igt-gpu-tools/Config.in line 4

Quoted 1 line
package/igt-gpu-tools/Config.in new file +1 -0
+	depends on !BR2_STATIC_LIBS # kmod libunwind

BR2_STATIC_LIBS sorts before BR2_TOOLCHAIN_HAS_THREADS :-)

You'll also need to add:

depends on BR2_USE_WCHAR # libglib2 -> gettext

However, the README says that libglib2 is optional (only for chamelium support,
whatever that may be).

package/igt-gpu-tools/Config.in line 5

Quoted 1 line
package/igt-gpu-tools/Config.in new file +1 -0
+	depends on BR2_USE_MMU # procps-ng

This is considered an arch dependency so it should be first.

package/igt-gpu-tools/Config.in line 6

Quoted 1 line
package/igt-gpu-tools/Config.in new file +1 -0
+	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # procps-ng

We use select for that instead of depends. Cfr. tovid.

package/igt-gpu-tools/Config.in line 7

Quoted 1 line
package/igt-gpu-tools/Config.in new file +1 -0
+	depends on BR2_PACKAGE_HAS_OPENSSL

It is possible to select openssl because there's a choice for libopenssl/libressl.

package/igt-gpu-tools/Config.in line 8

Quoted 1 line
package/igt-gpu-tools/Config.in new file +1 -0
+	depends on BR2_PACKAGE_HAS_UDEV

It is strange that you have this dependency here, but not in .mk. Could you
explain that in the commit message? Or maybe add "# runtime" here? Or add the dependency in .mk, of course :-)

package/igt-gpu-tools/Config.in line 9

Quoted 1 line
package/igt-gpu-tools/Config.in new file +1 -0
+	depends on BR2_PACKAGE_LIBUNWIND_ARCH_SUPPORTS # libunwind

This is also an arch dependency so should be first.

Quoted 4 lines
package/igt-gpu-tools/Config.in new file +4 -0
+	select BR2_PACKAGE_CAIRO
+	select BR2_PACKAGE_CAIRO_PNG
+	select BR2_PACKAGE_KMOD
+	select BR2_PACKAGE_LIBDRM

package/igt-gpu-tools/Config.in line 23

Quoted 10 lines
package/igt-gpu-tools/Config.in new file +10 -0
+	select BR2_PACKAGE_LIBUNWIND
+	select BR2_PACKAGE_LIBPCIACCESS
+	select BR2_PACKAGE_PIXMAN
+	select BR2_PACKAGE_PROCPS_NG
+	select BR2_PACKAGE_ZLIB
+	help
+	  IGT GPU Tools is a collection of tools for development and
+	  testing of the DRM drivers.
+
+	  https://cgit.freedesktop.org/drm/igt-gpu-tools/

This is now https://gitlab.freedesktop.org/drm/igt-gpu-tools

package/igt-gpu-tools/Config.in line 27

Quoted 4 lines
package/igt-gpu-tools/Config.in new file +4 -0
+
+comment "igt-gpu-tools needs udev /dev management and openssl library"
+        depends on !BR2_PACKAGE_IGT_GPU_TOOLS
+        depends on !BR2_PACKAGE_HAS_UDEV || !BR2_PACKAGE_HAS_OPENSSL

This is completely wrong. It should be

comment "igt-gpu-tools needs udev /dev management and a toolchain w/ threads, wchar, dynamic library"

	depends on BR2_PACKAGE_LIBUNWIND_ARCH_SUPPORTS
	depends on BR2_USE_MMU
	depends on !BR2_PACKAGE_HAS_UDEV || BR2_STATIC_LIBS || \
		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
Quoted 1 line

+IGT_GPU_TOOLS_VERSION = 1.23

There's a 1.24 now (not surprising, when we wait 9 months to look at this patch :-)

Quoted 1 line

+IGT_GPU_TOOLS_SITE = https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/archive/igt-gpu-tools-$(IGT_GPU_TOOLS_VERSION)

So you did know about the gitlab site!

Note that this will be the first package that uses the auto-archive feature of
gitlab. Let's see how that goes...

Oh, I would also add

IGT_GPU_TOOLS_SOURCE = igt-gpu-tools-$(IGT_GPU_TOOLS_VERSION).tar.bz2

which should be a bit smaller.

package/igt-gpu-tools/igt-gpu-tools.mk line 11

Quoted 3 lines
package/igt-gpu-tools/igt-gpu-tools.mk new file +3 -0
+IGT_GPU_TOOLS_LICENSE = MIT
+IGT_GPU_TOOLS_LICENSE_FILES = COPYING
+IGT_GPU_TOOLS_INSTALL_STAGING = YES

Why install in staging?

Quoted 1 line

+IGT_GPU_TOOLS_DEPENDENCIES = host-pkgconf cairo kmod libdrm libopenssl libglib2 libpciaccess libunwind pixman procps-ng zlib

Does it really need libopenssl and not libressl?

If yes, you should select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL.

Obviously, I've marked this patch as Changes Requested :-)

Thanks!

Regards,
Arnout

Quoted 8 lines

package/igt-gpu-tools/igt-gpu-tools.mk line 16

Quoted 4 lines
package/igt-gpu-tools/igt-gpu-tools.mk new file +3 -0
+IGT_GPU_TOOLS_CONF_OPTS += -Dbuild_docs=false
+
+$(eval $(meson-package))

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Thanks for you review. I will address them ASAP.

Regards,
Gael