Skip to contentSkip to conversation

tpm/tpm_ftpm_tee: trivial checkpatch fixes

PATCH In review Sasha Levin 3 participants 5 messages Aug 13, 2019 – Aug 19, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tpm/tpm_ftpm_tee: trivial checkpatch fixes

Fixes a few checkpatch warnings (and ignores some), mostly around spaces/tabs and documentation.

---
 Documentation/devicetree/bindings/vendor-prefixes.yaml |  2 ++
 drivers/char/tpm/Kconfig                               |  2 +-
 drivers/char/tpm/tpm_ftpm_tee.c                        | 10 +++++-----
 3 files changed, 8 insertions(+), 6 deletions(-)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
index 6992bbbbffab6..d61a203138cbe 100644
@@ -575,6 +575,8 @@ patternProperties:
     description: Micro Crystal AG
   "^micron,.*":
     description: Micron Technology Inc.
+  "^microsoft,.*":
+    description: Microsoft Corporation
   "^mikroe,.*":
     description: MikroElektronika d.o.o.
   "^miniand,.*":
drivers/char/tpm/Kconfig +1 -1
index 17bfbf9f572fc..9c37047f4b562 100644
@@ -167,7 +167,7 @@ config TCG_VTPM_PROXY
 config TCG_FTPM_TEE
 	tristate "TEE based fTPM Interface"
 	depends on TEE && OPTEE
-	---help---
+	help
 	  This driver proxies for firmware TPM running in TEE.
 
 source "drivers/char/tpm/st33zp24/Kconfig"
drivers/char/tpm/tpm_ftpm_tee.c +5 -5
index 5679a5af9a96a..6640a14dbe48c 100644
@@ -38,7 +38,7 @@ static const uuid_t ftpm_ta_uuid =
  * @count:	the number of bytes to read.
  *
  * Return:
- * 	In case of success the number of bytes received.
+ *	In case of success the number of bytes received.
  *	On failure, -errno.
  */
 static int ftpm_tee_tpm_op_recv(struct tpm_chip *chip, u8 *buf, size_t count)
@@ -67,7 +67,7 @@ static int ftpm_tee_tpm_op_recv(struct tpm_chip *chip, u8 *buf, size_t count)
  * @len:	the number of bytes to send.
  *
  * Return:
- * 	In case of success, returns 0.
+ *	In case of success, returns 0.
  *	On failure, -errno
  */
 static int ftpm_tee_tpm_op_send(struct tpm_chip *chip, u8 *buf, size_t len)
@@ -212,7 +212,7 @@ static int ftpm_tee_match(struct tee_ioctl_version_data *ver, const void *data)
  * @pdev: the platform_device description.
  *
  * Return:
- * 	On success, 0. On failure, -errno.
+ *	On success, 0. On failure, -errno.
  */
 static int ftpm_tee_probe(struct platform_device *pdev)
 {
@@ -302,7 +302,7 @@ static int ftpm_tee_probe(struct platform_device *pdev)
  * @pdev: the platform_device description.
  *
  * Return:
- * 	0 always.
+ *	0 always.
  */
 static int ftpm_tee_remove(struct platform_device *pdev)
 {
@@ -323,7 +323,7 @@ static int ftpm_tee_remove(struct platform_device *pdev)
 	/* close the context with TEE driver */
 	tee_client_close_context(pvt_data->ctx);
 
-        /* memory allocated with devm_kzalloc() is freed automatically */
+	/* memory allocated with devm_kzalloc() is freed automatically */
 
 	return 0;
 }
Signature · 1 line
2.20.1
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Sasha Levin

Fixes a few checkpatch warnings (and ignores some), mostly around spaces/tabs and documentation.

---
 Documentation/devicetree/bindings/vendor-prefixes.yaml |  2 ++
Quoted 2 lines
 drivers/char/tpm/tpm_ftpm_tee.c                        | 10 +++++-----
 3 files changed, 8 insertions(+), 6 deletions(-)
#4 lore raw
Quoted 11 lines · Jarkko Sakkinen
Quoted 4 lines · Sasha Levin

Fixes a few checkpatch warnings (and ignores some), mostly around spaces/tabs and documentation.

Thank you!

I'll squash these to the existing patches.

Oops, replied this twice, sorry :-)

Anyway, I pushed the patch. I think I just keep it as separate after all.

/Jarkko