Skip to contentSkip to conversation

devicetree: Expose dtbs_check and dt_binding_check some more

PATCH In review Stephen Boyd 2 participants 3 messages Aug 13, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 devicetree: Expose dtbs_check and dt_binding_check some more

It wasn't obvious that this was a command to run based on 'make help', so add it to the top-level help for devicetree builds. Also, add an example to the documentation to show that db_binding_check can be run with DT_SCHEMA_FILES= to only check one schema file instead of all of them.

---

I didn't find this sent, so sending again!

 Documentation/devicetree/writing-schema.md | 1 +
 Makefile                                   | 6 ++++--
 2 files changed, 5 insertions(+), 2 deletions(-)
Documentation/devicetree/writing-schema.md +1 -0
index dc032db36262..17ad67887fde 100644
@@ -120,6 +120,7 @@ This will first run the `dt_binding_check` which generates the processed schema.
 It is also possible to run checks with a single schema file by setting the
 'DT_SCHEMA_FILES' variable to a specific schema file.
 
+`make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/trivial-devices.yaml`
 `make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/trivial-devices.yaml`
 
 
Makefile +4 -2
index 9be5834073f8..96bb28aa1c46 100644
@@ -1503,8 +1503,10 @@ help:
 	@echo  ''
 	@$(if $(dtstree), \
 		echo 'Devicetree:'; \
-		echo '* dtbs            - Build device tree blobs for enabled boards'; \
-		echo '  dtbs_install    - Install dtbs to $(INSTALL_DTBS_PATH)'; \
+		echo '* dtbs             - Build device tree blobs for enabled boards'; \
+		echo '  dtbs_install     - Install dtbs to $(INSTALL_DTBS_PATH)'; \
+		echo '  dt_binding_check - Validate device tree binding documents'; \
+		echo '  dtbs_check       - Validate device tree source files';\
 		echo '')
 
 	@echo 'Userspace tools targets:'
Signature · 1 line
Sent by a computer through tubes
#1 lore raw
Quoted 7 lines · Stephen Boyd

It wasn't obvious that this was a command to run based on 'make help', so add it to the top-level help for devicetree builds. Also, add an example to the documentation to show that db_binding_check can be run with DT_SCHEMA_FILES= to only check one schema file instead of all of them.

Quoted 8 lines

---

I didn't find this sent, so sending again!

You had. :)

Quoted 4 lines
 Documentation/devicetree/writing-schema.md | 1 +
 Makefile                                   | 6 ++++--
 2 files changed, 5 insertions(+), 2 deletions(-)

writing-schema.md got converted to rst, so I fixed up and applied.

Rob

#2 lore raw

Quoting Rob Herring (2019-08-13 15:32:48)

Quoted 15 lines · Stephen Boyd
Quoted 14 lines

It wasn't obvious that this was a command to run based on 'make help', so add it to the top-level help for devicetree builds. Also, add an example to the documentation to show that db_binding_check can be run with DT_SCHEMA_FILES= to only check one schema file instead of all of them.

---

Quoted 3 lines
Quoted 1 line

I didn't find this sent, so sending again!

You had. :)

Oh no, sorry! :(

Quoted 7 lines
Quoted 5 lines

 Documentation/devicetree/writing-schema.md | 1 +
 Makefile                                   | 6 ++++--
 2 files changed, 5 insertions(+), 2 deletions(-)

writing-schema.md got converted to rst, so I fixed up and applied.

Thanks!