support/testing: new test for root password
PATCH v3 1/1 support/testing: new test for root password
Add support to test that the root passowrd is working as expected.
- Buildtime test: Check the hash present in the generated '/etc/shadow'.
- Runtime test: Build an armv7 image and try to login with a password.
---
Changes:
v1 --> v2:
- Fix coding style to pass flake8 test
v2 --> v3:
- Add 'BR2_TARGET_ROOTFS_CPIO=y' to the .config
- Add myself as developer for this test
- Fix a typo 'has' --> 'hash'
- Use assertEqual(a, b) instead of assertTrue(a == b)
- Update .gitlab-ci.yml
--- .gitlab-ci.yml | 1 + DEVELOPERS | 3 ++ .../testing/tests/core/test_root_password.py | 36 +++++++++++++++++++ 3 files changed, 40 insertions(+) create mode 100644 support/testing/tests/core/test_root_password.py
.gitlab-ci.yml +1 -0
@@ -340,6 +340,7 @@ tests.core.test_hardening.TestRelroPartial: { extends: .runtime_test } tests.core.test_hardening.TestSspNone: { extends: .runtime_test } tests.core.test_hardening.TestSspStrong: { extends: .runtime_test } tests.core.test_post_scripts.TestPostScripts: { extends: .runtime_test } +tests.core.test_root_password.TestRootPassword: { extends: .runtime_test } tests.core.test_rootfs_overlay.TestRootfsOverlay: { extends: .runtime_test } tests.core.test_timezone.TestGlibcAllTimezone: { extends: .runtime_test } tests.core.test_timezone.TestGlibcNonDefaultLimitedTimezone: { extends: .runtime_test }
DEVELOPERS +3 -0
@@ -2332,6 +2332,9 @@ F: package/llvm/ N: Vanya Sergeev <[email protected]> F: package/lua-periphery/ +N: Victor Huesca <[email protected]> +F: support/testing/tests/core/test_root_password.py + N: Vincent Prince <[email protected]> F: package/nss-myhostname/ F: package/utp_com/
support/testing/tests/core/test_root_password.py new file +36 -0
@@ -0,0 +1,36 @@ +import os +import infra.basetest +from crypt import crypt + + +class TestRootPassword(infra.basetest.BRTest): + password = "foo" + config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \ + """ + BR2_TARGET_ROOTFS_CPIO=y + BR2_TARGET_ENABLE_ROOT_LOGIN=y + BR2_TARGET_GENERIC_ROOT_PASSWD="{}" + """.format(password) + + def test_run(self): + # 1. Test by looking hash in the /etc/shadow + shadow = os.path.join(self.builddir, "target", "etc", "shadow") + with open(shadow, "r") as f: + users = f.readlines() + for user in users: + s = user.split(":") + n, h = s[0], s[1] + if n == "root": + # Fail if the account is disabled or no password is required + self.assertTrue(h not in ["", "*"]) + # Fail if the hash isn't right + self.assertEqual(crypt(self.password, h), h) + + # 2. Test by attempting to login + cpio_file = os.path.join(self.builddir, "images", "rootfs.cpio") + try: + self.emulator.boot(arch="armv7", kernel="builtin", + options=["-initrd", cpio_file]) + self.emulator.login(self.password) + except SystemError: + self.fail("Unable to login with the password")
Signature · 1 line
2.21.0
Thomas Petazzoni
AppliedPATCH v3 1/1 support/testing: new test for root password
Quoted 15 lines · On Tue, 13 Aug 2019 09:33:20 +0200 Victor Huesca <[email protected]>…
Add support to test that the root passowrd is working as expected.
- Buildtime test: Check the hash present in the generated '/etc/shadow'.
- Runtime test: Build an armv7 image and try to login with a password.Signed-off-by Victor Huesca <[email protected]>---
Changes:
v1 --> v2:
- Fix coding style to pass flake8 test
v2 --> v3:
- Add 'BR2_TARGET_ROOTFS_CPIO=y' to the .config
- Add myself as developer for this test
- Fix a typo 'has' --> 'hash'
- UseassertEqual(a, b)instead of assertTrue(a == b)
- Update .gitlab-ci.yml
Quoted 6 lines
--- .gitlab-ci.yml | 1 + DEVELOPERS | 3 ++ .../testing/tests/core/test_root_password.py | 36 +++++++++++++++++++ 3 files changed, 40 insertions(+) create mode 100644 support/testing/tests/core/test_root_password.py
Applied to next, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com