dt-bindings: clock: Document SM8150 rpmh-clock compatible
PATCH 1/2 dt-bindings: clock: Document SM8150 rpmh-clock compatible
Document the SM8150 rpmh-clock compatible for rpmh clock controller found on SM8150 platforms.
--- Documentation/devicetree/bindings/clock/qcom,rpmh-clk.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/clock/qcom,rpmh-clk.txt +3 -1
@@ -6,7 +6,9 @@ some Qualcomm Technologies Inc. SoCs. It accepts clock requests from other hardware subsystems via RSC to control clocks. Required properties : -- compatible : shall contain "qcom,sdm845-rpmh-clk" +- compatible : must be one of: + "qcom,sdm845-rpmh-clk" + "qcom,sm8150-rpmh-clk" - #clock-cells : must contain 1
Signature · 1 line
2.20.1
PATCH 2/2 clk: qcom: clk-rpmh: Add support for SM8150
Add support for rpmh clocks found in SM8150
--- drivers/clk/qcom/clk-rpmh.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+)
drivers/clk/qcom/clk-rpmh.c +27 -0
@@ -368,6 +368,32 @@ static const struct clk_rpmh_desc clk_rpmh_sdm845 = { .num_clks = ARRAY_SIZE(sdm845_rpmh_clocks), }; +DEFINE_CLK_RPMH_ARC (sm8150, bi_tcxo, bi_tcxo_ao,"xo.lvl" ,0x3 ,2 ); +DEFINE_CLK_RPMH_VRM (sm8150, ln_bb_clk2, ln_bb_clk2_ao,"lnbclka2" ,2 ); +DEFINE_CLK_RPMH_VRM (sm8150, ln_bb_clk3, ln_bb_clk3_ao,"lnbclka3" ,2 ); +DEFINE_CLK_RPMH_VRM (sm8150, rf_clk1, rf_clk1_ao,"rfclka1" ,1 ); +DEFINE_CLK_RPMH_VRM (sm8150, rf_clk2, rf_clk2_ao,"rfclka2" ,1 ); +DEFINE_CLK_RPMH_VRM (sm8150, rf_clk3, rf_clk3_ao,"rfclka3" ,1 ); + +static struct clk_hw *sm8150_rpmh_clocks[] = { + [RPMH_CXO_CLK ] = &sm8150_bi_tcxo.hw, + [RPMH_CXO_CLK_A ] = &sm8150_bi_tcxo_ao.hw, + [RPMH_LN_BB_CLK2 ] = &sm8150_ln_bb_clk2.hw, + [RPMH_LN_BB_CLK2_A ] = &sm8150_ln_bb_clk2_ao.hw, + [RPMH_LN_BB_CLK3 ] = &sm8150_ln_bb_clk3.hw, + [RPMH_LN_BB_CLK3_A ] = &sm8150_ln_bb_clk3_ao.hw, + [RPMH_RF_CLK1 ] = &sm8150_rf_clk1.hw, + [RPMH_RF_CLK1_A ] = &sm8150_rf_clk1_ao.hw, + [RPMH_RF_CLK2 ] = &sm8150_rf_clk2.hw, + [RPMH_RF_CLK2_A ] = &sm8150_rf_clk2_ao.hw, + [RPMH_RF_CLK3 ] = &sm8150_rf_clk3.hw, + [RPMH_RF_CLK3_A ] = &sm8150_rf_clk3_ao.hw, +}; + +static const struct clk_rpmh_desc clk_rpmh_sm8150 = { + .clks = sm8150_rpmh_clocks, + .num_clks =ARRAY_SIZE (sm8150_rpmh_clocks), +};static struct clk_hw *of_clk_rpmh_hw_get (struct of_phandle_args *clkspec,void *data) {
@@ -447,6 +473,7 @@ static int clk_rpmh_probe(struct platform_device *pdev)static const struct of_device_id clk_rpmh_match_table[] = { { .compatible ="qcom,sdm845-rpmh-clk" , .data = &clk_rpmh_sdm845}, + { .compatible ="qcom,sm8150-rpmh-clk" , .data = &clk_rpmh_sm8150}, { } };MODULE_DEVICE_TABLE (of, clk_rpmh_match_table);
Signature · 1 line
2.20.1
Stephen Boyd
maintainerRe: [PATCH 2/2] clk: qcom: clk-rpmh: Add support for SM8150
Quoting Vinod Koul (2019-08-14 05:29:58)
Quoted 4 lines
Add support for rpmh clocks found in SM8150
Signed-off-by Vinod Koul <[email protected]>---
Patch looks OK, but can you convert this driver to use the new parent style and then update the binding to handle it? We can fix the other platforms and dts files that use this driver in parallel, but sm8150 will be forward looking.
Re: [PATCH 2/2] clk: qcom: clk-rpmh: Add support for SM8150
Quoted 10 lines · Stephen Boyd
Quoting Vinod Koul (2019-08-14 05:29:58)
Quoted 4 lines
Add support for rpmh clocks found in SM8150
Signed-off-by Vinod Koul <[email protected]>---
Patch looks OK, but can you convert this driver to use the new parent style and then update the binding to handle it? We can fix the other platforms and dts files that use this driver in parallel, but sm8150 will be forward looking.
Yes but that would also impact sdm845 as it uses this driver, so I wanted to get this one done so that we have support for rpm clock and then do the conversion.
Would that be okay with you to get this in and then I convert this?
Thanks
Signature · 1 line
~Vinod
Stephen Boyd
maintainerRe: [PATCH 2/2] clk: qcom: clk-rpmh: Add support for SM8150
Quoting Vinod Koul (2019-08-15 21:24:40)
Quoted 12 lines · Stephen Boyd
Quoted 10 lines
Quoting Vinod Koul (2019-08-14 05:29:58)
Quoted 4 lines
Add support for rpmh clocks found in SM8150
Signed-off-by Vinod Koul <[email protected]>---
Patch looks OK, but can you convert this driver to use the new parent style and then update the binding to handle it? We can fix the other platforms and dts files that use this driver in parallel, but sm8150 will be forward looking.
Quoted 6 lines
Yes but that would also impact sdm845 as it uses this driver, so I wanted to get this one done so that we have support for rpm clock and then do the conversion.
Would that be okay with you to get this in and then I convert this?
How does it impact sdm845? The new way of specifying parents supports fallback to legacy string matching.
Re: [PATCH 2/2] clk: qcom: clk-rpmh: Add support for SM8150
Quoted 17 lines · Stephen Boyd
Quoting Vinod Koul (2019-08-15 21:24:40)
Quoted 16 lines · Stephen Boyd
Quoted 10 lines
Quoting Vinod Koul (2019-08-14 05:29:58)
Quoted 4 lines
Add support for rpmh clocks found in SM8150
Signed-off-by Vinod Koul <[email protected]>---
Patch looks OK, but can you convert this driver to use the new parent style and then update the binding to handle it? We can fix the other platforms and dts files that use this driver in parallel, but sm8150 will be forward looking.
Yes but that would also impact sdm845 as it uses this driver, so I wanted to get this one done so that we have support for rpm clock and then do the conversion.
Quoted 5 lines
Quoted 2 lines
Would that be okay with you to get this in and then I convert this?
How does it impact sdm845? The new way of specifying parents supports fallback to legacy string matching.
Yes it does, I have managed to convert this as well as sdm845 and test. I will send updates shortly
Thanks
Signature · 1 line
~Vinod
Stephen Boyd
maintainerQuoting Vinod Koul (2019-08-14 05:29:57)
Quoted 13 lines
Document the SM8150 rpmh-clock compatible for rpmh clock controller found on SM8150 platforms.
Signed-off-by Vinod Koul <[email protected]>--- Documentation/devicetree/bindings/clock/qcom,rpmh-clk.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/clock/qcom,rpmh-clk.txt +0
-0
Documentation/devicetree/bindings/clock/qcom,rpmh-clk.txt some Qualcomm Technologies Inc. SoCs. It accepts clock requests from · line 12
Quoted 8 lines
Documentation/devicetree/bindings/clock/qcom,rpmh-clk.txt +3
-1@@ -6,7 +6,9 @@ some Qualcomm Technologies Inc. SoCs. It accepts clock requests from other hardware subsystems via RSC to control clocks. Required properties : -- compatible : shall contain "qcom,sdm845-rpmh-clk" +- compatible : must be one of: + "qcom,sdm845-rpmh-clk" + "qcom,sm8150-rpmh-clk"
Can it take a 'clocks' property to get the board clock?