package/devmem2: remove package
PATCH v2 1/1 package/devmem2: remove package
From: Carlos Santos <[email protected]>
It was here just for backwards compatibility and is not used by any package or board after commits
59856480b6 packages/devmem2: remove from all board configurations 2f6e3eae55 package/ti-gfx: do not use devmem2 in script
There are address casting issues with 32bit access on a 64bit bus (like on the SoC FPGA ARM processors) with this tool. The Busybox version of devmem is the most up to date and supports quadword access.
---
CC: Ciro Santilli <[email protected]>
CC: Matt Weber <[email protected]>
CC: Thomas Petazzoni <[email protected]>
---
Changes v1->v2: removed spurious "address" from commit message
--- Config.in.legacy | 7 +++ .../0001-be-coherent-in-type-usage.patch | 52 ------------------- package/devmem2/Config.in | 7 --- package/devmem2/devmem2.hash | 3 -- package/devmem2/devmem2.mk | 30 ----------- 5 files changed, 7 insertions(+), 92 deletions(-) delete mode 100644 package/devmem2/0001-be-coherent-in-type-usage.patch delete mode 100644 package/devmem2/Config.in delete mode 100644 package/devmem2/devmem2.hash delete mode 100644 package/devmem2/devmem2.mk
Config.in.legacy +7 -0
@@ -146,6 +146,13 @@ endif comment "Legacy options removed in 2019.08" +config BR2_PACKAGE_DEVMEM2 + bool "devmem2 package was removed" + select BR2_LEGACY + help + Use the the Busybox devmem utility, instead, which provides + the same functionality. + config BR2_PACKAGE_LIBAMCODEC bool "liamcodec package was removed" select BR2_LEGACY
package/devmem2/0001-be-coherent-in-type-usage.patch deleted +0 -52
52 lines not on this page · raw message
package/devmem2/Config.in deleted +0 -7
@@ -1,7 +0,0 @@ -config BR2_PACKAGE_DEVMEM2 - bool "devmem2" - depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS - help - Simple program to read/write from/to any location in memory. - - http://bootlin.com/pub/mirror/devmem2.c
package/devmem2/devmem2.hash deleted +0 -3
@@ -1,3 +0,0 @@ -# Locally calculated -sha256 3b15515693bae1ebd14d914e46d388edfec2175829ea1576a7a0c8606ebbe639 devmem2.c -sha256 560913d09310d446920c16bd0aca1ff21d3b6fedd527195bacfc832ce343e0ae devmem2.c.license
package/devmem2/devmem2.mk deleted +0 -30
@@ -1,30 +0,0 @@ -################################################################################ -# -# devmem2 -# -################################################################################ - -DEVMEM2_SITE = http://bootlin.com/pub/mirror -DEVMEM2_SOURCE = devmem2.c -DEVMEM2_VERSION = 1 -DEVMEM2_LICENSE = GPL-2.0+ -DEVMEM2_LICENSE_FILES = devmem2.c.license - -define DEVMEM2_EXTRACT_CMDS - cp $(DEVMEM2_DL_DIR)/$($(PKG)_SOURCE) $(@D)/ -endef - -define DEVMEM2_EXTRACT_LICENSE - head -n 38 $(@D)/devmem2.c >$(@D)/devmem2.c.license -endef -DEVMEM2_PRE_PATCH_HOOKS += DEVMEM2_EXTRACT_LICENSE - -define DEVMEM2_BUILD_CMDS - $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) devmem2 -endef - -define DEVMEM2_INSTALL_TARGET_CMDS - $(INSTALL) -D $(@D)/devmem2 $(TARGET_DIR)/sbin/devmem2 -endef - -$(eval $(generic-package))
Signature · 1 line
2.18.1
PATCH v2 1/1 package/devmem2: remove package
Hello,
+Peter in Cc.
Quoted 5 lines · On Wed, 14 Aug 2019 07:29:57 -0300 unixmania at gmail.com wrote:
From: Carlos Santos <[email protected]>
It was here just for backwards compatibility and is not used by any package or board after commits
Quoted 8 lines
59856480b6packages/devmem2: remove from all board configurations2f6e3eae55package/ti-gfx: do not use devmem2 in scriptThere are address casting issues with 32bit access on a 64bit bus (like on the SoC FPGA ARM processors) with this tool. The Busybox version of devmem is the most up to date and supports quadword access.
I don't particularly care about devmem2, but it was not here just for "backwards compatibility". It was there also for the cases where people don't want to use Busybox, but still need a devmem implementation. I'm not sure how much this use case is important, though.
Peter, could you take a decision on this ?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 1/1 package/devmem2: remove package
In reply to unixmania at gmail.comHello Carlos,
Quoted 21 lines · On Wed, 14 Aug 2019 07:29:57 -0300 unixmania at gmail.com wrote:
From: Carlos Santos <[email protected]>
It was here just for backwards compatibility and is not used by any package or board after commits
59856480b6packages/devmem2: remove from all board configurations2f6e3eae55package/ti-gfx: do not use devmem2 in scriptThere are address casting issues with 32bit access on a 64bit bus (like on the SoC FPGA ARM processors) with this tool. The Busybox version of devmem is the most up to date and supports quadword access.
Signed-off-by Carlos Santos <[email protected]>---
CC: Ciro Santilli <[email protected]>
CC: Matt Weber <[email protected]>
CC: Thomas Petazzoni <[email protected]>
---
Changesv1->v2: removed spurious "address" from commit message
Quoted 11 lines
--- Config.in.legacy | 7 +++ .../0001-be-coherent-in-type-usage.patch | 52 ------------------- package/devmem2/Config.in | 7 --- package/devmem2/devmem2.hash | 3 -- package/devmem2/devmem2.mk | 30 ----------- 5 files changed, 7 insertions(+), 92 deletions(-) delete mode 100644 package/devmem2/0001-be-coherent-in-type-usage.patch delete mode 100644 package/devmem2/Config.in delete mode 100644 package/devmem2/devmem2.hash delete mode 100644 package/devmem2/devmem2.mk
Since nobody replied to my call for opinions, and I don't particularly care about keeping devmem2 around, I've applied. Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com