Bluetooth: hci_qca: Make structure qca_proto constant
Subsystems (2)
PATCH 1/1 Bluetooth: hci_qca: Make structure qca_proto constant
Static structure qca_proto, of type hci_uart_proto, is used four times:
as the last argument in function hci_uart_register_device(), and as the only argument to functions hci_uart_register_proto() and hci_uart_unregister_proto(). In all three of these functions, the parameter corresponding to qca_proto is declared as constant. Therefore, make qca_proto itself constant as well in order to protect it from unintended modification.
Issue found with Coccinelle.
--- drivers/bluetooth/hci_qca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bluetooth/hci_qca.c +1 -1
@@ -1326,7 +1326,7 @@ static int qca_setup(struct hci_uart *hu)return ret; } -static struct hci_uart_proto qca_proto = { +static const struct hci_uart_proto qca_proto = { .id =HCI_UART_QCA , .name ="QCA" , .manufacturer =29 ,
Signature · 1 line
2.19.1
Marcel Holtmann
maintainerHi Nishka,
Quoted 9 lines
Static structure
qca_proto, of typehci_uart_proto, is used four times:
as the last argument in functionhci_uart_register_device(), and as the only argument to functionshci_uart_register_proto()andhci_uart_unregister_proto(). In all three of these functions, the parameter corresponding toqca_protois declared as constant. Therefore, makeqca_protoitself constant as well in order to protect it from unintended modification.
Issue found with Coccinelle.
Quoted 4 lines
Signed-off-by Nishka Dasgupta <[email protected]>---
drivers/bluetooth/hci_qca.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel