Skip to contentSkip to conversation

i2c: iproc: Make bcm_iproc_i2c_quirks constant

PATCH In review Nishka Dasgupta 2 participants 2 messages Aug 15, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c: iproc: Make bcm_iproc_i2c_quirks constant

Static structure bcm_iproc_i2c_quirks, of type i2c_adapter_quirks, is only used when being assigned to constant field quirks of a variable having type i2c_adapter. Hence make bcm_iproc_i2c_quirks constant as well to prevent it from unintended modification.
Issue found with Coccinelle.

---
 drivers/i2c/busses/i2c-bcm-iproc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-bcm-iproc.c +1 -1
index d7fd76baec92..e9f0e5b6eadc 100644
@@ -805,7 +805,7 @@ static struct i2c_algorithm bcm_iproc_algo = {
 	.unreg_slave = bcm_iproc_i2c_unreg_slave,
 };
 
-static struct i2c_adapter_quirks bcm_iproc_i2c_quirks = {
+static const struct i2c_adapter_quirks bcm_iproc_i2c_quirks = {
 	.max_read_len = M_RX_MAX_READ_LEN,
 };
 
Signature · 1 line
2.19.1
Reviewed-by on v1 1/1
#1 lore raw

Hi Nishka,

Quoted 17 lines · Nishka Dasgupta

Static structure bcm_iproc_i2c_quirks, of type i2c_adapter_quirks, is only used when being assigned to constant field quirks of a variable having type i2c_adapter. Hence make bcm_iproc_i2c_quirks constant as well to prevent it from unintended modification.
Issue found with Coccinelle.

---
  drivers/i2c/busses/i2c-bcm-iproc.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-bcm-iproc.c +0 -0
index d7fd76baec92..e9f0e5b6eadc 100644

drivers/i2c/busses/i2c-bcm-iproc.c static struct i2c_algorithm bcm_iproc_algo = { · line 811

Quoted 8 lines
drivers/i2c/busses/i2c-bcm-iproc.c +1 -1
@@ -805,7 +805,7 @@ static struct i2c_algorithm bcm_iproc_algo = {
  	.unreg_slave = bcm_iproc_i2c_unreg_slave,
  };
 
-static struct i2c_adapter_quirks bcm_iproc_i2c_quirks = {
+static const struct i2c_adapter_quirks bcm_iproc_i2c_quirks = {
  	.max_read_len = M_RX_MAX_READ_LEN,
  };
 

This looks good to me. Thanks!