mtd: spi-nor: hisi-sfc: Add of_node_put() before break
Subsystems (2)
PATCH 1/1 mtd: spi-nor: hisi-sfc: Add of_node_put() before break
Each iteration of for_each_available_child_of_node puts the previous node, but in the case of a break from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the break.
Issue found with Coccinelle.
--- drivers/mtd/spi-nor/hisi-sfc.c | 1 + 1 file changed, 1 insertion(+)
drivers/mtd/spi-nor/hisi-sfc.c +1 -0
@@ -401,6 +401,7 @@ static int hisi_spi_nor_register_all(struct hifmc_host *host)if (host->num_chip ==HIFMC_MAX_CHIP_NUM ) {dev_warn (dev,"Flash device number exceeds the maximum chipselect number\n" ); +of_node_put (np);break ; } }
Signature · 6 lines
2.19.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
[email protected]
AppliedQuoted 9 lines · Nishka Dasgupta
External E-Mail
Each iteration of
for_each_available_child_of_nodeputs the previous node, but in the case of a break from the middle of the loop, there is no put, thus causing a memory leak. Hence add anof_node_putbefore the break.
Issue found with Coccinelle.
Quoted 5 lines
Signed-off-by Nishka Dasgupta <[email protected]>--- drivers/mtd/spi-nor/hisi-sfc.c | 1 + 1 file changed, 1 insertion(+)
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git,
spi-nor/next branch.
Thanks,
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/