pinctrl: meson: meson: Add of_node_put() before return
Subsystems (3)
PATCH 1/1 pinctrl: meson: meson: Add of_node_put() before return
Each iteration of for_each_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return. Issue found with Coccinelle.
--- drivers/pinctrl/meson/pinctrl-meson.c | 1 + 1 file changed, 1 insertion(+)
drivers/pinctrl/meson/pinctrl-meson.c +1 -0
@@ -651,6 +651,7 @@ static int meson_pinctrl_parse_dt(struct meson_pinctrl *pc,continue ;if (gpio_np) {dev_err (pc->dev,"multiple gpio nodes\n" ); +of_node_put (np);return -EINVAL ; } gpio_np = np;
Signature · 1 line
2.19.1
Quoted 16 lines · Nishka Dasgupta
Each iteration of
for_each_child_of_nodeputs the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add anof_node_putbefore the return. Issue found with Coccinelle.Signed-off-by Nishka Dasgupta <[email protected]>--- drivers/pinctrl/meson/pinctrl-meson.c | 1 + 1 file changed, 1 insertion(+)drivers/pinctrl/meson/pinctrl-meson.c +0
-0
drivers/pinctrl/meson/pinctrl-meson.c static int meson_pinctrl_parse_dt(struct meson_pinctrl *pc, · line 657
Quoted 7 lines
drivers/pinctrl/meson/pinctrl-meson.c +1
-0@@ -651,6 +651,7 @@ static int meson_pinctrl_parse_dt(struct meson_pinctrl *pc,continue ;if (gpio_np) {dev_err (pc->dev,"multiple gpio nodes\n" ); +of_node_put (np);return -EINVAL ; } gpio_np = np;
Quoted 6 lines · Nishka Dasgupta
Each iteration of
for_each_child_of_nodeputs the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add anof_node_putbefore the return. Issue found with Coccinelle.Signed-off-by Nishka Dasgupta <[email protected]>
Patch applied with Neil's ACK.
Yours,
Linus Walleij