pinctrl: samsung: samsung: Add of_node_put() before return
Subsystems (4)
PATCH 1/1 pinctrl: samsung: samsung: Add of_node_put() before return
Each iteration of for_each_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return in three places.
Issue found with Coccinelle.
Signed-off-by Nishka Dasgupta <[email protected]>
--- drivers/pinctrl/samsung/pinctrl-samsung.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/pinctrl/samsung/pinctrl-samsung.c +7 -2
@@ -272,6 +272,7 @@ static int samsung_dt_node_to_map(struct pinctrl_dev *pctldev, &reserved_maps, num_maps);if (ret <0 ) {samsung_dt_free_map (pctldev, *map, *num_maps); +of_node_put (np);return ret; } }
@@ -785,8 +786,10 @@ static struct samsung_pmx_func *samsung_pinctrl_create_functions(if (!of_get_child_count (cfg_np)) { ret =samsung_pinctrl_create_function (dev, drvdata, cfg_np, func); -if (ret <0 ) +if (ret <0 ) { +of_node_put (cfg_np);return ERR_PTR (ret); + }if (ret >0 ) { ++func; ++func_cnt;
@@ -797,8 +800,10 @@ static struct samsung_pmx_func *samsung_pinctrl_create_functions(for_each_child_of_node (cfg_np, func_np) { ret =samsung_pinctrl_create_function (dev, drvdata, func_np, func); -if (ret <0 ) +if (ret <0 ) { +of_node_put (func_np);return ERR_PTR (ret); + }if (ret >0 ) { ++func; ++func_cnt;
Signature · 1 line
2.19.1
Krzysztof Kozlowski
maintainerQuoted 11 lines · Nishka Dasgupta
Each iteration of
for_each_child_of_nodeputs the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add anof_node_putbefore the return in three places.
Issue found with Coccinelle.Signed-off-by Nishka Dasgupta <[email protected]>--- drivers/pinctrl/samsung/pinctrl-samsung.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
This is already fixed. You can base your patches on top of linux-next to avoid duplicating effort.
Best regards,
Krzysztof